Send Device Model to Gaia on creating new user |
||||||||||||||||
Issue descriptionWe need to send device model name to Gaia.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5db398a3fa11eaed545938fb4c029b893f9864bf commit 5db398a3fa11eaed545938fb4c029b893f9864bf Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Nov 09 01:13:00 2017 Chrome OS: send device board name to Gaia. This CL adds |chromeos_board| Gaia URL parameter. Bug: 782641 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9980437bc95c5ca0287721798cd93f32ef87970 Reviewed-on: https://chromium-review.googlesource.com/758716 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#515044} [modify] https://crrev.com/5db398a3fa11eaed545938fb4c029b893f9864bf/chrome/browser/resources/gaia_auth_host/authenticator.js [modify] https://crrev.com/5db398a3fa11eaed545938fb4c029b893f9864bf/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Nov 9 2017
,
Nov 9 2017
Hi alemate@, I am testing launch bug crbug.com/779627. Could you provide instructions to verify the CL above? Does sending board name to Gaia ensure that welcome email is triggered for the user?
,
Nov 9 2017
,
Nov 9 2017
Re #4: I don't think we have anything on the Gaia side that supports this parameter yet. You can point Chrome to a different web server (instead of Gaia), and check the URL there.
,
Nov 14 2017
How do we do that?
,
Nov 20 2017
Changing bug to Assigned status since fix is not yet merged to M63
,
Nov 20 2017
,
Nov 20 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21 2017
Hi alemate@, I tested this on M64 TOT and wanted to verify if this is the expected board name info "chromeos_board=eve-signed-mpkeys" for eve device. Could you confirm?
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6699801e6a424de51283264d59cc6d1a8d81859 commit e6699801e6a424de51283264d59cc6d1a8d81859 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Nov 22 00:50:31 2017 Chrome OS: send device board name to Gaia only on user consent. This CL adds |chromeos_board| Gaia URL parameter only if user has opted into sending device statistics. Bug: 782641 Change-Id: I781e77b3ec881ea48381bfde8f51da04a2fcc733 Reviewed-on: https://chromium-review.googlesource.com/783707 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#518475} [modify] https://crrev.com/e6699801e6a424de51283264d59cc6d1a8d81859/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Nov 22 2017
Requesting merge for the second change also.
,
Nov 22 2017
#11> if this is the expected board name info "chromeos_board=eve-signed-mpkeys" for eve device. Could you confirm? Yes, it is expected. Signed images will have '-signed*'suffix in their board name.
,
Nov 22 2017
+gkihumba
,
Nov 28 2017
re expected board name, note that the board name is likely to change in future when signing key rev e.g. eve-signed-mp-v2keys alemate@ can you confirm GAIA would be able to manage this? otherwise we may need to remove the signing key string before board name is sent to GAIA
,
Nov 28 2017
See b/69059227 .
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7592629c27f2f89571636142ee6357d9442c596 commit b7592629c27f2f89571636142ee6357d9442c596 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Nov 30 08:43:09 2017 Chrome OS: add is_first_user Gaia URL parameter. This CL adds |is_first_user| Gaia URL parameter. Bug: 782641 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie81f74f715a3ade6fa8850f95d859cf46f57644e Reviewed-on: https://chromium-review.googlesource.com/786678 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#520478} [modify] https://crrev.com/b7592629c27f2f89571636142ee6357d9442c596/chrome/browser/resources/chromeos/login/screen_gaia_signin.js [modify] https://crrev.com/b7592629c27f2f89571636142ee6357d9442c596/chrome/browser/resources/gaia_auth_host/authenticator.js
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff672925053db07967f4005e3a5bde0301f29137 commit ff672925053db07967f4005e3a5bde0301f29137 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Dec 01 20:48:20 2017 ChromeOS: use GoogleUpdateSettings::GetCollectStatsConsent on blocking thread. This is an update to https://chromium-review.googlesource.com/783707 that ensures that blocking GetCollectStatsConsent is used only on a blocking thread. Bug: 782641 Change-Id: I5629e00616f1ab24b4a63f1c3433f683370c3239 Reviewed-on: https://chromium-review.googlesource.com/802764 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521055} [modify] https://crrev.com/ff672925053db07967f4005e3a5bde0301f29137/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/ff672925053db07967f4005e3a5bde0301f29137/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
,
Dec 1 2017
Let's wait for this to be verified on tot first and have some bake time before merging to M63
,
Dec 4 2017
Will verify this on M64 once build with new Chrome is available.
,
Dec 5 2017
The CL from c#19 is not available in latest M64 (10176.4.0, 64.0.3282.7) https://chromium.googlesource.com/chromium/src/+log/64.0.3280.5..64.0.3282.7?n=10000 The M65 TOT build still has old chrome version 10188.0.0, 64.0.3280.5
,
Dec 5 2017
,
Dec 5 2017
Tot pfq is still red: https://bugs.chromium.org/p/chromium/issues/detail?id=791643 Approving merge to 63, fix can be verified there.
,
Dec 6 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ee3f8643840b31dcd08c88a069eee8fd451ee22 commit 4ee3f8643840b31dcd08c88a069eee8fd451ee22 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Dec 06 01:27:44 2017 Chrome OS: send device board name to Gaia. This CL adds |chromeos_board| Gaia URL parameter. TBR=alemate@chromium.org (cherry picked from commit 5db398a3fa11eaed545938fb4c029b893f9864bf) Bug: 782641 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9980437bc95c5ca0287721798cd93f32ef87970 Reviewed-on: https://chromium-review.googlesource.com/758716 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515044} Reviewed-on: https://chromium-review.googlesource.com/809648 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#648} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/4ee3f8643840b31dcd08c88a069eee8fd451ee22/chrome/browser/resources/gaia_auth_host/authenticator.js [modify] https://crrev.com/4ee3f8643840b31dcd08c88a069eee8fd451ee22/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c14e9354de0570d907629cdb444e0decbef104c commit 5c14e9354de0570d907629cdb444e0decbef104c Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Dec 06 01:29:40 2017 Chrome OS: send device board name to Gaia only on user consent. This CL adds |chromeos_board| Gaia URL parameter only if user has opted into sending device statistics. TBR=alemate@chromium.org (cherry picked from commit e6699801e6a424de51283264d59cc6d1a8d81859) Bug: 782641 Change-Id: I781e77b3ec881ea48381bfde8f51da04a2fcc733 Reviewed-on: https://chromium-review.googlesource.com/783707 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#518475} Reviewed-on: https://chromium-review.googlesource.com/809754 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#649} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/5c14e9354de0570d907629cdb444e0decbef104c/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad384265f153ccdf5e8f22d21db941a8110c2bfa commit ad384265f153ccdf5e8f22d21db941a8110c2bfa Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Dec 06 01:33:39 2017 Chrome OS: add is_first_user Gaia URL parameter. This CL adds |is_first_user| Gaia URL parameter. TBR=alemate@chromium.org (cherry picked from commit b7592629c27f2f89571636142ee6357d9442c596) Bug: 782641 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie81f74f715a3ade6fa8850f95d859cf46f57644e Reviewed-on: https://chromium-review.googlesource.com/786678 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#520478} Reviewed-on: https://chromium-review.googlesource.com/810094 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#650} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/ad384265f153ccdf5e8f22d21db941a8110c2bfa/chrome/browser/resources/chromeos/login/screen_gaia_signin.js [modify] https://crrev.com/ad384265f153ccdf5e8f22d21db941a8110c2bfa/chrome/browser/resources/gaia_auth_host/authenticator.js
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9a4d8660acf023d47be50097739e0447401be96 commit e9a4d8660acf023d47be50097739e0447401be96 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Dec 06 01:40:28 2017 ChromeOS: use GoogleUpdateSettings::GetCollectStatsConsent on blocking thread. This is an update to https://chromium-review.googlesource.com/783707 that ensures that blocking GetCollectStatsConsent is used only on a blocking thread. TBR=alemate@chromium.org (cherry picked from commit ff672925053db07967f4005e3a5bde0301f29137) Bug: 782641 Change-Id: I5629e00616f1ab24b4a63f1c3433f683370c3239 Reviewed-on: https://chromium-review.googlesource.com/802764 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521055} Reviewed-on: https://chromium-review.googlesource.com/809568 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#651} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/e9a4d8660acf023d47be50097739e0447401be96/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/e9a4d8660acf023d47be50097739e0447401be96/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
,
Dec 6 2017
+kbleicher for M64 merge request in c#25
,
Dec 6 2017
Approving merge to M64 Chrome OS.
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ebeed1af3a70b88b031b353da38a7d06e7c227 commit 57ebeed1af3a70b88b031b353da38a7d06e7c227 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Dec 06 02:53:15 2017 ChromeOS: use GoogleUpdateSettings::GetCollectStatsConsent on blocking thread. This is an update to https://chromium-review.googlesource.com/783707 that ensures that blocking GetCollectStatsConsent is used only on a blocking thread. TBR=alemate@chromium.org (cherry picked from commit ff672925053db07967f4005e3a5bde0301f29137) Bug: 782641 Change-Id: I5629e00616f1ab24b4a63f1c3433f683370c3239 Reviewed-on: https://chromium-review.googlesource.com/802764 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521055} Reviewed-on: https://chromium-review.googlesource.com/809760 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#51} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/57ebeed1af3a70b88b031b353da38a7d06e7c227/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/57ebeed1af3a70b88b031b353da38a7d06e7c227/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
,
Jan 16 2018
10032.69.0, 63.0.3239.86 stable channel |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by alemate@chromium.org
, Nov 8 2017