git cl presubmit fails after change in java_checker.py |
||
Issue descriptiongit cl presubmit and the presubmit trybot are failing for this CL: https://crrev.com/c/739561/8 I removed a Java class and also removed it from the build file but java_checker is still trying to read it. It looks like this change to java_checker caused the issue: https://chromium.googlesource.com/chromium/buildtools.git/+/b0f94d04e26f1cdaf4d2357e0f9eeaffa894b872 Reverting the CL locally seems to fix the problem. Please take a look at this issue. Traceback (most recent call last): File "/SOME_PATH/depot_tools/git_cl.py", line 6125, in <module> sys.exit(main(sys.argv[1:])) File "/SOME_PATH/depot_tools/git_cl.py", line 6107, in main return dispatcher.execute(OptionParser(), argv) File "/SOME_PATH/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/SOME_PATH/depot_tools/git_cl.py", line 4764, in CMDpresubmit change=cl.GetChange(base_branch, None)) File "/SOME_PATH/depot_tools/git_cl.py", line 1576, in RunHook gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit()) File "/SOME_PATH/depot_tools/presubmit_support.py", line 1364, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File "/SOME_PATH/depot_tools/presubmit_support.py", line 1274, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "<string>", line 2749, in CheckChangeOnCommit File "<string>", line 2441, in _CommonChecks File "<string>", line 894, in _CheckUnwantedDependencies File "/SOME_PATH/chromium/src/buildtools/checkdeps/checkdeps.py", line 166, in CheckAddedJavaImports added_imports)) File "/SOME_PATH/chromium/src/buildtools/checkdeps/java_checker.py", line 45, in __init__ added_classset = self._PrescanImportFiles(added_imports) File "/SOME_PATH/chromium/src/buildtools/checkdeps/java_checker.py", line 98, in _PrescanImportFiles full_class_name = self._GetClassFullName(filepath) File "/SOME_PATH/chromium/src/buildtools/checkdeps/java_checker.py", line 50, in _GetClassFullName with codecs.open(filepath, encoding='utf-8') as f: File "/usr/lib/python2.7/codecs.py", line 878, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: '/SOME_PATH/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java'
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/93a751e41bd93e373548759c6c5453bd95b6f35e commit 93a751e41bd93e373548759c6c5453bd95b6f35e Author: Shenghua Zhang <shenghuazhang@chromium.org> Date: Thu Nov 09 18:30:23 2017 Fix git cl presubmit failure caused by java_checker.py scan deleted files Bug:782631 Change-Id: I8712aafafab8a0aff52e2f39219087552a9886fd [modify] https://crrev.com/93a751e41bd93e373548759c6c5453bd95b6f35e/checkdeps/java_checker.py
,
Nov 9 2017
This issue should be fixed by the above cl. Mark it as fixed.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4edbe8db9a1b051ec7e1db87b8c83f8cec7f7b0 commit e4edbe8db9a1b051ec7e1db87b8c83f8cec7f7b0 Author: Shenghua Zhang <shenghuazhang@chromium.org> Date: Thu Nov 09 21:26:38 2017 Roll src/buildtools/ 73ddd64be..93a751e41 (1 commit) https://chromium.googlesource.com/chromium/buildtools.git/+log/73ddd64be624..93a751e41bd9 $ git log 73ddd64be..93a751e41 --date=short --no-merges --format='%ad %ae %s' 2017-11-09 shenghuazhang Fix git cl presubmit failure caused by java_checker.py scan deleted files Created with: roll-dep src/buildtools TBR=jbudorick@chromium.org Bug: 782631 Change-Id: Ibd395f73994f1e23da33c89c4cfde0fe975d4645 Reviewed-on: https://chromium-review.googlesource.com/761343 Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515293} [modify] https://crrev.com/e4edbe8db9a1b051ec7e1db87b8c83f8cec7f7b0/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by shenghua...@chromium.org
, Nov 9 2017