Issue metadata
Sign in to add a comment
|
Regression : Blue focus ring appears chopped on text field in chrome://supervised-user-internals/
Reported by
vineetha...@etouch.net,
Nov 8 2017
|
||||||||||||||||||||||||
Issue descriptionChrome version: 64.0.3262.0 d4f91d118274c0f0583e7a6f196be6c48da4acc9-refs/heads/master@{#514703}(32/64-bit) OS: Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6, 10.13.2). Steps to reproduce: 1. Launch Chrome. Navigate to chrome://supervised-user-internals/. 2. Try to get focus on "Try a URL" field and observe. Actual Result: Blue focus ring on the "Try a URL" text field appears chopped. Expected Result: Blue focus ring on the "Try a URL" text field should not be chopped. This is Regression Issue broken in M-64 and using the per-revision bisect providing the bisect results, Good Build: 64.0.3249.0((Revision: 511319) Bad Build: 64.0.3250.0((Revision: 511680) You are probably looking for a change made after 511471 (known good), but no later than 511472 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/a6ba03d35d8e187799e9e3b63c98eff490018b71..2cff87c380b22ade36aa4d85a6f983387559178c Suspect : https://chromium.googlesource.com/chromium/src/+/2cff87c380b22ade36aa4d85a6f983387559178c @chrishtr : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You
,
Nov 8 2017
,
Nov 9 2017
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b689930b0918450948c72447fec65f98e7eaa9a commit 7b689930b0918450948c72447fec65f98e7eaa9a Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Nov 09 20:33:06 2017 Use BorderBoxRect when computing fragment paint offsets and column fragmentation. Visual rects may not have an origin at the (0, 0) point of the object, which makes them inappropriate for paint offsets. They are also not appropriate for fragmentation, because visual overflow should extend beyond column bounds rather than causing elements to paint into multiple fragments. Note that fragment clips may still cut off visual overflow, which is a bug, but now visual overflow will not extend across columns. Bug: 782608 , 774699 , 779998 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I23feab957c018c124f59b5b9b84644709c466e03 Reviewed-on: https://chromium-review.googlesource.com/759233 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515269} [modify] https://crrev.com/7b689930b0918450948c72447fec65f98e7eaa9a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/7b689930b0918450948c72447fec65f98e7eaa9a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by vineetha...@etouch.net
, Nov 8 2017