New issue
Advanced search Search tips

Issue 782606 link

Starred by 1 user
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Nov 2017
Cc:
msramek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebsiteSettings are included in Cookie count even if Cookies are disabled

Project Member Reported by dullweber@chromium.org, Nov 8 2017 
The Clear Browsing Data dialog is showing a non-zero cookie count when sites have been visited while cookies are disabled. This is due to the "site-engagement" WebsiteSetting.

This should be fixed as it is confusing, why there seem to be cookies when cookies are disabled. WebsiteSetting can't read or write by Websites, so they are not actually a cookie.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbff98c2376646466368c9fc5a96ddee4a2eb7d

commit 0dbff98c2376646466368c9fc5a96ddee4a2eb7d
Author: Christian Dullweber <dullweber@chromium.org>
Date: Wed Nov 22 10:03:14 2017

Remove site engagement from cookie counter

Site engagement entries are currently included in the cookie counter.
This creates an entry for every single site visited, which is
especially confusing when cookies are turned off. Site engagement
doesn't act like a cookie (it can't be read or written by a site), so
this CL removes it from the counter.

Bug:  782606 
Change-Id: Ia0953b8a34b3899d19fe19af1da3c8ec21600f23
Reviewed-on: https://chromium-review.googlesource.com/774283
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518592}
[modify] https://crrev.com/0dbff98c2376646466368c9fc5a96ddee4a2eb7d/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/0dbff98c2376646466368c9fc5a96ddee4a2eb7d/chrome/browser/browsing_data/site_data_counting_helper.cc

Comment 2 by dullweber@chromium.org, Nov 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment