xcassets are copied to the application bundle |
||||||||||||
Issue descriptionThis is incorrect, they should be passed to actool to be compiled.
,
Nov 8 2017
This is also affecting M-63. It means that all images are both present in the application bundle and in the compiled asset catalog (Assets.car). This will increase the size of the application by roughly 8Mb: $ du -ch *.xcassets|grep total 7.8M total I think this is a regression in gn.
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a19cb1ed33d46b889585385b39201198f506a384 commit a19cb1ed33d46b889585385b39201198f506a384 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 08 14:21:15 2017 Avoid copying .xcassets in the application bundle. The refactoring that introduced those templates inadvertently regressed and caused the content of .xcassets to be copied to the application bundle thus increasing the size of the bundle unnecesssarily. Bug: 782584 Change-Id: Ib7f39d00347a821467774489ecc222a57a3fe27d Reviewed-on: https://chromium-review.googlesource.com/758262 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#514819} [modify] https://crrev.com/a19cb1ed33d46b889585385b39201198f506a384/build/config/ios/asset_catalog.gni
,
Nov 8 2017
,
Nov 8 2017
This bug requires manual review: Less than 23 days to go before AppStore submit on M63 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 9 2017
Can we cherry-pick this in M-63? If we don't the app will have two copies of all resources, wasting disk space on user devices for nothing.
,
Nov 9 2017
,
Nov 9 2017
Not sure if you still want to approve this now that the build was rejected by Apple again.
,
Nov 9 2017
,
Nov 10 2017
,
Nov 10 2017
This bug requires manual review: Less than 21 days to go before AppStore submit on M63 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 10 2017
Approving the merge since this is unrelated to the issue I was referring to.
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de8511c1146f5a4e6d0dde917d8b6d5ae5aebdab commit de8511c1146f5a4e6d0dde917d8b6d5ae5aebdab Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 13 08:50:58 2017 Avoid copying .xcassets in the application bundle. The refactoring that introduced those templates inadvertently regressed and caused the content of .xcassets to be copied to the application bundle thus increasing the size of the bundle unnecesssarily. Bug: 782584 Change-Id: Ib7f39d00347a821467774489ecc222a57a3fe27d Reviewed-on: https://chromium-review.googlesource.com/758262 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#514819}(cherry picked from commit a19cb1ed33d46b889585385b39201198f506a384) Reviewed-on: https://chromium-review.googlesource.com/765369 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#457} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/de8511c1146f5a4e6d0dde917d8b6d5ae5aebdab/build/config/ios/asset_catalog.gni |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by sdefresne@chromium.org
, Nov 8 2017