Issue metadata
Sign in to add a comment
|
external keyboard caps-lock to ctrl mapping still works as caps lock |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3255.0, 64.0.3257.0 CrOS: Kevin What steps will reproduce the problem? (1) attach USB external keyboard (2) open settings and select Caps Lock to be mapped to Ctrl key. (3) Try key combination like caps lock + W What is the expected result? ctrl-w results in window closing What happens instead? ctrl-w results in window closing and caps lock turns on. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 9 2017
last known good version is probably 9973
,
Nov 9 2017
warx@ please triage
,
Nov 9 2017
weidongg, this might be related to the recent caps lock changes. Please take a look. Thank you!
,
Nov 9 2017
Yes, it's related to my CL. This occurs because Caps Lock modifier is not removed when Caps Lock key is remapped to Ctrl key. I am working on a fix: https://chromium-review.googlesource.com/c/chromium/src/+/759816
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4534b86e23673cf46ccbbb966f9431628a029b00 commit 4534b86e23673cf46ccbbb966f9431628a029b00 Author: Weidong Guo <weidongg@chromium.org> Date: Fri Nov 10 03:17:05 2017 Fix Caps Lock remapping issue Changes: Remove the Caps Lock modifier for key event when Caps Lock key is remapped to another key. BUG= 782572 TEST=EventRewriterTest.TestRewriteCapsLock Change-Id: I561931034acb94719750f9c70f7b8feb6cee5219 Reviewed-on: https://chromium-review.googlesource.com/759816 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515436} [modify] https://crrev.com/4534b86e23673cf46ccbbb966f9431628a029b00/chrome/browser/chromeos/events/event_rewriter_unittest.cc [modify] https://crrev.com/4534b86e23673cf46ccbbb966f9431628a029b00/ui/chromeos/events/event_rewriter_chromeos.cc
,
Nov 10 2017
,
Nov 17 2017
Issue 781568 has been merged into this issue.
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by uekawa@google.com
, Nov 8 2017