New issue
Advanced search Search tips

Issue 782540 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR



Sign in to add a comment

36kB regression in resource_sizes (MonochromePublic.apk) at 514593:514593

Project Member Reported by huangs@google.com, Nov 8 2017

Issue description

Caused by “[vr] Use Ganesh for Skia texture drawing”

Commit: a60b82cb9c64ba3b5f709a2751fe875ba59c0880	

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=514593

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: 36kb of native code.

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.

 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=782540

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=79d7ce18a671ec5c0a0737c00f6c009a65aee5a097af4ee1646f830f91c310b7


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by huangs@google.com, Nov 8 2017

Output of:
tools/binary_size/diagnose_bloat.py --cloud a60b82cb9c64ba3b5f709a2751fe875ba59c0880

******************************Native Diff******************************
Common Metadata:
    apk_file_name=apks/MonochromePublic.apk
    elf_arch=arm
    elf_file_name=lib.unstripped/libmonochrome.so
    gn_args=ffmpeg_branding="Chrome" goma_dir="/b/build/slave/cache/goma_client" is_chrome_branded=true is_debug=false is_official_build=true proprietary_codecs=true strip_absolute_paths_from_debug_symbols=true symbol_level=1 target_os="android" use_goma=true
    map_file_name=lib.unstripped/libmonochrome.so.map.gz
    tool_prefix=third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-
Old Metadata:
    elf_build_id=4e43e6ebdbe4c1e5b8ded7b9cafbacc87675a13e
    elf_mtime=2017-11-07 17:06:53
    git_revision=395d0048c8821cb676d38b601e84ec193aa1ed24
New Metadata:
    elf_build_id=6b70f82c4e815dc86fd510a6b17af1b54d7666f6
    elf_mtime=2017-11-07 17:13:41
    git_revision=a60b82cb9c64ba3b5f709a2751fe875ba59c0880

Section Sizes (Total=38.0kb (38939 bytes)):
    .bss: 0 bytes (0 bytes) (not included in totals)
    .data: 0 bytes (0 bytes) (0.0%)
    .data.rel.ro: 32 bytes (32 bytes) (0.1%)
    .dynstr: 1724 bytes (1724 bytes) (4.4%)
    .dynsym: 1680 bytes (1680 bytes) (4.3%)
    .rel.dyn: 880 bytes (880 bytes) (2.3%)
    .rodata: 4.00kb (4096 bytes) (10.5%)
    .text: 28.8kb (29441 bytes) (75.6%)

383 symbols added (+), 9 changed (~), 8 removed (-), 827375 unchanged (not shown)
Of changed symbols, 390 grew, 10 shrank
Number of unique symbols 509565 -> 509743 (+178)
2 paths added, 0 removed, 7 changed

Showing 400 symbols (aliases not grouped for diffs) with total pss: 33569 bytes
Histogram of symbols based on PSS:
    (-512,-256]: 1   (-32,-16]: 2   (0,1): 34     [8,16): 67      [128,256): 4
    (-256,-128]: 1    (-16,-8]: 1   [1,2): 14    [16,32): 92      [256,512): 2
     (-128,-64]: 2     (-8,-4]: 1   [2,4): 99    [32,64): 13    [2048,4096): 1
      (-64,-32]: 1      (-1,0): 1   [4,8): 55   [64,128): 7    [8192,16384): 2
.text=28.8kb     .rodata=4.00kb     .data.rel.ro=32 bytes   .data=0 bytes    .bss=0 bytes    total=32.8kb
Number of unique paths: 17

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
+ 0)      14224 (42.9%) t@0x67cc90   14224 (0->14224)   third_party/skia/src/gpu/gl/GrGLAssembleInterface.cpp
               GrGLAssembleGLInterface
+ 1)      24404 (73.5%) t@0x67a4cc   10180 (0->10180)   third_party/skia/src/gpu/gl/GrGLAssembleInterface.cpp
               GrGLAssembleGLESInterface
+ 2)      27976 (84.3%) t@0x6d6100   3572 (0->3572)     third_party/skia/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp
               android_get_gl_proc
+ 3)      28294 (85.3%) t@0x25a5028  318 (0->316)       chrome/browser/vr/cpu_surface_provider.cc
               vr::CpuSurfaceProvider::FlushSurface
+ 4)      28580 (86.1%) t@0x5fec10   286 (0->284)       third_party/skia/src/gpu/GrContext.cpp
               GrContext::MakeGL
- 5)      28300 (85.3%) t@0x0        -280 (280->0)      chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Flush
- 6)      28060 (84.6%) t@0x0        -240 (240->0)      chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Initialize
+ 7)      28276 (85.2%) t@0x25a7644  216 (0->216)       chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Initialize
+ 8)      28448 (85.7%) t@0x25adeb0  172 (0->172)       chrome/browser/vr/ui.cc
               vr::Ui::OnGlInitialized
~ 9)      28619 (86.2%) t@Group      171 (0->0)         {{no path}}
               ** symbol gaps (count=9)
+ 10)     28749 (86.6%) t@0x694418   130 (0->128)       third_party/skia/src/gpu/gl/GrGLUtil.cpp
               GrGLGetStandardInUseFromString
- 11)     28633 (86.3%) t@0x0        -116 (116->0)      chrome/browser/vr/ui.cc
               vr::Ui::OnGlInitialized
+ 12)     28747 (86.6%) t@0x25afdd0  114 (0->114)       chrome/browser/vr/ui_scene.cc
               vr::UiScene::OnGlInitialized
- 13)     28639 (86.3%) t@0x0        -108 (108->0)      chrome/browser/vr/ui_scene.cc
               vr::UiScene::OnGlInitialized
+ 14)     28731 (86.6%) t@0x25aaa3c  92 (0->92)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::GaneshSurfaceProvider
+ 15)     28811 (86.8%) t@0x25aab08  80 (0->80)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::FlushSurface
+ 16)     28888 (87.0%) r@0x0        77 (0->0)          {{no path}}
               ** aggregate padding of diff'ed symbols
+ 17)     28958 (87.3%) t@0x25aaac2  70 (0->70)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::MakeSurface
+ 18)     29026 (87.5%) t@0x67a488   68 (0->68)         third_party/skia/src/gpu/gl/GrGLAssembleInterface.cpp
               GrGLAssembleInterface
+ 19)     29092 (87.7%) t@0x5febcc   66 (0->66)         third_party/skia/src/gpu/GrContext.cpp
               GrContext::MakeGL
+ 20)     29151 (87.8%) t@0x6846ec   59 (0->59)         third_party/skia/src/gpu/gl/GrGLGpu.cpp
               GrGLGpu::Create (num_aliases=2)
~ 21)     29097 (87.7%) t@Group      -53 (54->0.4)      chrome/browser/vr/ui_scene.cc
               vr::UiScene::~UiScene (count=2)
+ 22)     29143 (87.8%) t@0x0        46 (0->0)          {{no path}}
               ** aggregate padding of diff'ed symbols
+ 23)     29185 (87.9%) t@0x6805ca   42 (0->42)         third_party/skia/src/gpu/gl/GrGLAssembleInterface.cpp
               GrGLFunction::GrGLFunction
+ 24)     29227 (88.1%) t@Group      42 (0->42)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::~GaneshSurfaceProvider (count=2)
+ 25)     29264 (88.2%) r@0x266cec9  37 (0->37)         third_party/skia/src/gpu/gl/GrGLAssembleInterface.cpp
               string literal
+ 26)     29301 (88.3%) r@0x27ea756  37 (0->37)         gpu/command_buffer/service/gles2_cmd_decoder.cc
               string literal
+ 27)     29337 (88.4%) r@0x27ea316  36 (0->36)         gpu/command_buffer/service/gles2_cmd_decoder.cc
               string literal
~ 28)     29373 (88.5%) t@Group      35 (0.4->36)       chrome/browser/vr/elements/textured_element.cc

I  81674 Creating: Resource Sizes Diff

******************************Resource Sizes Diff******************************
MonochromePublic.apk_Breakdown (+36,864 bytes)
        -2 bytes Zip Overhead
   +36,864 bytes Native code size
        +2 bytes Package metadata size
MonochromePublic.apk_Specifics
   +36,864 bytes normalized apk size
   +36,864 bytes main lib size

I  81678 See detailed diff results here: out/binary-size-results/diffs/395d0048c8821cb676d38b601e84ec193aa1ed24..a60b82cb9c64ba3b5f709a2751fe875ba59c0880/diff_results.txt

Diff Summary
    +36864 bytes MonochromePublic.apk_Specifics normalized apk size for range: 395d0048c8821cb676d38b601e84ec193aa1ed24..a60b82cb9c64ba3b5f709a2751fe875ba59c0880
I  81678 Enter supersize console via: tools/binary_size/supersize console out/binary-size-results/395d0048c8821cb676d38b601e84ec193aa1ed24/MonochromePublic.apk.size out/binary-size-results/a60b82cb9c64ba3b5f709a2751fe875ba59c0880/MonochromePublic.apk.size

Components: Internals>VR
Labels: OS-Android
Labels: -Pri-2 Pri-1
Using https://cs.chromium.org/chromium/src/gpu/command_buffer/service/create_gr_gl_interface.cc to instantiate the GrGLInterface may reduce binary size impact.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48990226a6eb7d607de40fc77c060001dd4faa0b

commit 48990226a6eb7d607de40fc77c060001dd4faa0b
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Mon Nov 13 21:52:58 2017

[vr] Re-enable Ganesh and link to correct GL interface

Bind Ganesh to //ui/gl provided GL functions. This avoids the need for
linking to system provided EGL and GLESv2 libraries.

Bug: 782871,  782540 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I04f250ac68b926b25c7563a8fad4f7d939930da2
Reviewed-on: https://chromium-review.googlesource.com/764648
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516068}
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/chrome/browser/vr/ganesh_surface_provider.cc
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/chrome/browser/vr/text_perftest.cc
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/gpu/command_buffer/service/BUILD.gn
[delete] https://crrev.com/ed18fe2b20502b20ee5a2172ae42509e3cd90f8f/gpu/command_buffer/service/create_gr_gl_interface.h
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/skia/BUILD.gn
[modify] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/ui/gl/init/BUILD.gn
[rename] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/ui/gl/init/create_gr_gl_interface.cc
[add] https://crrev.com/48990226a6eb7d607de40fc77c060001dd4faa0b/ui/gl/init/create_gr_gl_interface.h

Comment 7 by tiborg@chromium.org, Nov 13 2017

That should be fixed now. Is there a way to validate that? tools/binary_size/diagnose_bloat.py 48990226a6eb7d607de40fc77c060001dd4faa0b --cloud did not work.
That command works. You probably just ran it before the bot had built your commit.

Looks like it didn't shrink the binary at all, just traded gpu::gles2::CreateGrGLInterface for gl::init::CreateGrGLInterface.

- 0)      -5170 (-11574.5%) t@0x0        -5170 (5168->0)    gpu/command_buffer/service/create_gr_gl_interface.cc
               gpu::gles2::CreateGrGLInterface
+ 1)       -316 (-707.5%) t@0xa720b4   4854 (0->4852)     ui/gl/init/create_gr_gl_interface.cc
               gl::init::CreateGrGLInterface
~ 2)       -172 (-385.1%) t@0x25be2f4  144 (92->236)      chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::GaneshSurfaceProvider
~ 3)        -96 (-214.9%) t@Group      76 (0->0)          {{no path}}
               ** symbol gaps (count=9)
+ 4)       -158 (-353.7%) t@0x0        -61 (0->0)         {{no path}}
               ** aggregate padding of diff'ed symbols
+ 5)       -102 (-228.4%) R@0x2c6b7d0  56 (0->56)         ui/gl/init/create_gr_gl_interface.cc
               gl::init::kBlacklistExtensions
+ 6)        -54 (-120.9%) t@0xa7340c   48 (0->48)         ui/gl/init/create_gr_gl_interface.cc
               GrGLFunction::GrGLFunction
- 7)       -102 (-228.4%) t@0x0        -48 (48->0)        gpu/command_buffer/service/create_gr_gl_interface.cc
               GrGLFunction::GrGLFunction
+ 8)        -58 (-129.8%) t@0xa733e0   44 (0->44)         ui/gl/init/create_gr_gl_interface.cc
               SkTArray::~SkTArray
~ 9)        -21 (-48.4%) r@0x26f95a5  36 (6.6->43)       ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=5->1)
+ 10)        10 (23.3%) t@0xa733a8   32 (0->32)         ui/gl/init/create_gr_gl_interface.cc
               GrGLExtensions::GrGLExtensions
~ 11)       -16 (-37.2%) r@0x26f95d0  -27 (59->32)       ui/gl/init/create_gr_gl_interface.cc
               string literal
~ 12)       -41 (-93.7%) r@0x267f042  -25 (32->6.8)      ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=1->4)
~ 13)       -16 (-37.4%) t@0xa7346a   25 (4.9->30)       ui/gl/init/create_gr_gl_interface.cc
               GrGLFunction::GrGLFunction (num_aliases=7->1)
+ 14)       7.3 (16.3%) t@0xa733c8   24 (0->24)         ui/gl/init/create_gr_gl_interface.cc
               GrGLExtensions::~GrGLExtensions
+ 15)        31 (70.1%) t@0xa73452   24 (0->24)         ui/gl/init/create_gr_gl_interface.cc
               GrGLFunction::GrGLFunction
- 16)       7.3 (16.3%) t@0x0        -24 (24->0)        gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
               GrGLFunction::GrGLFunction
+ 17)        29 (65.6%) t@0xa7343c   22 (0->22)         ui/gl/init/create_gr_gl_interface.cc
               GrGLFunction::GrGLFunction
- 18)       7.3 (16.3%) t@0x0        -22 (22->0)        gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
               GrGLFunction::GrGLFunction
+ 19)        23 (52.1%) r@0x0        16 (0->0)          {{no path}}
               ** aggregate padding of diff'ed symbols
+ 20)        31 (70.1%) R@0x0        +8 (0->0)          {{no path}}
               ** aggregate padding of diff'ed symbols
+ 21)        38 (87.1%) t@0x9a2ab4   +7.6 (0->7.6)      ui/gl/init/create_gr_gl_interface.cc
               gl::GLVersionInfo::IsAtLeastGL const (num_aliases=5)
+ 22)        46 (104.1%) t@0x9a2a8e   +7.6 (0->7.6)      ui/gl/init/create_gr_gl_interface.cc
               gl::GLVersionInfo::IsAtLeastGLES const (num_aliases=5)
~ 23)        44 (99.0%) r@0x267f0aa  -2.2 (5.8->3.5)    ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=4)
~ 24)        46 (103.8%) r@0x267f4c4  +2.1 (4.5->6.6)    ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=6->5)
~ 25)        44 (99.3%) r@0x26ea1e0  -2 (9->7)          ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=3->2)
~ 26)        42 (95.4%) r@0x267f012  -1.8 (7->5.2)      ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=2->4)
~ 27)        44 (98.7%) r@0x267f027  +1.5 (5.2->6.8)    ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=4)
~ 28)        45 (101.0%) r@0x267ec81  +1 (5.5->6.5)      ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=4)
~ 29)        46 (103.2%) r@0x267ecee  +1 (3.5->4.5)      ui/gl/init/create_gr_gl_interface.cc
               string literal (num_aliases=4->6)

Comment 9 by tiborg@chromium.org, Nov 14 2017

So, there was a bit of back and forth adding Ganesh. The relevant commits are:
- a60b82cb9c64ba3b5f709a2751fe875ba59c0880: +36,864 bytes
- 4c50a1681d406258bc2ccc5ba896a42d8b57b3d3: -36,864 bytes
- 3d8447c084b20658f8b494222aeec3b94b7dc503 +4,096 bytes
- 48990226a6eb7d607de40fc77c060001dd4faa0b +0 bytes

So, in total we should be at only +4k. However, I'm a bit confused why 3d8447c084b20658f8b494222aeec3b94b7dc503 added 4k of native code size. Is that some kind of padding thing? Output is:

+ 0)        318 (29.7%) t@0x25a4920  318 (0->316)       chrome/browser/vr/cpu_surface_provider.cc
               vr::CpuSurfaceProvider::FlushSurface
+ 1)        602 (56.3%) t@0x600e20   284 (0->284)       third_party/skia/src/gpu/GrContext.cpp
               GrContext::MakeGL
- 2)        322 (30.1%) t@0x0        -280 (280->0)      chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Flush
- 3)         82 (7.7%)  t@0x0        -240 (240->0)      chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Initialize
+ 4)        298 (27.9%) t@0x25a737c  216 (0->216)       chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Initialize
~ 5)        488 (45.6%) t@Group      190 (0->0)         {{no path}}
               ** symbol gaps (count=9)
+ 6)        660 (61.7%) t@0x25adcc8  172 (0->172)       chrome/browser/vr/ui.cc
               vr::Ui::OnGlInitialized
- 7)        544 (50.9%) t@0x0        -116 (116->0)      chrome/browser/vr/ui.cc
               vr::Ui::OnGlInitialized
+ 8)        658 (61.5%) t@0x25afb1c  114 (0->114)       chrome/browser/vr/ui_scene.cc
               vr::UiScene::OnGlInitialized
- 9)        550 (51.4%) t@0x0        -108 (108->0)      chrome/browser/vr/ui_scene.cc
               vr::UiScene::OnGlInitialized
+ 10)       642 (60.0%) t@0x25aa774  92 (0->92)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::GaneshSurfaceProvider
+ 11)       722 (67.5%) t@0x25aa840  80 (0->80)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::FlushSurface
+ 12)       798 (74.6%) t@0x600dd4   76 (0->76)         third_party/skia/src/gpu/GrContext.cpp
               GrContext::MakeGL
+ 13)       868 (81.2%) t@0x25aa7fa  70 (0->70)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::MakeSurface
+ 14)       927 (86.7%) t@0x680b6c   59 (0->59)         third_party/skia/src/gpu/gl/GrGLGpu.cpp
               GrGLGpu::Create (num_aliases=2)
~ 15)       873 (81.7%) t@Group      -53 (54->0.4)      chrome/browser/vr/ui_scene.cc
               vr::UiScene::~UiScene (count=2)
+ 16)       915 (85.6%) t@Group      42 (0->42)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider::~GaneshSurfaceProvider (count=2)
+ 17)       877 (82.1%) t@0x0        -38 (0->0)         {{no path}}
               ** aggregate padding of diff'ed symbols
~ 18)       913 (85.4%) t@Group      35 (0.4->36)       chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::~TexturedElement (count=2)
+ 19)       943 (88.2%) t@0x25b3730  30 (0->30)         chrome/browser/vr/ui_scene_manager.cc
               vr::UiSceneManager::OnGlInitialized
~ 20)       971 (90.8%) t@0x25a7454  28 (120->148)      chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::UpdateTexture
- 21)       945 (88.4%) t@0x0        -26 (26->0)        chrome/browser/vr/ui_scene_manager.cc
               vr::UiSceneManager::OnGlInitialized
+ 22)       969 (90.6%) R@0x2ddc63c  24 (0->24)         chrome/browser/vr/cpu_surface_provider.cc
               vr::CpuSurfaceProvider [vtable]
+ 23)       993 (92.9%) R@0x2ddd5d0  24 (0->24)         chrome/browser/vr/ganesh_surface_provider.cc
               vr::GaneshSurfaceProvider [vtable]
+ 24)      1011 (94.6%) t@0x25add98  18 (0->18)         chrome/browser/vr/ui.cc
               _ZN4base10MakeUniqueIN2vr18CpuSurfaceProviderEJEEEDTclsr3stdE11make_uniqueIT_Espclsr3stdE7forwardIT0_Efp_EEEDpOS4_
+ 25)      1029 (96.2%) t@0x25add86  18 (0->18)         chrome/browser/vr/ui.cc
               _ZN4base10MakeUniqueIN2vr21GaneshSurfaceProviderEJEEEDTclsr3stdE11make_uniqueIT_Espclsr3stdE7forwardIT0_Efp_EEEDpOS4_
+ 26)      1045 (97.7%) t@0x25a4900  16 (0->16)         chrome/browser/vr/cpu_surface_provider.cc
               vr::CpuSurfaceProvider::CpuSurfaceProvider
~ 27)      1061 (99.2%) t@Group      16 (142->158)      chrome/browser/vr/ui.cc
               vr::Ui::~Ui (count=2)
- 28)      1045 (97.7%) R@0x0        -16 (16->0)        chrome/browser/vr/ui_scene.cc
               vr::UiScene [vtable]
+ 29)      1059 (99.1%) t@0x25a4910  14 (0->14)         chrome/browser/vr/cpu_surface_provider.cc
               vr::CpuSurfaceProvider::MakeSurface
+ 30)      1072 (100.3%) t@0x31a0f4   13 (0->13)         chrome/browser/vr/ganesh_surface_provider.cc
               SkSafeUnref (num_aliases=3)
~ 31)      1064 (99.6%) t@0x25afaa0  -8 (112->104)      chrome/browser/vr/ui_scene.cc
               vr::UiScene::UiScene
+ 32)      1066 (99.8%) t@0x324fe2   +2.3 (0->2.3)      chrome/browser/vr/ganesh_surface_provider.cc
               SkImageInfo::MakeN32Premul (num_aliases=25)
~ 33)      1068 (100.0%) t@0x25af01c  +2 (196->198)      chrome/browser/vr/ui_scene.cc
               vr::UiScene::AddUiElement
+ 34)      1068 (100.0%) t@0x319f18   +0.2 (0->0.2)      chrome/browser/vr/ganesh_surface_provider.cc
               sk_sp::~sk_sp (num_aliases=81)
+ 35)      1068 (100.0%) t@0x31a178   +0.1 (0->0.1)      chrome/browser/vr/elements/textured_element.cc
               sk_sp::reset (num_aliases=73)
+ 36)      1069 (100.0%) t@0x31a178   +0.1 (0->0.1)      chrome/browser/vr/ganesh_surface_provider.cc
               sk_sp::reset (num_aliases=73)
+ 37)      1069 (100.0%) t@Group      ~0 (0->~0)         chrome/browser/vr/cpu_surface_provider.cc
               vr::CpuSurfaceProvider::~CpuSurfaceProvider (count=2)
+ 38)      1069 (100.0%) t@0x308ae0   ~0 (0->~0)         third_party/skia/src/gpu/gl/GrGLCreateNativeInterface_none.cpp
               GrGLCreateNativeInterface (num_aliases=7467)
- 39)      1069 (100.0%) t@0x0        ~0 (~0->0)         chrome/browser/vr/elements/ui_element.cc
               vr::UiElement::Initialize (num_aliases=17245)
+ 40)      1069 (100.0%) t@0x308972   ~0 (0->~0)         chrome/browser/vr/elements/ui_element.cc
               vr::UiElement::Initialize (num_aliases=17246)
+ 41)      1069 (100.0%) b@0x2e99d1c  +7 (0->4)          chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Initialize::trace_event_unique_atomic27
- 42)      1069 (100.0%) b@0x0        -7 (4->0)          chrome/browser/vr/elements/textured_element.cc
               vr::TexturedElement::Initialize::trace_event_unique_atomic27

Status: Fixed (was: Assigned)
Components: Internals>XR

Sign in to add a comment