New issue
Advanced search Search tips

Issue 782539 link

Starred by 1 user
Status: Fixed
Owner:
hiroh@chromium.org
Closed: Nov 2017
Cc:
kcwu@chromium.org
steve...@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

histogram_verifier error message should be more obvious

Project Member Reported by akes...@chromium.org, Nov 8 2017 
Follow up to  Issue 782509 

We often get cryptic failures of the form "XXX not loaded or histogram bucket not found or histogram bucket found at < 100%"

Seems like the code that is emitting this exception should at least be able to distinguish between those 3 mentioned cases, and tell us which one it actually was.

More specific messaging would make these failures easy to fix.

Relevant code is here
http://cs/chromeos_public/src/third_party/autotest/files/client/cros/video/histogram_verifier.py?l=43&rcl=584d243286f682dc1c2277873ce908b2503e55f6

Comment 1 by hiroh@chromium.org, Nov 8 2017

Cc: -cywang@chromium.org -puthik@chromium.org -ddavenp...@chromium.org -steve...@chromium.org
Labels: videoshortlist
I uploaded the CL for this. crosreview.com/757944
Because the issue of  crbug.com/782509  would be fixed by crosreview.com/757890, I deal with this issue as one not related to crosreview.com/782509.

Comment 2 by hiroh@chromium.org, Nov 8 2017

Cc: kcwu@chromium.org
Components: -Infra>Client>ChromeOS OS>Kernel>Video

Comment 3 by akes...@chromium.org, Nov 9 2017

Cc: steve...@chromium.org

Comment 4 by steve...@chromium.org, Nov 9 2017 

Thanks for working on this. The confusion is masking real regressions, e.g.  issue 783312 .
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c5e0df92d84a7f4fbcc7157c9772ef1533fff279

commit c5e0df92d84a7f4fbcc7157c9772ef1533fff279
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Tue Nov 14 03:56:10 2017

autotest: output chrome://histogram bucket results in debug log

The error message of histogram_verifier only tells that the targeted histogram
value is not 100%. It is useless in debugging.
Therefore, I changed all the targeted histogram bucket values are outputted in
debug log whenever querying the buckets values.

BUG= chromium:782539 
TEST=video_ChromeHWDecodeUsed, video_PlaybackPerf, video_WebRtcPerf on peach_pit
TEST=video_ChromeVidResChangeHWDecode, video_ChromeRTCHWDecodeUsed on peach_pit

Change-Id: I838dad8d8330639ef7917d7c8577727ee9239bf0
Reviewed-on: https://chromium-review.googlesource.com/757944
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/c5e0df92d84a7f4fbcc7157c9772ef1533fff279/client/cros/video/histogram_verifier.py

Comment 6 by hiroh@chromium.org, Nov 14 2017

Status: Fixed (was: Untriaged)

Comment 7 by akes...@chromium.org, Nov 14 2017 

Thank you!
►

Sign in to add a comment