Mac: Bookmarks Bar bookmark title gets squished and clipped instead of truncating |
|||||
Issue descriptionChrome Version : 64.0.3260.2 OS Version: OS X 10.12.6 What steps will reproduce the problem? 1. Add a bookmark, give it a title to obtain a specific length, close to the maximum width (for me, it was "Pilates Classes - Grow" - don't judge me :p) What is the expected result? No text clipping. What happens instead of that? Text gets clipped. The font kerning also changes slightly. This seems similar to an issue we had with the omnibox after bumping the SDK version we link with - maybe this regressed at the same time. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3260.2 Safari/537.36
,
Nov 8 2017
,
Nov 8 2017
I can repro this. jmukthavaram@ I think it needs to be the exact text tapted@ provided.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6dd96ffb49cea709f1373d01e7e7e19307a886f commit c6dd96ffb49cea709f1373d01e7e7e19307a886f Author: Sidney San Martín <sdy@chromium.org> Date: Wed Dec 20 21:52:43 2017 [Mac] Ensure bookmark button titles elide correctly in LTR. Currently, when drawing the title of a bookmark button cell in LTR, the width isn't set, and the default width sticks out slightly from the trailing edge of the cell. This causes titles that are just slightly too big to fit into the cell to be clipped to the edge of the button. This change avoids separate code paths for LTR and RTL by laying out the title for LTR, always, and then flipping it if necessary. Bug: 782537 , 782916 Change-Id: I31624822c79e45152426f914d5fde70243ec0e40 Reviewed-on: https://chromium-review.googlesource.com/835128 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525477} [modify] https://crrev.com/c6dd96ffb49cea709f1373d01e7e7e19307a886f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Dec 20 2017
,
Jan 2 2018
Tested this issue on Mac OS using chrome latest Canary-65.0.3309.0 as per the steps mentioned in C#0. No clipped bookmark text on bookmark bar is observed for all the bookmarks. tapted@, Please find the attached screencast for reference & confirm on the fix & the expected behavior. Thanks in advance..!
,
Jan 2 2018
Tested on Mac 10.12.6.
,
Jan 5 2018
Thanks! This looks good to me.
,
Jan 8 2018
tapted@, Could you please check this issue as C#6 & confirm on the fix. Thanks in advance..!
,
Jan 8 2018
tapted@: 👍! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jmukthavaram@chromium.org
, Nov 8 2017Labels: Needs-Traige-M64 Needs-Feedback
2.3 MB
2.3 MB View Download