New issue
Advanced search Search tips

Issue 782532 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl lint build/include_order for WebKit test naming style like BlobBytesProviderTest

Project Member Reported by lucmult@chromium.org, Nov 8 2017

Issue description

WebKit naming doesn't follow the _test.cpp suffix.

Example message from "git cl lint":
third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp:7:  Found C++ system header after other header. Should be: BlobBytesProviderTest.h, c system, c++ system, other.  [build/include_order] [4]
third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp:8:  Found C++ system header after other header. Should be: BlobBytesProviderTest.h, c system, c++ system, other.  [build/include_order] [4]
third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp:9:  Found C++ system header after other header. Should be: BlobBytesProviderTest.h, c system, c++ system, other.  [build/include_order] [4]

With the includes being:
#include "platform/blob/BlobBytesProvider.h"

#include <algorithm>
#include <memory>
#include <utility>

#include "base/files/file.h"
#include "base/files/file_util.h"
#include "base/run_loop.h"
#include "base/test/scoped_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"


 
Components: Tools

Sign in to add a comment