New issue
Advanced search Search tips

Issue 782531 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

security_CroshModules: move to ImageTest

Project Member Reported by vapier@chromium.org, Nov 8 2017

Issue description

It doesn't need to be an Autotest since it tests something static about the image. ImageTest runs a lot faster.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a320197863bf24fde5345e3f973b07a9d67a4316

commit a320197863bf24fde5345e3f973b07a9d67a4316
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Nov 10 17:16:34 2017

image_test: move security_CroshModules autotest here

This logic is ported directly from the security_CroshModules autotest.

BUG= chromium:782531 
TEST=`test_image chromiumos_image.bin CroshTest.TestUnknownModules` passes

Change-Id: Ief9804547167795f8cf5a93280afe1bf92b10d7e
Reviewed-on: https://chromium-review.googlesource.com/758219
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/a320197863bf24fde5345e3f973b07a9d67a4316/cros/test/image_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/825bc44607e9a96c4f550536b7a101d90b56e65b

commit 825bc44607e9a96c4f550536b7a101d90b56e65b
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Nov 10 22:05:47 2017

autotest-tests-security: drop security_CroshModules

We've moved this to image_test now.

BUG= chromium:782531 
TEST=precq passes
CQ-DEPEND=CL:758219

Change-Id: Ibedb3cee2093cb7e3d6aff3356a5c73a5a438b16
Reviewed-on: https://chromium-review.googlesource.com/758220
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/825bc44607e9a96c4f550536b7a101d90b56e65b/chromeos-base/autotest-tests-security/autotest-tests-security-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2017

Comment 4 by vapier@chromium.org, Nov 11 2017

Status: Fixed (was: Available)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment