New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782528 link

Starred by 1 user
Status: Fixed
Owner:
█ xiaofeng...@intel.com
Email to this user bounced
Closed: Jan 2018
Cc:
falken@chromium.org
kinuko@chromium.org
leon....@intel.com
shimazu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 794495
Blocking:
issue 772793
issue 780366



Sign in to add a comment

Eliminate native content::ServiceWorkerClientInfo and content::ServiceWorkerClientQueryOptions

Project Member Reported by leon....@intel.com, Nov 8 2017 
Create mojom structs to replace content::ServiceWorkerClientInfo and and content::ServiceWorkerClientQueryOptions everywhere.

new mojom file:
third_party/WebKit/public/platform/modules/serviceworker/service_worker_client.mojom

'
struct ServiceWorkerClientInfo {
  XXXX
};

struct ServiceWorkerClientQueryOptions {
  XXXX
};
'

We need to pass these 2 types over Mojo interface methods.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e

commit cf0a3c54a27294e1c220bee8d0608fd62cc72e7e
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Fri Nov 17 04:33:01 2017

[ServiceWorker] Introduce blink.mojom.WebPageVisibilityState enum

This CL creates blink.mojom.WebPageVisibilityState enum type and uses it
to replace existing native enum type blink::WebPageVisibilityState.

This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo,
and finally to remove content::ExtendableMessageEventSource, which is an
incremental step toward Onion Soup: having less dependence on content types
for service worker.

BUG= 782528 

Change-Id: Ic066d85ff5e7cc5b25b7942fadfe9d5835d17d4c
Reviewed-on: https://chromium-review.googlesource.com/762524
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517300}
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/browser/after_startup_task_utils.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/browser/notifications/notification_permission_context.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/renderer/DEPS
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/components/plugins/renderer/DEPS
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/DEPS
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/frame_host/navigation_request_info.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/frame_host/navigation_request_info.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/frame_host/render_frame_host_impl_browsertest.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/common/DEPS
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/common/content_param_traits_macros.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/common/service_worker/service_worker_client_info.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/common/service_worker/service_worker_client_info.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/browser/content_browser_client.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/browser/render_frame_host.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/browser/resource_request_info.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/common/resource_request.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/public/renderer/render_frame.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/renderer/render_frame_impl.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/renderer/render_view_impl.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/content/test/test_render_frame_host.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/extensions/renderer/DEPS
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/extensions/renderer/scoped_web_frame.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/page/PageVisibilityState.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/page/PageVisibilityState.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/core/timing/PerformanceNavigationTimingTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/canvas/offscreencanvas/OffscreenCanvasTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLockTest.cpp
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/common/BUILD.gn
[add] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/common/page/OWNERS
[add] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/common/page/page_visibility_state.mojom
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/48633222cdc4af04df7bdefa16166be77df07070/third_party/WebKit/public/platform/WebPageVisibilityState.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/public/web/WebView.h
[modify] https://crrev.com/cf0a3c54a27294e1c220bee8d0608fd62cc72e7e/third_party/WebKit/public/web/WebViewClient.h
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e65b0925a1d31c399afd1e018725f1162ad086a

commit 5e65b0925a1d31c399afd1e018725f1162ad086a
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Thu Nov 23 05:08:42 2017

[ServiceWorker] Introduce blink.mojom.ServiceWorkerClientType

This CL creates blink.mojom.ServiceWorkerClientType enum type and uses
it to replace existing native enum type blink::WebServiceWorkerClientType.

This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo,
and finally to remove content::ExtendableMessageEventSource, which is an
incremental step toward Onion Soup: having less dependence on content types
for service worker.

BUG= 782528 

Change-Id: I1546fec01d25446ae287074f33355c1a80ac161e
Reviewed-on: https://chromium-review.googlesource.com/778480
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518852}
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/OWNERS
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_client_info.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_client_info.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_types_struct_traits.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/common/BUILD.gn
[add] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/common/service_worker/OWNERS
[add] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/common/service_worker/service_worker_client.mojom
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientQueryOptions.h
[delete] https://crrev.com/b4e75fa1c1e431cd6e8bb4278bc67bf20e3c4a7b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientType.h
[modify] https://crrev.com/5e65b0925a1d31c399afd1e018725f1162ad086a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5b3a66158491e1dc9903c6632e8060fe81200a6

commit a5b3a66158491e1dc9903c6632e8060fe81200a6
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Wed Dec 13 05:59:56 2017

Merge all native enums RequestContextFrameType into single mojo enum

This CL creates blink.mojom.RequestContextFrameType enum type and uses
it to replace existing native enums content::RequestContextFrameType and
blink::WebURLRequest::FrameType.

This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo,
and finally to remove content::ExtendableMessageEventSource, which is an
incremental step toward Onion Soup: having less dependence on content types
for service worker.

BUG= 782528 

Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd
Reviewed-on: https://chromium-review.googlesource.com/791916
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523699}
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/content_param_traits_macros.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/service_worker/service_worker_client_info.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/service_worker/service_worker_client_info.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/service_worker/service_worker_fetch_request.typemap
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/public/common/BUILD.gn
[delete] https://crrev.com/82b1e2f614d757cc76db8838d6fc1794f24e2960/content/public/common/request_context_frame_type.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/public/common/resource_request.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/public/renderer/associated_resource_fetcher.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/fetchers/associated_resource_fetcher_impl.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/fetchers/associated_resource_fetcher_impl.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/fetchers/manifest_fetcher.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/loader/web_url_request_util.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/services/network/public/interfaces/BUILD.gn
[add] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/services/network/public/interfaces/request_context_frame_type.mojom
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/BaseFetchContext.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/BaseFetchContextTest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/MixedContentChecker.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/public/platform/modules/fetch/FetchAPIRequest.typemap
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h
[modify] https://crrev.com/a5b3a66158491e1dc9903c6632e8060fe81200a6/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c02cf404aea00f1e495913fc64f5043e00e1047

commit 5c02cf404aea00f1e495913fc64f5043e00e1047
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Dec 13 07:26:06 2017

Revert "Merge all native enums RequestContextFrameType into single mojo enum"

This reverts commit a5b3a66158491e1dc9903c6632e8060fe81200a6.

Reason for revert:
This seems to be causing flaky build errors on chromeos-amd64-generic-rel:
https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/chromeos-amd64-generic-rel/

In file included from ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp:60:
In file included from ../../third_party/WebKit/public/platform/Platform.h:56:
In file included from ../../third_party/WebKit/public/platform/WebURLLoader.h:36:
../../third_party/WebKit/public/platform/WebURLRequest.h:41:10: fatal error: 'services/network/public/interfaces/request_context_frame_type.mojom-shared.h' file not found
#include "services/network/public/interfaces/request_context_frame_type.mojom-shared.h"

Probably need to add some DEPS to BUILD.gn. I will revert for now.

Original change's description:
> Merge all native enums RequestContextFrameType into single mojo enum
> 
> This CL creates blink.mojom.RequestContextFrameType enum type and uses
> it to replace existing native enums content::RequestContextFrameType and
> blink::WebURLRequest::FrameType.
> 
> This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo,
> and finally to remove content::ExtendableMessageEventSource, which is an
> incremental step toward Onion Soup: having less dependence on content types
> for service worker.
> 
> BUG= 782528 
> 
> Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd
> Reviewed-on: https://chromium-review.googlesource.com/791916
> Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523699}

TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org,tsepez@chromium.org,shimazu@chromium.org,xiaofeng.zhang@intel.com

Change-Id: I25d74d983877227b5482a441f6cebb74374751b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  782528 
Reviewed-on: https://chromium-review.googlesource.com/823332
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523710}
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/content_param_traits_macros.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/service_worker/service_worker_client_info.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/service_worker/service_worker_client_info.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/service_worker/service_worker_fetch_request.typemap
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/public/common/BUILD.gn
[add] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/public/common/request_context_frame_type.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/public/common/resource_request.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/public/renderer/associated_resource_fetcher.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/fetchers/associated_resource_fetcher_impl.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/fetchers/associated_resource_fetcher_impl.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/fetchers/manifest_fetcher.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/loader/web_url_request_util.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/services/network/public/interfaces/BUILD.gn
[delete] https://crrev.com/1aea053bc7fc271522e7f36f19e517c869ad6e64/services/network/public/interfaces/request_context_frame_type.mojom
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/BaseFetchContext.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/BaseFetchContextTest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/MixedContentChecker.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/public/platform/modules/fetch/FetchAPIRequest.typemap
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h
[modify] https://crrev.com/5c02cf404aea00f1e495913fc64f5043e00e1047/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h

Comment 5 by dgn@chromium.org, Dec 13 2017

Blockedon: 794495
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15e434d97da06bd2b9709b2aa65aa936aedbd277

commit 15e434d97da06bd2b9709b2aa65aa936aedbd277
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Thu Dec 14 04:09:05 2017

Reland "Merge all native enums RequestContextFrameType into single mojo enum"

Reason for reland: Fix the flaky build errors by adding a needed dependency in
third_party/WebKit/Source/platform/BUILD.gn

Original change's description:
> Merge all native enums RequestContextFrameType into single mojo enum
>
> This CL creates blink.mojom.RequestContextFrameType enum type and uses
> it to replace existing native enums content::RequestContextFrameType and
> blink::WebURLRequest::FrameType.
>
> This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo,
> and finally to remove content::ExtendableMessageEventSource, which is an
> incremental step toward Onion Soup: having less dependence on content types
> for service worker.
>
> BUG= 782528 
>
> Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd
> Reviewed-on: https://chromium-review.googlesource.com/791916
> Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523699}

TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org,tsepez@chromium.org,shimazu@chromium.org

Change-Id: Ie1a0dc3567cdde59655995c3a06c95ddeac027ea
Reviewed-on: https://chromium-review.googlesource.com/823824
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524001}
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/content_param_traits_macros.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/service_worker/service_worker_client_info.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/service_worker/service_worker_client_info.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/service_worker/service_worker_fetch_request.typemap
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/public/common/BUILD.gn
[delete] https://crrev.com/2d97d1fddf424fc2a4d07a82ef500070da5aa255/content/public/common/request_context_frame_type.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/public/common/resource_request.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/public/renderer/associated_resource_fetcher.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/fetchers/associated_resource_fetcher_impl.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/fetchers/associated_resource_fetcher_impl.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/fetchers/manifest_fetcher.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/loader/web_url_request_util.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/services/network/public/interfaces/BUILD.gn
[add] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/services/network/public/interfaces/request_context_frame_type.mojom
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/BaseFetchContext.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/BaseFetchContextTest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/MixedContentChecker.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/public/platform/modules/fetch/FetchAPIRequest.typemap
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h
[modify] https://crrev.com/15e434d97da06bd2b9709b2aa65aa936aedbd277/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b

commit ec8c1d383e2ff80a5bae594607b4f56e514cdd3b
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Tue Jan 09 10:52:45 2018

[ServiceWorker] Apply mojom struct ServiceWorkerClientInfo everywhere

This CL replaces native struct content::ServiceWorkerClientInfo
with mojom struct blink.mojom.ServiceWorkerClientInfo.

This is an incremental step toward Onion Soup: having less dependence
on content types for service worker.

BUG= 782528 

Change-Id: Ie295eb9c963a1381e0fff138ca3105dc5df16498
Reviewed-on: https://chromium-review.googlesource.com/787150
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#527959}
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/common/BUILD.gn
[delete] https://crrev.com/f30acbebb168b689df1b1f00c816a708d1bc308d/content/common/service_worker/service_worker_client_info.cc
[delete] https://crrev.com/f30acbebb168b689df1b1f00c816a708d1bc308d/content/common/service_worker/service_worker_client_info.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/common/service_worker/service_worker_event_dispatcher.typemap
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/common/service_worker/service_worker_fetch_request.typemap
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/third_party/WebKit/common/BUILD.gn
[modify] https://crrev.com/ec8c1d383e2ff80a5bae594607b4f56e514cdd3b/third_party/WebKit/common/service_worker/service_worker_client.mojom
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d522872cf58566ed02cc298ce0091ee32c2dce4

commit 3d522872cf58566ed02cc298ce0091ee32c2dce4
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Wed Jan 10 02:23:44 2018

[ServiceWorker] Implement mojom interface ServiceWorkerHost.GetClients

This CL replaces native struct content::ServiceWorkerClientQueryOptions
with mojom struct blink.mojom.ServiceWorkerClientQueryOptions.

And based on that, the CL mojofies the following legacy IPCs:
ServiceWorkerHostMsg_GetClients
ServiceWorkerMsg_DidGetClients

BUG= 782528 ,  772793 

Change-Id: If72455743b2ddbef8da012831b16a9a9ce38a8ff
Reviewed-on: https://chromium-review.googlesource.com/851844
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#528219}
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/third_party/WebKit/common/service_worker/service_worker.mojom
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/third_party/WebKit/common/service_worker/service_worker_client.mojom

Comment 9 by xiaofeng...@intel.com, Jan 10 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment