New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 770439
issue 804605

Blocking:
issue 725692



Sign in to add a comment

Run Tast-based tests against DUTs in the lab

Project Member Reported by derat@chromium.org, Nov 8 2017

Issue description

I'd like to get Tast-based tests running against real hardware in the lab in an experimental capacity.

Prathmesh wrote a great doc at http://doc/1TUf5PoSFXIG52LKxkWoOuMzai3TfWVq-GSVODX_p1xM/edit#heading=h.jbfc3agpwik6 with some suggestions for getting this going: add an Autotest server test that runs the tast command locally.

I've written a trivial server test that does this when run locally using test_that. I'm not sure yet how to report the test results, though. I filed  issue 770439  against myself earlier to make tast write a status.log file in Autotest's TKO format, and that seems easy enough to do, but I don't know how to get Autotest to parse that instead of (or in addition to) the TKO file that it writes itself.

Log parsing looks like it's initiated by server/server_job.py:

    def init_parser(self):
        """
        Start the continuous parsing of self.resultdir. This sets up
        the database connection and inserts the basic job object into
        the database if necessary.
        """
        if not self._using_parser:
            return
        # redirect parser debugging to .parse.log
        parse_log = os.path.join(self.resultdir, '.parse.log')
        parse_log = open(parse_log, 'w', 0)
        tko_utils.redirect_parser_debugging(parse_log)
        # create a job model object and set up the db
        self.results_db = tko_db.db(autocommit=True)
        self.parser = parser_lib.parser(self._STATUS_VERSION)
        self.job_model = self.parser.make_job(self.resultdir)
        self.parser.start(self.job_model)
        # check if a job already exists in the db and insert it if
        # it does not
        job_idx = self.results_db.find_job(self._parse_job)

If there's a way to convince it to look somewhere else, it's not obvious to me yet.
 

Comment 1 by derat@chromium.org, Nov 14 2017

I uploaded the non-lab-integrated server test at https://crrev.com/c/769291.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/9d1624ff65aca7961d2e69dc002ff99b261da861

commit 9d1624ff65aca7961d2e69dc002ff99b261da861
Author: Daniel Erat <derat@chromium.org>
Date: Wed Jan 10 10:49:03 2018

tast: Add -logtime flag.

Add a -logtime bool flag to the tast command, true by
default, that controls whether log messages will be prefixed
by the date and time. This can be set to false if tast is
being run by another system that already prepends
timestamps, i.e. Autotest.

BUG= chromium:782515 
TEST=manual: ran with -logtime=false

Change-Id: Ifcc27b08bfb629b650444108ecc8d7dd15f2c513
Reviewed-on: https://chromium-review.googlesource.com/858305
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/9d1624ff65aca7961d2e69dc002ff99b261da861/src/chromiumos/cmd/tast/main.go

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3300f6ebc44d5621275dd9e8cec69e5098d83a43

commit 3300f6ebc44d5621275dd9e8cec69e5098d83a43
Author: Daniel Erat <derat@chromium.org>
Date: Wed Jan 10 23:44:37 2018

autotest: Update utils.run() for stdout/stderr log levels.

Update the utils.run() function to take stdout_level and
stderr_level arguments that can be used to specify logging
levels to use when stdout_tee or stderr_err are TEE_TO_LOGS.

BUG= chromium:782515 
TEST=added unit tests; also used it to set stdout logging
     level for a server test

Change-Id: Ib2a8de68d6a96bbd3fb89a938dab075ca5e3f4bf
Reviewed-on: https://chromium-review.googlesource.com/857844
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/3300f6ebc44d5621275dd9e8cec69e5098d83a43/client/common_lib/utils.py
[modify] https://crrev.com/3300f6ebc44d5621275dd9e8cec69e5098d83a43/client/common_lib/utils_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a538d94f08a1c56de0e3bc2320ee994238e2ba8b

commit a538d94f08a1c56de0e3bc2320ee994238e2ba8b
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jan 11 08:20:50 2018

autotest: Add test_Runner.bvt server test.

Add a new tast_Runner.bvt server test that runs the tast
command locally to run Tast-based tests on a remote DUT and
report the results.

BUG= chromium:782515 
TEST=ran it locally using test_that

Change-Id: Ie37af42046f37af68f715ccad5bd8b3eb8361508
Reviewed-on: https://chromium-review.googlesource.com/769291
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/a538d94f08a1c56de0e3bc2320ee994238e2ba8b/server/site_tests/tast_Runner/tast_Runner.py
[add] https://crrev.com/a538d94f08a1c56de0e3bc2320ee994238e2ba8b/server/site_tests/tast_Runner/control.bvt

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/afb5240fbf26cbf310b37885cd90aa8f00d83711

commit afb5240fbf26cbf310b37885cd90aa8f00d83711
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jan 18 22:44:45 2018

chromite: Build tast-cmd in EmergeInfraGoBinariesStage.

Build the tast-cmd package as part of
EmergeInfraGoBinariesStage so its binaries will be available
to prod machines via CIPD.

BUG= chromium:782515 
TEST=did a chromeos-infra-go-tryjob build

Change-Id: I048960a52c4dfedfccc508efb559b73ed8d23ef1
Reviewed-on: https://chromium-review.googlesource.com/865724
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/afb5240fbf26cbf310b37885cd90aa8f00d83711/cbuildbot/stages/infra_stages.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d02ac91ae0b37c5b4f2aee2d430505980073a6e

commit 7d02ac91ae0b37c5b4f2aee2d430505980073a6e
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jan 19 17:14:16 2018

Add tast-bundle.eclass.

Add an eclass to simplify building Tast test bundles, and
update the tast-local-tests-cros and tast-remote-tests-cros
packages to use it.

This also results in tast-remote-tests-cros's data files
being packaged. Well, it would if it had any data files.
Remote tests originally just used data files directly from
the chroot, but that won't work when running on shards in
the lab.

BUG= chromium:784944 , chromium:782515 
TEST=emerged tast-local-tests-cros and
     tast-remote-tests-cros with FEATURES=test

Change-Id: I4bf25e435abbc0c2584c9f8cb3f29975891bedca
Reviewed-on: https://chromium-review.googlesource.com/872457
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/7d02ac91ae0b37c5b4f2aee2d430505980073a6e/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[modify] https://crrev.com/7d02ac91ae0b37c5b4f2aee2d430505980073a6e/chromeos-base/tast-remote-tests-cros/tast-remote-tests-cros-9999.ebuild
[add] https://crrev.com/7d02ac91ae0b37c5b4f2aee2d430505980073a6e/eclass/tast-bundle.eclass

Comment 7 by derat@chromium.org, Jan 23 2018

Blockedon: 804605

Comment 8 by derat@chromium.org, Jan 23 2018

Components: Tests>Tast
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ddc4036d1d84c1d97ff61fa53e8f07769cfdc27b

commit ddc4036d1d84c1d97ff61fa53e8f07769cfdc27b
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jan 25 04:24:38 2018

chromite: Make PackageInfraGoBinariesStage install all files.

Update cbuildbot's infra_stages.PackageInfraGoBinariesStage
to package all files installed by the specified Portage
packages instead of using hardcoded lists of executables
under /usr/bin.

Also add unit tests for the stage.

BUG= chromium:782515 
TEST=added unit tests; also did a successful
     chromeos-infra-go-tryjob build

Change-Id: I8208c18f5be5029e625b67ffce5141bc4626d5cc
Reviewed-on: https://chromium-review.googlesource.com/881267
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[add] https://crrev.com/ddc4036d1d84c1d97ff61fa53e8f07769cfdc27b/cbuildbot/stages/infra_stages_unittest
[add] https://crrev.com/ddc4036d1d84c1d97ff61fa53e8f07769cfdc27b/cbuildbot/stages/infra_stages_unittest.py
[modify] https://crrev.com/ddc4036d1d84c1d97ff61fa53e8f07769cfdc27b/cbuildbot/stages/infra_stages.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5b16d08cfaf8b1fc689a9c68258c258f4ad0fff8

commit 5b16d08cfaf8b1fc689a9c68258c258f4ad0fff8
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jan 26 03:24:01 2018

chromite: Build tast-remote-tests-cros CIPD package.

Add tast-remote-tests-cros to the list of CIPD packages
built by the *InfraGoBinariesStage cbuildbot stages.

BUG= chromium:782515 
TEST=ran a tryjob

Change-Id: Ia894ed88d1f5a0ba37690c0859c8cb7abdb2ed23
Reviewed-on: https://chromium-review.googlesource.com/885981
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/5b16d08cfaf8b1fc689a9c68258c258f4ad0fff8/cbuildbot/stages/infra_stages.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/ec86bac4623e8aaac1c6de284b76a8c23b346a94

commit ec86bac4623e8aaac1c6de284b76a8c23b346a94
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jan 26 03:23:46 2018

tast: Make remote tests use data from /usr/share/tast/data.

Update the tast command to instruct remote_test_runner to
use test data located under /usr/share/tast/data (when not
building tests) and data from the source tree (when
building).

I think that test data was completely unimplemented for
remote tests. There aren't any remote tests that use it yet.

Add several related flags to the run subcommand:

  -remoterunner
  -remotebundledir
  -remotedatadir

These will likely be needed when running on lab shards,
where the files from the tast-cmd and tast-remote-tests-cros
CIPD packages will be installed to non-standard locations.

Also add some unit tests for run.Remote (which didn't have
any) and improve logging when remote_test_runner fails
(run.Local previously got the same treatment).

BUG= chromium:784944 , chromium:782515 
TEST=new unit tests pass; also hacked a remote test to use a
     data file and checked that it passes with -build=true
     and -build=false

Change-Id: I1822d4752882ca87808e077a7556224a3646fdb7
Reviewed-on: https://chromium-review.googlesource.com/885441
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/ec86bac4623e8aaac1c6de284b76a8c23b346a94/src/chromiumos/cmd/tast/run/config.go
[modify] https://crrev.com/ec86bac4623e8aaac1c6de284b76a8c23b346a94/src/chromiumos/cmd/tast/run/remote.go
[modify] https://crrev.com/ec86bac4623e8aaac1c6de284b76a8c23b346a94/src/chromiumos/cmd/remote_test_runner/main.go
[add] https://crrev.com/ec86bac4623e8aaac1c6de284b76a8c23b346a94/src/chromiumos/cmd/tast/run/remote_test.go

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 29 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7b30fbb783d85366048032f09004cd554ce9d668

commit 7b30fbb783d85366048032f09004cd554ce9d668
Author: Daniel Erat <derat@chromium.org>
Date: Mon Jan 29 19:40:07 2018

luci-scheduler: Add tast chromeos-infra-go triggers.

Add triggers for chromeos-infra-go that watch the tast and
tast-tests repositories. This is intended to cause the
tast-cmd and tast-remote-tests-cros CIPD packages to be
rebuilt when their code is updated.

BUG= chromium:782515 
TEST=none

Change-Id: I699fb59f71e8b1dd7164d778730e03ad15c30e2a
Reviewed-on: https://chromium-review.googlesource.com/887721
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/7b30fbb783d85366048032f09004cd554ce9d668/luci-scheduler.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/551644f6e3cc392817f8469d47fab850ae11cb45

commit 551644f6e3cc392817f8469d47fab850ae11cb45
Author: Daniel Erat <derat@chromium.org>
Date: Tue Jan 30 01:42:09 2018

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/590a4998a9ee41906aeb3089bb88116dcbdb7bc8

commit 590a4998a9ee41906aeb3089bb88116dcbdb7bc8
Author: Daniel Erat <derat@chromium.org>
Date: Tue Jan 30 03:10:54 2018

autotest: Uprev tast CIPD packages in automated_deploy.py.

Make site_utils/automated_deploy.py update the "prod" refs
for the chromiumos/infra/tast-cmd and
chromiumos/infra/tast-remote-tests-cros CIPD packages.

BUG= chromium:782515 
TEST=none

Change-Id: I091c0822cd16a891450a27c7ef3ece788cdc00d5
Reviewed-on: https://chromium-review.googlesource.com/891603
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/590a4998a9ee41906aeb3089bb88116dcbdb7bc8/site_utils/automated_deploy.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/180dad68116ea3085a8f6e33eab29d44b52009f1

commit 180dad68116ea3085a8f6e33eab29d44b52009f1
Author: Daniel Erat <derat@chromium.org>
Date: Tue Jan 30 17:49:50 2018

Comment 16 by derat@chromium.org, Jan 30 2018

Blocking: 725692
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/00473f988a703e0018fd3254988da7796751ba72

commit 00473f988a703e0018fd3254988da7796751ba72
Author: Daniel Erat <derat@chromium.org>
Date: Thu Feb 01 10:42:02 2018

chromiumos-overlay: Add autotest-server-tests-tast package.

Add a package that installs the tast_Runner Autotest-based
test. Also sort the dependency list in autotest-all.

BUG= chromium:782515 
TEST=none

Change-Id: I912dcd3765847194f9192bf3a5d05febf53284d5
Reviewed-on: https://chromium-review.googlesource.com/896262
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[rename] https://crrev.com/00473f988a703e0018fd3254988da7796751ba72/chromeos-base/autotest-all/autotest-all-0.0.1-r42.ebuild
[modify] https://crrev.com/00473f988a703e0018fd3254988da7796751ba72/chromeos-base/autotest-all/autotest-all-0.0.1.ebuild
[add] https://crrev.com/00473f988a703e0018fd3254988da7796751ba72/chromeos-base/autotest-server-tests-tast/autotest-server-tests-tast-9999.ebuild

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b4881c53d92f9173eb0d471ea005baebfddd129d

commit b4881c53d92f9173eb0d471ea005baebfddd129d
Author: Daniel Erat <derat@chromium.org>
Date: Fri Feb 02 18:17:31 2018

autotest: Make tast_Runner support using /opt/infra-tools.

When Tast is installed from the tast-cmd and
tast-remote-tests-cros CIPD packages, its binaries end up
under /opt/infra-tools. Make the tast_Runner test try to use
files from that directory when the tast executable isn't
present at /usr/bin/tast.

BUG= chromium:782515 
TEST=ran it locally using test_that
CQ-DEPEND=I912dcd3765847194f9192bf3a5d05febf53284d5

Change-Id: I16b6b82943024120b5ea8da5c6a681a6a3bbdb09
Reviewed-on: https://chromium-review.googlesource.com/894730
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b4881c53d92f9173eb0d471ea005baebfddd129d/server/site_tests/tast_Runner/tast_Runner.py
[modify] https://crrev.com/b4881c53d92f9173eb0d471ea005baebfddd129d/server/site_tests/tast_Runner/control.bvt

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/7f82ecb78e81beb0435f1e579baf4b3b7a6715e4

commit 7f82ecb78e81beb0435f1e579baf4b3b7a6715e4
Author: Daniel Erat <derat@chromium.org>
Date: Sat Feb 03 02:16:29 2018

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/13acd8c35787a588715fe182d2243df8b4eed3c6

commit 13acd8c35787a588715fe182d2243df8b4eed3c6
Author: Daniel Erat <derat@chromium.org>
Date: Mon Feb 05 03:21:35 2018

tast: Add -keydir flag defaulting to $HOME/.ssh.

Add a -keydir flag to the tast command that can be used to
specify a directory containing standard private keys
(id_dsa, id_ecdsa, id_ed25519, id_rsa) to use to connect to
DUTs. Shards appear to use these keys when running Autotest
server tests against DUTs in the lab.

Also update remote_test_runner and remote test bundles to
name their flags "-keyfile" (just like the tast executable
does) instead of using "-keypath", and use the same
terminology throughout the code.

BUG= chromium:782515 
TEST=added a unit test. unit tests still pass, and manually
     verified by running local and remote tests as well

Change-Id: Ie28187f97dbe975baf0626556e6b4e831e740825
Reviewed-on: https://chromium-review.googlesource.com/900128
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Trybot-Ready: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/tast/host/test/default.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/tast/run/remote.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/tast/host/ssh_test.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/tast/dut/dut.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/tast/run_cmd.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/tast/run/local.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/tast/bundle/remote.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/tast/run/local_test.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/tast/bundle/remote_test.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/tast/run/remote_test.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/tast/run/config.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/cmd/remote_test_runner/main.go
[modify] https://crrev.com/13acd8c35787a588715fe182d2243df8b4eed3c6/src/chromiumos/tast/host/ssh.go

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ee29b2a75777917495d6a05669256c194891b544

commit ee29b2a75777917495d6a05669256c194891b544
Author: Daniel Erat <derat@chromium.org>
Date: Tue Feb 06 12:55:29 2018

chromiumos-overlay: Use type subdir in tast-bundle.eclass.

Make tast-bundle.eclass install test bundles to
/usr/libexec/tast/bundles/{local,remote} and test data to
/usr/share/tast/data/{local,remote}.

Without trailing "local" and "remote" subdirectories, we'll
encounter file collisions when installing both
tast-local-tests-cros and tast-remote-tests-cros in the same
buildroot (which we apparently do for moblab).

BUG= chromium:809185 , chromium:782515 
TEST=checked that tast-local-tests-cros and
     tast-remote-tests-cros can be installed simultaneously
     without conflicting and that they put files into the
     expected locations
CQ-DEPEND=Icfeab74776792c2ebd49733815c023c3ada4f459

Change-Id: I7163393d5141fc30f9d407d730ab3fb2b0f68229
Reviewed-on: https://chromium-review.googlesource.com/902961
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/ee29b2a75777917495d6a05669256c194891b544/eclass/tast-bundle.eclass

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/138d77d0758ebc3399548096ecb7707c26705898

commit 138d77d0758ebc3399548096ecb7707c26705898
Author: Daniel Erat <derat@chromium.org>
Date: Tue Feb 06 12:55:27 2018

tast: Use local/remote subdirs for test bundles and data.

Make the tast command, local_test_runner,
remote_test_runner, and local bundles append "local" or
"remote" subdirectories to the paths used for locating test
bundles and test data.

Bundles and test data used to go in
/usr/libexec/tast/bundles and /usr/share/tast/data,
respectively, but that can result in file collisions when
installing local and remote bundles on the same system.

To support existing test images, this change
retains support for bundles and test data installed to the
old locations (at the expense of a "test -d" command over
SSH at the beginning of each test run).

BUG= chromium:782515 , chromium:809185 
TEST=updated unit tests; also manually verified that "tast
     run" works with builtin local tests installed to either
     /usr/local/libexec/tast/bundles/local (new) or
     /usr/local/libexec/tast/bundles (old)
CQ-DEPEND=I7163393d5141fc30f9d407d730ab3fb2b0f68229

Change-Id: Icfeab74776792c2ebd49733815c023c3ada4f459
Reviewed-on: https://chromium-review.googlesource.com/903046
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/138d77d0758ebc3399548096ecb7707c26705898/src/chromiumos/tast/bundle/local.go
[modify] https://crrev.com/138d77d0758ebc3399548096ecb7707c26705898/src/chromiumos/cmd/tast/run/local.go
[modify] https://crrev.com/138d77d0758ebc3399548096ecb7707c26705898/src/chromiumos/cmd/tast/run/local_test.go
[modify] https://crrev.com/138d77d0758ebc3399548096ecb7707c26705898/src/chromiumos/cmd/tast/run/config.go
[modify] https://crrev.com/138d77d0758ebc3399548096ecb7707c26705898/src/chromiumos/cmd/local_test_runner/main.go
[modify] https://crrev.com/138d77d0758ebc3399548096ecb7707c26705898/src/chromiumos/cmd/remote_test_runner/main.go

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/5eef6ac0b1c2d790f125e95be18b45c5209846ae

commit 5eef6ac0b1c2d790f125e95be18b45c5209846ae
Author: Daniel Erat <derat@chromium.org>
Date: Tue Feb 06 18:46:12 2018

tast: Avoid setting -keyfile default to nonexistent path.

Check that $HOME/chromite/ssh_keys/testing_rsa exists before
using it as a default for the "tast run" subcommand's
-keyfile flag. Otherwise, host.NewSSH reports an error when
running on prod machines that don't have chromite checkouts.

BUG= chromium:782515 
TEST=verified that default is set appropriately in my chroot

Change-Id: I69d94342e2b8dafd976047756aab069fc07f42f1
Reviewed-on: https://chromium-review.googlesource.com/904428
Tested-by: Dan Erat <derat@chromium.org>
Trybot-Ready: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/5eef6ac0b1c2d790f125e95be18b45c5209846ae/src/chromiumos/cmd/tast/run/config.go

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/22ca57344c9786cab9a9b156983bb4d231a056aa

commit 22ca57344c9786cab9a9b156983bb4d231a056aa
Author: Daniel Erat <derat@chromium.org>
Date: Tue Feb 13 01:14:21 2018

tast: Also look for testing_rsa in SSH dir.

Update the SSH code to look for a testing_rsa key in the
.ssh directory supplied via -keydir. This is what Autotest
uses in the lab.

BUG= chromium:782515 
TEST=unit tests still pass

Change-Id: I42c19086fe871d03784c7e0f2b78f5dbbe723383
Reviewed-on: https://chromium-review.googlesource.com/915140
Commit-Queue: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Trybot-Ready: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/22ca57344c9786cab9a9b156983bb4d231a056aa/src/chromiumos/tast/host/ssh_test.go
[modify] https://crrev.com/22ca57344c9786cab9a9b156983bb4d231a056aa/src/chromiumos/tast/host/ssh.go

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/c9828b9da2b86bd812862ee6f67cfb1a12b39b5a

commit c9828b9da2b86bd812862ee6f67cfb1a12b39b5a
Author: Daniel Erat <derat@chromium.org>
Date: Tue Feb 13 02:07:08 2018

tast-tests: Another docs change to trigger a rebuild.

Fix some broken links so the tast-{local,remote}-tests-cros
ebuilds will be bumped.

BUG= chromium:782515 
TEST=none
TBR=ejcaruso@chromium.org

Change-Id: I3279c41a8c36373376bd62af3c7dbaaa1e037200
Reviewed-on: https://chromium-review.googlesource.com/914970
Reviewed-by: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/c9828b9da2b86bd812862ee6f67cfb1a12b39b5a/README.md

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/79171ba5e752e3ba40e341b5d29c6d91cb27cef6

commit 79171ba5e752e3ba40e341b5d29c6d91cb27cef6
Author: Daniel Erat <derat@chromium.org>
Date: Wed Feb 14 12:07:19 2018

autotest: Update tast_Runner remote test paths.

Update the tast_Runner test's paths for remote test bundles
and data to include the "remote" subdirectory that was added
by https://crrev.com/c/902961 to support installing local
and remote test bundles on the same system.

BUG= chromium:782515 , chromium:809185 
TEST=ran remote tests successfully when started by test_that

Change-Id: I115325bdc53a40320778104b83491fe5f277b281
Reviewed-on: https://chromium-review.googlesource.com/918022
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/79171ba5e752e3ba40e341b5d29c6d91cb27cef6/server/site_tests/tast_Runner/tast_Runner.py

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5c7777f434a545ad8e5b8c98a590cfdcb1241453

commit 5c7777f434a545ad8e5b8c98a590cfdcb1241453
Author: Daniel Erat <derat@chromium.org>
Date: Fri Feb 16 19:09:27 2018

autotest: Update tast_Runner to log tast command version.

Make the tast_Runner server test run "tast -version" to log
the currently-installed version of the executable.

BUG= chromium:782515 
TEST=manual: ran test and checked that version is logged

Change-Id: I041c897d70af10b39799bf1e3693ce754173b4a1
Reviewed-on: https://chromium-review.googlesource.com/923388
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/5c7777f434a545ad8e5b8c98a590cfdcb1241453/server/site_tests/tast_Runner/tast_Runner.py

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fb80f9ceac6353583113337cbaef158db7f1e63e

commit fb80f9ceac6353583113337cbaef158db7f1e63e
Author: Daniel Erat <derat@chromium.org>
Date: Sat Feb 17 08:28:40 2018

autotest-server: Add Tast dependencies.

Make the autotest-server package RDEPEND on the tast-cmd and
tast-remote-tests-cros packages, which are used by the
tast_Runner server test. This is needed in order for these
packages to be included in the moblab image.

BUG= chromium:782515 
TEST=none

Change-Id: Ib99ea6e5b04725941a1c12c0b8dc99d5c0245df6
Reviewed-on: https://chromium-review.googlesource.com/900425
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/fb80f9ceac6353583113337cbaef158db7f1e63e/chromeos-base/autotest-server/autotest-server-9999.ebuild

Project Member

Comment 29 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/77502e99ddd114205a7ec81ed12b68c90148ae40

commit 77502e99ddd114205a7ec81ed12b68c90148ae40
Author: Daniel Erat <derat@chromium.org>
Date: Sat Feb 17 18:05:13 2018

autotest: Add tast_Runner tests to bvt-perbuild suite.

Add the tast_Runner.bvt server test to the bvt-perbuild
suite so that it will run on release builders.

Also add a new tast_Runner.bvt_arc control file that runs
only ARC-specific tests.

BUG= chromium:782515 
TEST=ran tryjobs

Change-Id: I0147b717751b3d841bb722d42d54c14d64888f3f
Reviewed-on: https://chromium-review.googlesource.com/900687
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/77502e99ddd114205a7ec81ed12b68c90148ae40/server/site_tests/tast_Runner/control.bvt_arc
[modify] https://crrev.com/77502e99ddd114205a7ec81ed12b68c90148ae40/server/site_tests/tast_Runner/control.bvt

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/61323f34d0fab3baa26d63ec19625b6d93da185a

commit 61323f34d0fab3baa26d63ec19625b6d93da185a
Author: Daniel Erat <derat@chromium.org>
Date: Sun Feb 18 10:15:18 2018

autotest: Make lxc_config_unittest.py ignore mounts.

Make lxc_config_unittest.py skip over mounts in the default
ssp_deploy_config.json file instead of failing to parse them
as config file objects. (There aren't any default mounts
defined currently.)

BUG= chromium:782515 
TEST=none

Change-Id: I25f294c6829d3d5d2e5ce5e97eb45d1cd5a7d168
Reviewed-on: https://chromium-review.googlesource.com/898482
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/61323f34d0fab3baa26d63ec19625b6d93da185a/site_utils/lxc/lxc_config_unittest.py

Project Member

Comment 31 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/61323f34d0fab3baa26d63ec19625b6d93da185a

commit 61323f34d0fab3baa26d63ec19625b6d93da185a
Author: Daniel Erat <derat@chromium.org>
Date: Sun Feb 18 10:15:18 2018

autotest: Make lxc_config_unittest.py ignore mounts.

Make lxc_config_unittest.py skip over mounts in the default
ssp_deploy_config.json file instead of failing to parse them
as config file objects. (There aren't any default mounts
defined currently.)

BUG= chromium:782515 
TEST=none

Change-Id: I25f294c6829d3d5d2e5ce5e97eb45d1cd5a7d168
Reviewed-on: https://chromium-review.googlesource.com/898482
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/61323f34d0fab3baa26d63ec19625b6d93da185a/site_utils/lxc/lxc_config_unittest.py

Project Member

Comment 32 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/785753280d757bab19124e3407b4a997096ce6ee

commit 785753280d757bab19124e3407b4a997096ce6ee
Author: Daniel Erat <derat@chromium.org>
Date: Tue Feb 27 18:48:06 2018

Status: Fixed (was: Started)
A subset of Tast tests are running now as part of the tast_Runner Autotest server test, which runs in the bvt-inline suite on -release (a.k.a. canary) builders. I'll close this now and open additional bugs for followup work as needed.
Project Member

Comment 34 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/88df8cfaf5af34e4620ff4adc8e9d3aa60a2f725

commit 88df8cfaf5af34e4620ff4adc8e9d3aa60a2f725
Author: Daniel Erat <derat@chromium.org>
Date: Mon Jun 04 22:19:46 2018

Project Member

Comment 35 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/910c207676f396d9a8ba2600cac49b0cf0a45e6c

commit 910c207676f396d9a8ba2600cac49b0cf0a45e6c
Author: Daniel Erat <derat@chromium.org>
Date: Wed Jun 06 02:37:13 2018

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/81db3d6b58449255fabc1697c12cd168a589210b

commit 81db3d6b58449255fabc1697c12cd168a589210b
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jun 08 02:56:14 2018

cbuildbot: Stop building Tast infra packages.

Make the EmergeInfraGoBinariesStage,
PackageInfraGoBinariesStage, and
RegisterInfraGoPackagesStage cbuildbot stages stop building
the tast-cmd and tast-remote-tests-cros CIPD packages. These
are no longer needed now that Tast-related binaries are
distributed using SSP.

BUG= chromium:845289 , chromium:782515 
TEST=none
CQ-DEPEND=CL:1086030
CQ-DEPEND=CL:*635275

Change-Id: I773f7e250e2c1e09afc363b94e02fdf987f82195
Reviewed-on: https://chromium-review.googlesource.com/1086160
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/81db3d6b58449255fabc1697c12cd168a589210b/cbuildbot/stages/infra_stages.py

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1de178223cdc465037bfe5e480d1499ee3be610

commit d1de178223cdc465037bfe5e480d1499ee3be610
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 08 04:50:46 2018

Roll src/third_party/chromite 531d6f8..81db3d6 (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/531d6f8..81db3d6


git log 531d6f8..81db3d6 --date=short --no-merges --format='%ad %ae %s'
2018-06-08 derat@chromium.org cbuildbot: Stop building Tast infra packages.


Created with:
  gclient setdep -r src/third_party/chromite@81db3d6

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:845289 , chromium:782515 
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie76c8995b11c83dfb3a61c796437a7a8207d4c13
Reviewed-on: https://chromium-review.googlesource.com/1092046
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565533}
[modify] https://crrev.com/d1de178223cdc465037bfe5e480d1499ee3be610/DEPS

Sign in to add a comment