[MD Extensions] Re-enable initial-count in dom-repeat for apps and extensions. |
|||
Issue descriptioninitial-count had initially landed at [1] and later reverted at [2]. With help from the Polymer team, the problem has been identified. Specifically, when any change is happening to an extension (like enabling/disabling), the array backing up the dom-repeat gets reset at [3] to a new array because of the call to filter(), causing the re-rendering to happen. [1] https://chromium-review.googlesource.com/748061 [2] https://chromium-review.googlesource.com/751882 [3] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/item_list.js?l=51
,
Nov 9 2017
Candidate CL is at https://chromium-review.googlesource.com/c/chromium/src/+/759739.
,
Nov 9 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/deb837bfa4f2173b32bad8162a503d19f8c04eb1 commit deb837bfa4f2173b32bad8162a503d19f8c04eb1 Author: dpapad <dpapad@chromium.org> Date: Fri Nov 10 18:58:26 2017 MD Extensions: Never reset the array of apps/extensions dom-repeat. Using dom-repeat's filter functionality to implement filtering, as opposed to manually resetting the array. As a result: - The list of apps/extensions is not unnecessarily re-rendered when any item is updated (for example enabled/disabled). Only the modified item is updated. - Allows using dom-repeat's chunked rendering (initial-count) without triggering accidental re-renders. This change improves FMP by about 12% on my machine (with 30 extensions+apps). Bug: 782514 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica14de4d71442b9980dcf3290eb8e9caaf5772af Reviewed-on: https://chromium-review.googlesource.com/759739 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#515619} [modify] https://crrev.com/deb837bfa4f2173b32bad8162a503d19f8c04eb1/chrome/browser/resources/md_extensions/item_list.html [modify] https://crrev.com/deb837bfa4f2173b32bad8162a503d19f8c04eb1/chrome/browser/resources/md_extensions/item_list.js [modify] https://crrev.com/deb837bfa4f2173b32bad8162a503d19f8c04eb1/chrome/test/data/webui/extensions/extension_item_list_test.js
,
Nov 10 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Nov 8 2017