New issue
Advanced search Search tips

Issue 782512 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 607844



Sign in to add a comment

Fix mirroring enter and exit notification for multi-mirroring

Project Member Reported by weidongg@chromium.org, Nov 8 2017

Issue description

With --enable-multi-mirroring flag is enabled:
1. Turn mirror mode on in 3+ display environment, notification should include all destination displays' names, but currently only one is shown.
2. Turn mirror mode off in 3+ display environment, notification should show "Exiting mirror mode" instead of "Mirroring with more than two displays is not supported."
 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d790a659221690cf306174693c7e02ed212d362b

commit d790a659221690cf306174693c7e02ed212d362b
Author: Weidong Guo <weidongg@chromium.org>
Date: Tue Nov 14 19:52:29 2017

Fix mirroring enter and exit notification for multi-mirroring

Changes:
1. Turn mirror mode off in 3+ display environment, notification shows
   "Exiting mirror mode" instead of "Mirroring with more than two displays
   is not supported.".
2. Turn mirror mode on in 3+ display environment, notification now
   includes all destination displays' names.

BUG= 782512 
TEST=ScreenLayoutObserverMultiMirroringTest.ExitMirrorModeBecauseAddOrRemoveDisplayMessage

Change-Id: I60e5aa08cd89a66292d23010c68106bc99925354
Reviewed-on: https://chromium-review.googlesource.com/759321
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516397}
[modify] https://crrev.com/d790a659221690cf306174693c7e02ed212d362b/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/d790a659221690cf306174693c7e02ed212d362b/ash/system/screen_layout_observer_unittest.cc

Sign in to add a comment