Issue metadata
Sign in to add a comment
|
ML Service V1: Make ML Service ready for client integrations. |
||||||||||||||||||||||||||||||||||||||
Issue descriptionTechnical feature description: Adds a Learning Component which provides a machine learning inference API for use by browser features and uses the TensorFlow client runtime for evaluating models. Initially this will be used for ChromeOS use-cases (power and tab management) and other developer prototypes on Linux. The other platforms will follow as future efforts. Eng owner: kennetht@ PM owner: omrilio@ Design doc (send to chrome-design-docs@): go/chrome-learning-component Metrics: TBD (see design doc)
,
Nov 8 2017
,
Jan 12 2018
Updated design doc with a focus only on Chrome OS for v1 is at go/chromeos-ml-service
,
Feb 8 2018
Since this is now Chrome OS-only, I'll defer to a Chrome OS security person. mnissler, do you want to take it?
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/52aea55677298571a73fe570c463abcdf0982e35 commit 52aea55677298571a73fe570c463abcdf0982e35 Author: Ken Turner <kennetht@chromium.org> Date: Wed Feb 14 05:16:23 2018 ml: Initial setup of platform2/ml/ directory. The Chrome OS Machine Learning (ML) Service wraps the TensorFlow runtime and provides a Mojo interface to clients for loading and evaluating ML models. This change sets up the directory for the service implementation. BUG= chromium:782499 TEST=None Change-Id: Ib57cdf2b19b0c9ebd433041582ede5a8acf062a5 Reviewed-on: https://chromium-review.googlesource.com/910470 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [add] https://crrev.com/52aea55677298571a73fe570c463abcdf0982e35/ml/README.md [modify] https://crrev.com/52aea55677298571a73fe570c463abcdf0982e35/README.md [add] https://crrev.com/52aea55677298571a73fe570c463abcdf0982e35/ml/OWNERS
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/edb93932d05a64635e8c315d605b3dbeedde7e73 commit edb93932d05a64635e8c315d605b3dbeedde7e73 Author: Ken Turner <kennetht@chromium.org> Date: Thu Feb 15 08:10:52 2018 ml: Initial GYP with stub main() and daemon. Creates the main() for the ML service with a stub daemon class which will be used to bootstrap the Mojo connections. BUG= chromium:782499 TEST=emerge-$BOARD ml (in follow-up CL) Change-Id: Icab4f9dc3f159af2523a49c7445241d33fdf627c Reviewed-on: https://chromium-review.googlesource.com/917929 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [add] https://crrev.com/edb93932d05a64635e8c315d605b3dbeedde7e73/ml/ml.gyp [add] https://crrev.com/edb93932d05a64635e8c315d605b3dbeedde7e73/ml/daemon.h [add] https://crrev.com/edb93932d05a64635e8c315d605b3dbeedde7e73/ml/main.cc [add] https://crrev.com/edb93932d05a64635e8c315d605b3dbeedde7e73/ml/daemon.cc
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ce1a4d363e9ffa8889a26f9923590f6fd83fa71f commit ce1a4d363e9ffa8889a26f9923590f6fd83fa71f Author: Ken Turner <kennetht@chromium.org> Date: Thu Feb 15 21:50:54 2018 chromeos-base/ml: add ebuild for the Machine Learning service. BUG= chromium:782499 TEST=cros_workon_make --board=${BOARD} chromeos-base/ml --install CQ-DEPEND=CL:917929 Change-Id: I2c7765c4a07ab6421471d0d64830e11af5f21be7 Reviewed-on: https://chromium-review.googlesource.com/919441 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/ce1a4d363e9ffa8889a26f9923590f6fd83fa71f/chromeos-base/ml/ml-9999.ebuild
,
Feb 16 2018
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/2296fb3b1ade71b48de4eff417e9047bbf91f653 commit 2296fb3b1ade71b48de4eff417e9047bbf91f653 Author: Ken Turner <kennetht@chromium.org> Date: Tue Feb 27 06:07:25 2018 eclass-overlay: Add ml-service user and group. Set up user and group for running the Machine Learning service in minijail. BUG= chromium:782499 TEST=profiles/base/accounts/display-accts.py Change-Id: I9d0ba4a34037338bf39a7f497565312f7c1d88c2 Reviewed-on: https://chromium-review.googlesource.com/930606 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [add] https://crrev.com/2296fb3b1ade71b48de4eff417e9047bbf91f653/profiles/base/accounts/group/ml-service [add] https://crrev.com/2296fb3b1ade71b48de4eff417e9047bbf91f653/profiles/base/accounts/user/ml-service
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a2158762c79502544f51c7107b57a54fbc1982ac commit a2158762c79502544f51c7107b57a54fbc1982ac Author: Ken Turner <kennetht@chromium.org> Date: Thu Mar 01 07:54:27 2018 ml: Initial upstart config for the ml_service. Upstart config for the ml_service which initially locks down all Namespaces and capabilities. BUG= chromium:782499 TEST=None CQ-DEPEND=CL:930606 Change-Id: I275402f1c8259f6be1ab3ba131e744a88428d72e Reviewed-on: https://chromium-review.googlesource.com/933461 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/a2158762c79502544f51c7107b57a54fbc1982ac/ml/init/ml-service.conf
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b08bf6a2bdeb2256488ceb442ee09b6fa6ec7d31 commit b08bf6a2bdeb2256488ceb442ee09b6fa6ec7d31 Author: Ken Turner <kennetht@chromium.org> Date: Fri Mar 02 03:13:23 2018 chromeos-base/ml: Install the upstart config. Installs the upstart config during src_install() and sets up the user and group in pkg_preinst(). BUG= chromium:782499 TEST=cros_workon_make --board=${BOARD} chromeos-base/ml --install CQ-DEPEND=CL:933461 Change-Id: Ieb735ba35dbfe49486eac6acbb1958aa49e9c7c0 Reviewed-on: https://chromium-review.googlesource.com/933821 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b08bf6a2bdeb2256488ceb442ee09b6fa6ec7d31/chromeos-base/ml/ml-9999.ebuild
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0f50252d5c3f0dd8fed90f3ab7ac3151c1d13265 commit 0f50252d5c3f0dd8fed90f3ab7ac3151c1d13265 Author: Ken Turner <kennetht@chromium.org> Date: Mon Mar 05 15:08:10 2018 ml: Add seccomp policy files for the ml_service Adds baseline amd64 and arm seccomp policies for the stub ML Service. BUG= chromium:782499 TEST=minijail0 -S seccomp.policy -L /usr/bin/ml_service Change-Id: I00baf657f1fece843fe4323ff27e0c3a6e80bdb0 Reviewed-on: https://chromium-review.googlesource.com/945097 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/0f50252d5c3f0dd8fed90f3ab7ac3151c1d13265/ml/seccomp/ml-service-seccomp-arm.policy [add] https://crrev.com/0f50252d5c3f0dd8fed90f3ab7ac3151c1d13265/ml/seccomp/ml-service-seccomp-amd64.policy
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2f574b369f91588a67809490da06a674bda46fca commit 2f574b369f91588a67809490da06a674bda46fca Author: Ken Turner <kennetht@chromium.org> Date: Wed Mar 07 04:19:31 2018 ml: Rename the seccomp.policy files to match other installed services. Changed the file prefix for the seccomp.policy files to match the binary name (ml_service). This is consistent with the naming of other policy files installed in /usr/share/policy/ directory. BUG= chromium:782499 TEST=None Change-Id: Ie246b83ed00190627b002cbe4dc3e484ab421238 Reviewed-on: https://chromium-review.googlesource.com/950262 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/2f574b369f91588a67809490da06a674bda46fca/ml/seccomp/ml_service-seccomp-arm.policy [rename] https://crrev.com/2f574b369f91588a67809490da06a674bda46fca/ml/seccomp/ml_service-seccomp-amd64.policy
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b36257d9b47f11cd9197343cabe8e0e324d329c5 commit b36257d9b47f11cd9197343cabe8e0e324d329c5 Author: Ken Turner <kennetht@chromium.org> Date: Wed Mar 07 09:00:52 2018 chromeos-base/ml: Install the seccomp.policy for the ml_service. The seccomp.policy for the board architecture is installed in /usr/share/policy/ so that it may be passed to minijail in the Upstart config for the ML Service. BUG= chromium:782499 TEST=cros_workon_make --board=coral chromeos-base/ml --install CQ-DEPEND=CL:950262 Change-Id: If98eebf1770103e2a3f797228dad41b4463ccc27 Reviewed-on: https://chromium-review.googlesource.com/950162 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b36257d9b47f11cd9197343cabe8e0e324d329c5/chromeos-base/ml/ml-9999.ebuild
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/619bf62b4e714b263bcd3346be404bec9ab407d4 commit 619bf62b4e714b263bcd3346be404bec9ab407d4 Author: Ken Turner <kennetht@chromium.org> Date: Thu Mar 08 06:08:28 2018 target-chromium-os: add chromeos-base/ml package. Add the chromeos-base/ml package as a common dep, controlled by the ml_service USE flag. BUG= chromium:782499 TEST=equery-coral u target-chromium-os # lists ml_service as unset TEST=export USE="ml_service"; ./build_packages ... ; ./build_image ... Change-Id: I6d0867d9bf947e139bbf513a1f21f910443e9d3c Reviewed-on: https://chromium-review.googlesource.com/942541 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [rename] https://crrev.com/619bf62b4e714b263bcd3346be404bec9ab407d4/virtual/target-chromium-os/target-chromium-os-1-r88.ebuild [modify] https://crrev.com/619bf62b4e714b263bcd3346be404bec9ab407d4/virtual/target-chromium-os/target-chromium-os-1.ebuild
,
Mar 9 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0ca5b4d92f094b91af653dc52aa15b1a82546c8c commit 0ca5b4d92f094b91af653dc52aa15b1a82546c8c Author: Ken Turner <kennetht@chromium.org> Date: Tue Mar 13 14:36:56 2018 ml: Pass the seccomp.policy to minijail when starting the ml_service. Uses the seccompl.policy file installed in /usr/share/policy/ by the chromeos-base/ml ebuild. Also passes -n to minijail to set the no_new_privs option. BUG= chromium:782499 TEST=cros_workon_make, cros deploy, verified service is running on reboot. CQ-DEPEND=CL:950162 Change-Id: Id4359578e2462bd461335584171866b0cb830133 Reviewed-on: https://chromium-review.googlesource.com/949905 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0ca5b4d92f094b91af653dc52aa15b1a82546c8c/ml/init/ml-service.conf
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2369a78221e31af8edc3480cb4f507e671cdd87a commit 2369a78221e31af8edc3480cb4f507e671cdd87a Author: Claudio M <claudiomagni@chromium.org> Date: Thu Mar 15 22:27:28 2018 system_api: Add a dependency on the mojo library in the System API ebuild. BUG= chromium:782499 TEST=cros_workon_make --board=${BOARD} chromeos-base/system_api Change-Id: Ic6bcea4f794e714face712901d2139e2dcc47bac Reviewed-on: https://chromium-review.googlesource.com/942502 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Claudio M <claudiomagni@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2369a78221e31af8edc3480cb4f507e671cdd87a/chromeos-base/system_api/system_api-9999.ebuild
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c1a958f4b0f7949766e325eadc71a155c9242c6a commit c1a958f4b0f7949766e325eadc71a155c9242c6a Author: Michael Martis <martis@chromium.org> Date: Fri Mar 16 06:44:17 2018 Added a rough pass at a TensorFlow ebuild to allow prototyping of ML features. Some caveats: - This is intended to be a prototype package only (that is, we won't add it in its current state to any overlays). Individual engineers will use this package manually for prototyping, and once we have it in a better state (e.g. not monolithic) we will deploy it proper. - The src_prepare stage currently downloads dependencies from external mirrors. We will break these out into ebuilds that use internal mirrors (and uprev eigen) prior to deploying the package. - The package currently only supports 64-bit x86 CPUs. We will add support for ARM (and 32-bit x86, if necessary) CPUs prior to deploying the package. - We will submit the patches to TF source code upstream. BUG= chromium:782499 TEST=manual Change-Id: Ia7d296f02b33be6a1ff38bcc5b2e8b2b44fd6d39 Reviewed-on: https://chromium-review.googlesource.com/945468 Commit-Ready: Michael Martis <martis@chromium.org> Tested-by: Michael Martis <martis@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/c1a958f4b0f7949766e325eadc71a155c9242c6a/chromeos-base/tensorflow/tensorflow-1.5.0.ebuild [add] https://crrev.com/c1a958f4b0f7949766e325eadc71a155c9242c6a/chromeos-base/tensorflow/Manifest [add] https://crrev.com/c1a958f4b0f7949766e325eadc71a155c9242c6a/chromeos-base/tensorflow/files/tensorflow-1.5.0-nsync-makefile-clang.patch [add] https://crrev.com/c1a958f4b0f7949766e325eadc71a155c9242c6a/chromeos-base/tensorflow/files/tensorflow-1.5.0-tf-makefile-clang.patch [add] https://crrev.com/c1a958f4b0f7949766e325eadc71a155c9242c6a/chromeos-base/tensorflow/files/tensorflow-1.5.0-tf-lite-protos.patch
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/72bfdd343136630b33cff1b1975fd929c4eb9e44 commit 72bfdd343136630b33cff1b1975fd929c4eb9e44 Author: Andrew Moylan <amoylan@chromium.org> Date: Mon Mar 19 04:09:59 2018 Add DBus service constants for ML Service This DBus interface is for bootstrapping a Mojo connection between platform2/ml/daemon.cc and its client on Chrome side: chromeos/dbus/ml_client.* (to be introduced in a future CL). BUG= chromium:782499 TEST=Compiled stuff that #includes this header Change-Id: Ia3febafd5fadc5624760968dab1f0a9cf02ea308 Reviewed-on: https://chromium-review.googlesource.com/963869 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/72bfdd343136630b33cff1b1975fd929c4eb9e44/dbus/service_constants.h
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eae8dab54b508f49799526916e4b803675c53354 commit eae8dab54b508f49799526916e4b803675c53354 Author: Michael Martis <martis@chromium.org> Date: Fri Mar 23 01:17:05 2018 Removed Abseil as a monolithic dependency of TF. It turns out Abseil is only used for TF lite and non-C++ bindings. BUG= chromium:782499 TEST=manual Change-Id: I61ce00d8b4ab1f1e9a62c6dc8103144f34bb1560 Reviewed-on: https://chromium-review.googlesource.com/974727 Commit-Ready: Michael Martis <martis@chromium.org> Tested-by: Michael Martis <martis@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/eae8dab54b508f49799526916e4b803675c53354/chromeos-base/tensorflow/tensorflow-1.5.0-r1.ebuild [modify] https://crrev.com/eae8dab54b508f49799526916e4b803675c53354/chromeos-base/tensorflow/tensorflow-1.5.0.ebuild
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/db53ac787092009cbb8750bcb7201a16b944b12c commit db53ac787092009cbb8750bcb7201a16b944b12c Author: Ken Turner <kennetht@chromium.org> Date: Thu Mar 29 02:34:44 2018 ml: Autotest setup for the ML Service. Initial setup for the ML Service autotests and suite, with a first test which verifies that the ml_service is running after the system services have started. BUG= chromium:782499 TEST=test_that --board=amd64-generic localhost:9222 suite:ml_service Change-Id: I468858136e16465996021493c224ffcce96a884d Reviewed-on: https://chromium-review.googlesource.com/979383 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/db53ac787092009cbb8750bcb7201a16b944b12c/site_utils/attribute_whitelist.txt [add] https://crrev.com/db53ac787092009cbb8750bcb7201a16b944b12c/client/site_tests/ml_CheckMlProcesses/control [add] https://crrev.com/db53ac787092009cbb8750bcb7201a16b944b12c/test_suites/control.ml_service
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/ae0b0e56e31d90ef36b0c2bda7801ff30577cc02 commit ae0b0e56e31d90ef36b0c2bda7801ff30577cc02 Author: Claudio M <claudiomagni@chromium.org> Date: Thu Mar 29 06:23:44 2018 Add learning example mojom for the ML Service. The Chrome OS Machine Learning (ML) Service wraps the TensorFlow runtime and provides a Mojo interface to clients for loading and evaluating ML models. This change defines the datatypes for the Mojo API. Design doc: go/chromeos-learning-service-mojo BUG= chromium:782499 TEST=None Change-Id: Ifb669ce6558b681e9a4da861592717778ae6e70a Reviewed-on: https://chromium-review.googlesource.com/930063 Commit-Ready: Claudio M <claudiomagni@chromium.org> Tested-by: Claudio M <claudiomagni@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/ae0b0e56e31d90ef36b0c2bda7801ff30577cc02/system_api.gyp [add] https://crrev.com/ae0b0e56e31d90ef36b0c2bda7801ff30577cc02/mojo/ml_service/learning_example.mojom
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8a634f03ed43f71d7206ba8a00a0b77fdf7c1b8f commit 8a634f03ed43f71d7206ba8a00a0b77fdf7c1b8f Author: Michael Martis <martis@chromium.org> Date: Thu Mar 29 06:23:46 2018 Explained why the TF ebuild doesn't use the Eigen package. TF requires functionality from a new (non-stable) Eigen branch. We can uprev the Eigen package and use it when a stable Eigen branch is released with this functionality. BUG= chromium:782499 TEST=manual Change-Id: Ibf78968ff83df32e3869c4738ec5e76cfb0af407 Reviewed-on: https://chromium-review.googlesource.com/979385 Commit-Ready: Michael Martis <martis@chromium.org> Tested-by: Michael Martis <martis@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8a634f03ed43f71d7206ba8a00a0b77fdf7c1b8f/chromeos-base/tensorflow/tensorflow-1.5.0.ebuild [rename] https://crrev.com/8a634f03ed43f71d7206ba8a00a0b77fdf7c1b8f/chromeos-base/tensorflow/tensorflow-1.5.0-r2.ebuild
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/489bb891fa85c96b728713265edd46010e7f12a1 commit 489bb891fa85c96b728713265edd46010e7f12a1 Author: Ken Turner <kennetht@chromium.org> Date: Thu Mar 29 17:25:18 2018 autotest-tests-ml: Add ML Service tests Creates an ebuild for the intial ML Service tests and adds a dep to the autotest-all ebuild, protected by the 'ml_service' USE flag. BUG= chromium:782499 TEST=emerge-amd64-generic autotest-all CQ-DEPEND=CL:979383 Change-Id: I0c6aa69afc07b69dcabaa0a196ee177cc76723d3 Reviewed-on: https://chromium-review.googlesource.com/979384 Commit-Ready: Ken Turner <kennetht@chromium.org> Tested-by: Ken Turner <kennetht@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [add] https://crrev.com/489bb891fa85c96b728713265edd46010e7f12a1/chromeos-base/autotest-tests-ml/autotest-tests-ml-9999.ebuild [rename] https://crrev.com/489bb891fa85c96b728713265edd46010e7f12a1/chromeos-base/autotest-all/autotest-all-0.0.1-r46.ebuild [modify] https://crrev.com/489bb891fa85c96b728713265edd46010e7f12a1/chromeos-base/autotest-all/autotest-all-0.0.1.ebuild
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/305b0fa724e550ce662e22b4193b8c6fc63ff2f2 commit 305b0fa724e550ce662e22b4193b8c6fc63ff2f2 Author: Claudio M <claudiomagni@chromium.org> Date: Mon Apr 09 04:46:22 2018 Add main mojom files for the ML Service API. This CL adds two mojom files. 1) Datatype to specify a model. 2) Interface to load a model and execute inference on it. BUG= chromium:782499 TEST=None CQ-DEPEND=CL:930063 Change-Id: I78accdd58a3d5a50a5ccff9898ec68e84274a534 Reviewed-on: https://chromium-review.googlesource.com/967901 Commit-Ready: Claudio M <claudiomagni@chromium.org> Tested-by: Claudio M <claudiomagni@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [add] https://crrev.com/305b0fa724e550ce662e22b4193b8c6fc63ff2f2/mojo/ml_service/interface.mojom [add] https://crrev.com/305b0fa724e550ce662e22b4193b8c6fc63ff2f2/mojo/ml_service/model.mojom
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ef116f9b565924294bd3a6076eee94bf486a3b4e commit ef116f9b565924294bd3a6076eee94bf486a3b4e Author: Andrew Moylan <amoylan@chromium.org> Date: Fri Apr 13 06:11:00 2018 ml: Skeleton daemon D-Bus handler This first step just registers as a owner of the D-Bus ML service interface and handles the BootstrapMojoConnection method (with a no-op for now). BUG= chromium:782499 TEST=dbus-send --system --print-reply --dest=org.chromium.Ml \ --type=method_call /org/chromium/Ml \ org.chromium.Ml.BootstrapMojoConnection Change-Id: I6e530542002283cf0db3551b6922cf9c9a6fc027 Reviewed-on: https://chromium-review.googlesource.com/1006555 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/ef116f9b565924294bd3a6076eee94bf486a3b4e/ml/daemon.h [modify] https://crrev.com/ef116f9b565924294bd3a6076eee94bf486a3b4e/ml/daemon.cc [add] https://crrev.com/ef116f9b565924294bd3a6076eee94bf486a3b4e/ml/dbus_permissions/org.chromium.Ml.conf
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/47a1c829c9ba56a90b23b85e4d68d0e805362e26 commit 47a1c829c9ba56a90b23b85e4d68d0e805362e26 Author: Andrew Moylan <amoylan@chromium.org> Date: Mon Apr 16 02:20:33 2018 chromeos-base/ml: Install ML service D-bus config This installs the D-Bus permissions configuration file added in CL 1006555 into the standard location /etc/dbus-1/system.d. The config lets user ml-service own the Ml D-Bus interface. Tested with: dbus-send --system --print-reply --dest=org.chromium.Ml \ --type=method_call /org/chromium/Ml \ org.chromium.Ml.BootstrapMojoConnection CQ-DEPEND=CL:1006555 BUG= chromium:782499 TEST=dbus-send as above Change-Id: I636d246f6706e99bc8e1a6a00426b6e17afbf3c0 Reviewed-on: https://chromium-review.googlesource.com/1006556 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/47a1c829c9ba56a90b23b85e4d68d0e805362e26/chromeos-base/ml/ml-9999.ebuild
,
Apr 17 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/dbde1c80f8b0eb26165bc67ec6995a25e38ac01f commit dbde1c80f8b0eb26165bc67ec6995a25e38ac01f Author: Andrew Moylan <amoylan@chromium.org> Date: Wed Apr 18 03:53:08 2018 ml: Rename dbus_permissions/ dir to dbus/ I neglected to rename this in crrev.com/c/1006555 after the corresponding reviewer comment in related CL crrev.com/c/1006556#message-55c0df6da03fec747ce786d9285ebf40328698eb. BUG= chromium:782499 TEST=dbus-send --system --print-reply --dest=org.chromium.Ml \ --type=method_call /org/chromium/Ml \ org.chromium.Ml.BootstrapMojoConnection Change-Id: I9f3cb1bcddebc403e862bc9644226512988002e1 Reviewed-on: https://chromium-review.googlesource.com/1013840 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [rename] https://crrev.com/dbde1c80f8b0eb26165bc67ec6995a25e38ac01f/ml/dbus/org.chromium.Ml.conf
,
Apr 23 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e47ed9bf5a2a5a41f007cc4291e191effbe4cd09 commit e47ed9bf5a2a5a41f007cc4291e191effbe4cd09 Author: Andrew Moylan <amoylan@chromium.org> Date: Tue Apr 24 13:22:36 2018 ml: Update seccomp to enable D-Bus registration The recent CL crrev.com/c/1006555 added basic D-Bus connectivity to the ml_service daemon, but didn't update the corresponding seccomp policy files (so ml_service currently can't start up under minijail). This CL expands the seccomp policy files for ml_service to add the extra syscalls used by D-Bus. This fixes the ml_CheckMlProcesses autotest (not enabled by default). BUG= chromium:782499 TEST=Ran autotest ml_CheckMlProcesses on an arm and amd64 devices Change-Id: I85d630be42c328dc660d324b3feb9129d5131c51 Reviewed-on: https://chromium-review.googlesource.com/1023674 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e47ed9bf5a2a5a41f007cc4291e191effbe4cd09/ml/seccomp/ml_service-seccomp-arm.policy [modify] https://crrev.com/e47ed9bf5a2a5a41f007cc4291e191effbe4cd09/ml/seccomp/ml_service-seccomp-amd64.policy
,
May 15 2018
Converting cross-functional bits to new bit states described in new launch process (https://docs.google.com/document/d/1hJ1U8-7DNa7lGfTJWRgSgqQyNnOFO4Ks5Czr1-3--8I/edit?usp=sharing). Ping amineer@ with any questions.
,
May 15 2018
We've added two new bits to the Launch template - Launch-Exp-Leadership and Launch-Leadership - to capture leadership approval for new features. The Launch-Exp-Leadership bit is meant to capture approval for Finch-based experimentation in the stable channel. However, since Chrome OS tends not to use Finch to experiment in the stable channel, setting this bit to NA for all Chrome OS-only launches. Ping amineer@ with any questions / concerns.
,
May 16 2018
Per updates to go/newChromeFeature, setting new Launch-Leadership bit (meant to capture leadership approval) to NotReviewed. Ping amineer@ for questions.
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/94f8ebb6f87abb7a2c180bc81856c97d6a835cdb commit 94f8ebb6f87abb7a2c180bc81856c97d6a835cdb Author: Andrew Moylan <amoylan@chromium.org> Date: Wed Jul 04 05:31:00 2018 libchromeos-use-flags: Add ml_service USE flag Will be used to conditionally enable MachineLearningService Chrome flag. BUG= chromium:836092 , chromium:782499 TEST=manual Change-Id: I1ba02350b6787fe24b507b03e6b1ff003e15892d Reviewed-on: https://chromium-review.googlesource.com/1123977 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/94f8ebb6f87abb7a2c180bc81856c97d6a835cdb/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r53.ebuild [modify] https://crrev.com/94f8ebb6f87abb7a2c180bc81856c97d6a835cdb/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/359f23e5ab10d2cde1f4322f3f4bccd391f93184 commit 359f23e5ab10d2cde1f4322f3f4bccd391f93184 Author: Andrew Moylan <amoylan@chromium.org> Date: Mon Jul 09 02:28:28 2018 login: Enable ML service Chrome flag per USE flag CQ-DEPEND=CL:1123977 BUG= chromium:836092 , chromium:782499 TEST=manual Change-Id: Ie48f5af127626bf019cf0679d3191a9af76b1fa6 Reviewed-on: https://chromium-review.googlesource.com/1123971 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/359f23e5ab10d2cde1f4322f3f4bccd391f93184/login_manager/chrome_setup.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/49f50b36492ae6bdeb2bc4fe55b5fd1fdc83b411 commit 49f50b36492ae6bdeb2bc4fe55b5fd1fdc83b411 Author: Andrew Moylan <amoylan@chromium.org> Date: Thu Aug 02 07:19:56 2018 ml: Rename to org.chromium.MachineLearning org.chromium.Ml is not very readable. Renaming this while it's still easy (Chromium doesn't call it yet). TEST=local build BUG= chromium:782499 CQ-DEPEND=CL:1152628, CL:1152627 Change-Id: Id7542964ff0c531be77756453a365897907422ba Reviewed-on: https://chromium-review.googlesource.com/1152346 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/49f50b36492ae6bdeb2bc4fe55b5fd1fdc83b411/ml/dbus/org.chromium.MachineLearning.conf [modify] https://crrev.com/49f50b36492ae6bdeb2bc4fe55b5fd1fdc83b411/ml/daemon.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/90aa06612625ecfc71e2415d90916e3408e6f229 commit 90aa06612625ecfc71e2415d90916e3408e6f229 Author: Andrew Moylan <amoylan@chromium.org> Date: Thu Aug 02 07:19:57 2018 Rename to org.chromium.MachineLearning org.chromium.Ml is not very readable. Change it while we still can. Chromium doesn't call ML Service yet so this change can still be done easily. TEST=local build BUG= chromium:782499 CQ-DEPEND=CL:1152628, CL:1152346 Change-Id: I51c1bb2b3f5501a2a3173f2d5b07568e4787b991 Reviewed-on: https://chromium-review.googlesource.com/1152627 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/90aa06612625ecfc71e2415d90916e3408e6f229/dbus/service_constants.h
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/41d8cea437d65ea4fd565e64dcde4a807554025b commit 41d8cea437d65ea4fd565e64dcde4a807554025b Author: Andrew Moylan <amoylan@chromium.org> Date: Thu Aug 02 07:19:57 2018 chromeos-base/ml: Rename to org.chromium.MachineLearning org.chromium.Ml is not very readable. Rename it while we still easily can. TEST=build_packages BUG= chromium:782499 CQ-DEPEND=CL:1152346, CL:1152627 Change-Id: I91799e040584ac5e0d77eb07a995d9a381b311aa Reviewed-on: https://chromium-review.googlesource.com/1152628 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/41d8cea437d65ea4fd565e64dcde4a807554025b/chromeos-base/ml/ml-9999.ebuild
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f682c4f30000c305a005a1303eb4627a48dc32e commit 1f682c4f30000c305a005a1303eb4627a48dc32e Author: Andrew Moylan <amoylan@chromium.org> Date: Fri Aug 03 03:06:48 2018 Rename to org.chromium.Ml -> org.chromium.MachineLearning Also fix 'bug' where service name was being used instead of interface name in MethodCall (though they are the same string ...) Bug: 782499 Change-Id: I81fb4e2bf9e093b4c58984c47b993fbbd9c30c1c Reviewed-on: https://chromium-review.googlesource.com/1160833 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580425} [modify] https://crrev.com/1f682c4f30000c305a005a1303eb4627a48dc32e/chromeos/dbus/machine_learning_client.cc
,
Oct 5
Switching this bug to Feature type. It essentially morphed into the master implementation bug, rather than launch bug. We have a new launch bug here: crbug.com/892495
,
Oct 5
,
Oct 7
Last blocking issue is 863780 then we can mark this as fixed for V1.
,
Oct 7
,
Oct 7
,
Dec 16
Closing as blockers are all resolved. We are creating client integrations. |
|||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||
Comment 1 by r...@chromium.org
, Nov 8 2017