GLES2DecoderImpl::offscreen_target_samples_ should be 0 for non-multisampled |
||||
Issue descriptionGLES2DecoderImpl::offscreen_target_samples_ should be 0 for non-multisampled, but it's set to 1 instead sometimes. Variable here: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?l=2340&rcl=8945ee184364eccc91f0b18d90bbdf9cecdf8565 Probable errors here: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?l=3432&rcl=8945ee184364eccc91f0b18d90bbdf9cecdf8565 and here: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?l=3446&rcl=8945ee184364eccc91f0b18d90bbdf9cecdf8565 Blocking b/30976816
,
Nov 11 2017
I thought the test failure was caused by my changes, but apparently not. I'll try submitting this change for a dry run. https://crrev.com/c/765091
,
Nov 11 2017
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0ff710d32386aeeaa3587bd985a948b0a357c2b commit a0ff710d32386aeeaa3587bd985a948b0a357c2b Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Nov 13 20:38:21 2017 Set offscreen_target_samples_=0 if nonmultisampled GLES2DecoderImpl::offscreen_target_samples_ should be 0 for nonmultisampled offscreen targets, but it was set to 1 instead sometimes. Bug: 782497 , b/30976816 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2efa1e432632c7d86d8b071ead7a0cdbfc9a2784 Reviewed-on: https://chromium-review.googlesource.com/765091 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#516033} [modify] https://crrev.com/a0ff710d32386aeeaa3587bd985a948b0a357c2b/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Nov 13 2017
Waiting for verification of b/30976816 before closing.
,
Nov 21 2017
,
Dec 5 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kainino@chromium.org
, Nov 9 2017