Add pcm/float32 support to MediaRecorder |
|||||||
Issue descriptionChrome Version : 62.0.3202.89 OS Version: The MediaRecorder requires that all audio be compressed with the Opus codec. It'd be nice to have a way to record lossless audio. PCM/float32 is a good choice, as it's simple and it's what comes out of the microphones natively. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.89 Safari/537.36
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ffd605a2b7871dc284c62ebf9836ae963672b83 commit 2ffd605a2b7871dc284c62ebf9836ae963672b83 Author: Terry Tai <ttai@google.com> Date: Wed Nov 08 06:07:17 2017 Modify MediaRecorderHandler to support PCM. Adds PCM support to MediaRecorderHandler by "codecs=pcm" support. Detect the audio codec and then choose the right encoder in the AudioTrackRecorder. Pass through the codec to the WebmMuxer so that it can choose the right mkv audio tag. Bug: 782492 Change-Id: I80c1742320b0531ca7d2a851d423e3693f0918bd Reviewed-on: https://chromium-review.googlesource.com/750302 Commit-Queue: Terry Tai <ttai@google.com> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#514769} [modify] https://crrev.com/2ffd605a2b7871dc284c62ebf9836ae963672b83/content/renderer/media_recorder/media_recorder_handler.cc [modify] https://crrev.com/2ffd605a2b7871dc284c62ebf9836ae963672b83/content/renderer/media_recorder/media_recorder_handler.h [modify] https://crrev.com/2ffd605a2b7871dc284c62ebf9836ae963672b83/content/renderer/media_recorder/media_recorder_handler_unittest.cc [modify] https://crrev.com/2ffd605a2b7871dc284c62ebf9836ae963672b83/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
,
Nov 9 2017
The above fix requires a merge to M63?
,
Nov 9 2017
Sorry...what does that mean? I'm a noob.
,
Nov 9 2017
I'm seeing the issue reported on M62 Chrome, so the fix need to be merged to M63 as well?
,
Nov 9 2017
I don't know standard chrome procedures..., but it'd be insanely amazing if we could get this out sooner than M64.
,
Nov 9 2017
It's landing on ToT and rolling from it. No merge to 63.
,
Nov 9 2017
Issue 781744 has been merged into this issue.
,
Nov 9 2017
,
Nov 15 2017
Hey ttai@ did you land all the CLs needed?
,
Nov 15 2017
Yep. All done. As far as I can tell anyway.
,
Nov 24 2017
Marking as Fixed per #12
,
Feb 6 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ttai@google.com
, Nov 8 2017