New issue
Advanced search Search tips

Issue 782477 link

Starred by 1 user
Status: Fixed
Owner:
bpastene@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Figure out why chromium builders on chromium.swarm always clobber

Project Member Reported by bpastene@chromium.org, Nov 8 2017 
See https://build.chromium.org/p/chromium.swarm/builders/Android%20N5%20Swarm

Every build is a clobber (the out dir changes for every build) This makes cycle times slow, which is unfortunate.

It's got to be something with how the recipe sets up paths/caches. Or maybe it's due to the fact that that waterfall runs on kitchen. Though, the linux_chromium_headless_rel trybot also runs on remote_run + kitchen and seems fine: https://codesearch.chromium.org/chromium/build/scripts/slave/remote_run.py?rcl=3689d167fb2c95334b9f91dd0020d9d666f7a654&l=65

Filing this just to track stuff I find.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7fd1053911d70acde0bae9470e8762f78d6360dd

commit 7fd1053911d70acde0bae9470e8762f78d6360dd
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Wed Nov 08 18:36:04 2017

Use chromium_checkout module in swarming/staging recipe.

Instead of using bot_update directly.

I don't know how or why, but this prevents that recipe from using a new
output directory for every build, which should speed up compiles.

Bug:  782477 
Change-Id: If276cac390d6bc4352cdff86648657000f2dae0e
Reviewed-on: https://chromium-review.googlesource.com/758037
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>

[modify] https://crrev.com/7fd1053911d70acde0bae9470e8762f78d6360dd/scripts/slave/README.recipes.md
[modify] https://crrev.com/7fd1053911d70acde0bae9470e8762f78d6360dd/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/7fd1053911d70acde0bae9470e8762f78d6360dd/scripts/slave/recipes/swarming/staging.py
[modify] https://crrev.com/7fd1053911d70acde0bae9470e8762f78d6360dd/scripts/slave/recipes/swarming/staging.expected/windows.json
[modify] https://crrev.com/7fd1053911d70acde0bae9470e8762f78d6360dd/scripts/slave/recipes/swarming/staging.expected/android.json

Comment 2 by bpastene@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)
Changing how the recipe checks out chromium src (https://chromium-review.googlesource.com/758037) did the trick. Cycle time has improved significantly:
http://shortn/_uB1u3dyklt

I don't fully understand how or why that worked but... *shrug*
►

Sign in to add a comment