New issue
Advanced search Search tips

Issue 782470 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Nov 2017
Cc:
steve...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
nightlight



Sign in to add a comment

Night Light: grey out NL color temperature settings when NL is Off

Project Member Reported by ovanieva@chromium.org, Nov 8 2017 
When Night light is disabled in Settings/Display, please grey out all the remaining settings, such as color temperature, schedule, and slider (if applicable). Apply grey shade to font and icons to indicate inactive state.

Comment 1 by sgabr...@chromium.org, Nov 8 2017 

I do not think schedule should be greyed out as it is independent from the on/off status (please let me know if I'm wrong).

The row being greyed out is only the color temperature row. We make all elements 38% opacity.

Comment 2 by ovanieva@chromium.org, Nov 8 2017 

sgtm

Comment 3 by afakhry@chromium.org, Nov 8 2017

Cc: steve...@chromium.org

Comment 4 by afakhry@chromium.org, Nov 9 2017

Summary: Night Light: grey out NL color temperature settings when NL is Off (was: Night Light: grey out NL settings when NL is Off)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c5036dbdec0c1cf0e1685c139622f66afc825f

commit e1c5036dbdec0c1cf0e1685c139622f66afc825f
Author: Ahmed Fakhry <afakhry@google.com>
Date: Fri Nov 10 21:08:38 2017

Night Light: Gray out color temperature settings when NL is off

BUG= 782470 
TEST=manual

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4df0d548483ce5df4b090071dda39a0aa7d27e3c
Reviewed-on: https://chromium-review.googlesource.com/759707
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515681}
[modify] https://crrev.com/e1c5036dbdec0c1cf0e1685c139622f66afc825f/chrome/browser/resources/settings/device_page/display.html

Comment 6 by afakhry@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment