New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782463 link

Starred by 1 user
Status: Fixed
Owner:
gangwu@chromium.org
Closed: Nov 2017
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] check return value from FixupURLAndGetVisits

Project Member Reported by gangwu@chromium.org, Nov 8 2017 
TypedURLSyncBridge::GetData and TypedURLSyncBridge::GetAllData did not check return value from TypedURLSyncBridge::FixupURLAndGetVisits, so if anything FixupURLAndGetVisits cannot get visits for an URL, then later during call "TypedURLSyncBridge::CreateEntityData"->"TypedURLSyncBridge::WriteToTypedUrlSpecifics", will hit "DCHECK(!visits.empty());"
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5259909ea06ffba1562117d1930d2ee073819468

commit 5259909ea06ffba1562117d1930d2ee073819468
Author: Gang Wu <gangwu@chromium.org>
Date: Wed Nov 08 18:35:06 2017

[USS] Check return value from TypedURLSyncBridge::FixupURLAndGetVisits

TypedURLSyncBridge::GetData and TypedURLSyncBridge::GetAllData did not
check return value from TypedURLSyncBridge::FixupURLAndGetVisits, so if
anything FixupURLAndGetVisits cannot get visits for an URL, then later
during call "TypedURLSyncBridge::CreateEntityData"->
"TypedURLSyncBridge::WriteToTypedUrlSpecifics", will hit
"DCHECK(!visits.empty());"

Bug:  782463 
Change-Id: I0f6b39fe7f5aa2625656e6ceee5a692132f5416d
Reviewed-on: https://chromium-review.googlesource.com/757897
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514893}
[modify] https://crrev.com/5259909ea06ffba1562117d1930d2ee073819468/components/history/core/browser/typed_url_sync_bridge.cc
[modify] https://crrev.com/5259909ea06ffba1562117d1930d2ee073819468/components/history/core/browser/typed_url_sync_bridge_unittest.cc

Comment 2 by gangwu@chromium.org, Nov 9 2017

Components: Services>Sync
Status: Fixed (was: Untriaged)
►

Sign in to add a comment