Issue metadata
Sign in to add a comment
|
Re-enable crashpad string conversion test after WinASan strtol interception bug is fixed |
||||||||||||||||||||||||
Issue descriptionThe crashpad_util_tests have been failing in WinASan DLL builds since they were added: https://build.chromium.org/p/chromium.clang/builders/CrWinAsan%28dll%29%20tester/builds/8 The logs say things like: ../../third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc(108): error: Value of: valid Actual: true Expected: false index 60, string 18446744073709551616, value 2147483647 But the real gist of the problem is that errno isn't set properly when Windows ASan is in use. Fixing this requires overhauling the Windows ASan CRT interception model, so it isn't likely to happen soon. Let's disable this test for now and re-enable it when the upstream bug is fixed.
,
Nov 8 2017
The upstream bug is https://bugs.llvm.org/show_bug.cgi?id=35137.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baed3b3023fca836599082e4042c6bff8272a92b commit baed3b3023fca836599082e4042c6bff8272a92b Author: Reid Kleckner <rnk@google.com> Date: Wed Nov 08 23:18:30 2017 Disable crashpad test that fails in WinASanDLL builds R=mark@chromium.org Bug: 782454 Change-Id: Ia80bf861231c3d28405ae93b8c9ab190d7ff1535 Reviewed-on: https://chromium-review.googlesource.com/757880 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#514996} [modify] https://crrev.com/baed3b3023fca836599082e4042c6bff8272a92b/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e16a775e9e8a6133a074ec01b558ce17d2f93a7 commit 0e16a775e9e8a6133a074ec01b558ce17d2f93a7 Author: Reid Kleckner <rnk@google.com> Date: Fri Nov 10 20:57:24 2017 Don't run crashpad_tests on Windows ASan bots ASan violates too many of crashpad's assumptions for it to be worth making these tests pass. Even though most crashpad tests pass with ASan and we could disable the five or so failing tests under ASan, I suspect that new crashpad tests are likely to not work under ASan. I'd rather not have to disable crashpad tests upstream and roll it just to pacify these Windows ASan bots. We should re-enable these tests when we care about shipping ASan builds to users and reporting ASan errors back through craspad. Whoever works on that is going to want to work through these tests failures and add new integration tests here. Remove the previous string test exclusion now that we won't run these tests. R=hans@chromium.org, mark@chromium.org TBR=dpranke@chromium.org Bug: 782907 , 782454 Change-Id: I5ba89193a3bcf5017a5c087040f1b1679163c17b Reviewed-on: https://chromium-review.googlesource.com/762380 Reviewed-by: Reid Kleckner <rnk@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515676} [modify] https://crrev.com/0e16a775e9e8a6133a074ec01b558ce17d2f93a7/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn [modify] https://crrev.com/0e16a775e9e8a6133a074ec01b558ce17d2f93a7/testing/buildbot/chromium.clang.json
,
Nov 10 2017
Let's dupe this against the other bug so we have one bug tracking any larger efforts to get make ASan and crashpad get along. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by r...@chromium.org
, Nov 7 2017