New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782449 link

Starred by 2 users
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Fix computation for when to redraw the scene to account for head tilt

Project Member Reported by mthiesse@chromium.org, Nov 7 2017 
The current computation just looks at forward vector angle changing, and fails to take into account head tilt which can cause us to reproject way further than expected.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4

commit 31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Nov 08 15:59:38 2017

[vr] Account for tilt in head pose change calculation

With this change, the utility functions for dealing with head poses
are moved into a platform independent directory, tests have been added,
and head tilt detection has been incorporated into the function that
determines similarity between head poses.

Bug:  782449 
Change-Id: I10f7af1958ae0eb2a1de13f238371425fc4ed939
Reviewed-on: https://chromium-review.googlesource.com/757590
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514846}
[modify] https://crrev.com/31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4/chrome/browser/vr/pose_util.cc
[add] https://crrev.com/31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4/chrome/browser/vr/pose_util.h
[add] https://crrev.com/31ebe1ffcfe3b6c99e07e0aecad68c3db64cd2a4/chrome/browser/vr/pose_util_unittest.cc

Comment 2 by vollick@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment