New issue
Advanced search Search tips

Issue 782445 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

Enable OpenVR behind runtime flag

Project Member Reported by billorr@chromium.org, Nov 7 2017

Issue description

This bug represents the work to move from a compile flag to a runtime flag.
 
Components: Internals>VR
Labels: -Pri-3 M-64 Pri-2
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14d631ca392fa139a6f6b89d052d089b99758e33

commit 14d631ca392fa139a6f6b89d052d089b99758e33
Author: Bill Orr <billorr@chromium.org>
Date: Sat Nov 18 02:39:38 2017

Enable OpenVR devices behind a runtime flag on Windows

BUG= 782445 

Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588
Reviewed-on: https://chromium-review.googlesource.com/757859
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517684}
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/chrome/browser/about_flags.cc
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/chrome/browser/vr/service/vr_device_manager.cc
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/chrome/common/chrome_features.cc
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/chrome/common/chrome_features.h
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/device/vr/BUILD.gn
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/device/vr/features/features.gni
[modify] https://crrev.com/14d631ca392fa139a6f6b89d052d089b99758e33/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3027032c9d9964366b8702a07752b0669577308b

commit 3027032c9d9964366b8702a07752b0669577308b
Author: Ian Vollick <vollick@chromium.org>
Date: Sun Nov 19 16:00:56 2017

Revert "Enable OpenVR devices behind a runtime flag on Windows"

This reverts commit 14d631ca392fa139a6f6b89d052d089b99758e33.

Reason for revert: speculative revert to address launch issue on Windows

Original change's description:
> Enable OpenVR devices behind a runtime flag on Windows
> 
> BUG= 782445 
> 
> Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588
> Reviewed-on: https://chromium-review.googlesource.com/757859
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517684}

TBR=ddorwin@chromium.org,mthiesse@chromium.org,bajones@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  782445 
Change-Id: Ib344cc9763d822ebe5ee47b33e751270b6a9e489
Reviewed-on: https://chromium-review.googlesource.com/777858
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517733}
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/chrome/browser/about_flags.cc
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/chrome/browser/vr/service/vr_device_manager.cc
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/chrome/common/chrome_features.cc
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/chrome/common/chrome_features.h
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/device/vr/BUILD.gn
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/device/vr/features/features.gni
[modify] https://crrev.com/3027032c9d9964366b8702a07752b0669577308b/tools/metrics/histograms/enums.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20 2017

Labels: merge-merged-3273
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32a8b18b366a5a02cf7edc35c27dcd3516848a37

commit 32a8b18b366a5a02cf7edc35c27dcd3516848a37
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Nov 20 05:10:24 2017

Revert "Enable OpenVR devices behind a runtime flag on Windows"

This reverts commit 14d631ca392fa139a6f6b89d052d089b99758e33.

Reason for revert: speculative revert to address launch issue on Windows

TBR=govind@google.com

Original change's description:
> Enable OpenVR devices behind a runtime flag on Windows
>
> BUG= 782445 
>
> Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588
> Reviewed-on: https://chromium-review.googlesource.com/757859
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517684}

TBR=ddorwin@chromium.org,mthiesse@chromium.org,bajones@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  782445 
Change-Id: Ib344cc9763d822ebe5ee47b33e751270b6a9e489
Reviewed-on: https://chromium-review.googlesource.com/777858
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#517733}(cherry picked from commit 3027032c9d9964366b8702a07752b0669577308b)
Reviewed-on: https://chromium-review.googlesource.com/778442
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/branch-heads/3273@{#3}
Cr-Branched-From: b1eb939d79d6d1184b614d5d6a1b8b0658cc9807-refs/heads/master@{#517724}
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/chrome/browser/about_flags.cc
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/chrome/browser/vr/service/vr_device_manager.cc
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/chrome/common/chrome_features.cc
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/chrome/common/chrome_features.h
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/device/vr/BUILD.gn
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/device/vr/features/features.gni
[modify] https://crrev.com/32a8b18b366a5a02cf7edc35c27dcd3516848a37/tools/metrics/histograms/enums.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4952756a5be50b834fae883719e2ef19441c9f7e

commit 4952756a5be50b834fae883719e2ef19441c9f7e
Author: Bill Orr <billorr@chromium.org>
Date: Wed Nov 22 16:58:48 2017

Reland "Enable OpenVR devices behind a runtime flag on Windows"

This change moves openvr_api.dll to instead be statically linked so
there is no extra required dll's to deploy/load.

This is a reland of 14d631ca392fa139a6f6b89d052d089b99758e33
Original change's description:
> Enable OpenVR devices behind a runtime flag on Windows
>
> BUG= 782445 
>
> Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588
> Reviewed-on: https://chromium-review.googlesource.com/757859
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517684}

Bug:  782445 
Change-Id: I922b4382380230b69ff14de6877cb2f44dfd7235
Reviewed-on: https://chromium-review.googlesource.com/779623
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518657}
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/chrome/browser/about_flags.cc
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/chrome/browser/vr/service/vr_device_manager.cc
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/chrome/common/chrome_features.cc
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/chrome/common/chrome_features.h
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/device/vr/BUILD.gn
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/device/vr/features/features.gni
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/third_party/openvr/BUILD.gn
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/third_party/openvr/README.chromium
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/third_party/openvr/src/headers/openvr.h
[modify] https://crrev.com/4952756a5be50b834fae883719e2ef19441c9f7e/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)
Components: Internals>XR
Components: Blink>WebXR

Sign in to add a comment