New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782441 link

Starred by 2 users
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
█ asimjour@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Hit testing of the exit prompt is broken

Project Member Reported by vollick@chromium.org, Nov 7 2017 
If you click on the lock icon, you will see a prompt about exiting VR.
You will not be able to click on the buttons on this UI.

This regressed when we switched hit testing to respect draw order in https://chromium-review.googlesource.com/c/chromium/src/+/754554
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd196517b6d70de2e5bf0fca5cac4134ad67a47

commit 1dd196517b6d70de2e5bf0fca5cac4134ad67a47
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Nov 08 16:01:58 2017

[vr] Change tree ordering of exit prompt vs exit prompt backplane

With this change, the exit prompt becomes a descendant of the backplane.
The result is that hit testing will again consider the exit prompt "in
front" making the UI usable again.

Bug:  782441 
Change-Id: I6294a5b12d00ada006d0ff65c0e5e963b6809cac
Reviewed-on: https://chromium-review.googlesource.com/757588
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514849}
[modify] https://crrev.com/1dd196517b6d70de2e5bf0fca5cac4134ad67a47/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/1dd196517b6d70de2e5bf0fca5cac4134ad67a47/chrome/browser/vr/ui_renderer_unittest.cc
[modify] https://crrev.com/1dd196517b6d70de2e5bf0fca5cac4134ad67a47/chrome/browser/vr/ui_scene_manager.cc

Comment 2 by vollick@chromium.org, Nov 13 2017

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Feb 7 2018

Labels: M-64 Test-Complete
►

Sign in to add a comment