New issue
Advanced search Search tips

Issue 782429 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Compile failure on official desktop continuous Mac64 trunk builder

Project Member Reported by pbomm...@chromium.org, Nov 7 2017

Issue description

Link to builder :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/8242


Link to Error log :
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fmac64_trunk%2F8242%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout



Error :
FAILED: obj/net/net_unittests/observation_buffer_unittest.o 
export DEVELOPER_DIR=/b/c/b/mac64_trunk/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/net/net_unittests/observation_buffer_unittest.o.d -DUSE_KERBEROS -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"317263-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DUNIT_TEST -I../.. -Igen -I../../third_party/googletest/src/googletest/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -I../../third_party/zlib -I../../v8/include -Igen/v8/include -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-unsigned-enum-zero-compare -Wno-tautological-constant-compare -O2 -fno-omit-frame-pointer -gdwarf-2 -fno-standalone-debug -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../net/nqe/observation_buffer_unittest.cc -o obj/net/net_unittests/observation_buffer_unittest.o
../../net/nqe/observation_buffer_unittest.cc:341:21: error: no matching constructor for initialization of 'net::nqe::internal::ObservationBuffer'
  ObservationBuffer buffer(0.5, 1.0);
                    ^      ~~~~~~~~
../../net/nqe/observation_buffer.h:143:28: note: candidate constructor not viable: requires 1 argument, but 2 were provided
  DISALLOW_COPY_AND_ASSIGN(ObservationBuffer);
                           ^
../../net/nqe/observation_buffer.h:43:3: note: candidate constructor not viable: requires 4 arguments, but 2 were provided
  ObservationBuffer(const NetworkQualityEstimatorParams* params,


Suspecting Cl :  https://chromium.googlesource.com/chromium/src/+/395d0048c8821cb676d38b601e84ec193aa1ed24

 
Status: WontFix (was: Assigned)
The offending CL has already been reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/756937

Please wait for the bots to cycle.

Sign in to add a comment