New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782415 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 780141
issue 786520



Sign in to add a comment

[Findit] Flake Analyzer - Clean up layout of UI in result page

Project Member Reported by lijeffrey@chromium.org, Nov 7 2017

Issue description

Organization of analysis result page:
1. Regression range
2. Heuristic result
3. Culprit
4. Graph
5. Metadata
 
Summary: [Findit] Flake Analyzer - Clean up layout of UI in result page (was: [Findiit] Flake Analyzer - Clean up layout of UI in result page)
Graph should expand to fix the client width with a height to match.
We should also avoid stacking everything vertically. Instead we should use the horizontal space we have to introduce some whitespace that will make our app easier to read.

Comment 4 Deleted

+--+--------------+----------------------+--+----------------------------+-----------+--+
|  | Test         | Test.TestSomething   |  | Analysis Result            | Completed |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  | Env          | cpu:x64, os:Linux    |  | Regression Range           | 1234:1235 |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  | Bug          |     examplebug       |  | Flakiness Started at build | 100       |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  |              |                      |  |                            |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  |              | +-----graph--------- |  |  ----------graph--------+  |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  |              | |                    |  |                         |  |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  |              | +-----graph--------- |  |  ------------graph------+  |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  |              |                      |  |                            |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  | Running time | 2 hours              |  |      Correct culprit?      |    y/n    |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  | Request time | 2017-11-1 1:00PM     |  | Tell us how we can improve | foobar    |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  | Pending time | 25 minutes           |  |                            |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
|  |              |                      |  |                            |           |  |
+--+--------------+----------------------+--+----------------------------+-----------+--+
Owner: wylieb@chromium.org
Over to Brandon who is taking care of this

Comment 7 by wylieb@chromium.org, Nov 17 2017

Blocking: 786520
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/19029c011eb135eb068fb7ed269d504f7c3db03a

commit 19029c011eb135eb068fb7ed269d504f7c3db03a
Author: Brandon Wylie <wylieb@chromium.org>
Date: Tue Nov 21 17:50:13 2017

[Findit] Flake Analyzer - Encapsulate analysis entities and improve ui

Encapsulate fields in flake analysis screen, and organize them.
- flaky test info element
- flake analysis element
- clean up jinja templates
End result of this cl should be to surface less information overall
when a user first loads the page. The intention is to surface critical
information to users first, and allot them to drill for other info
as needed.

ui demo: https://12767-abd258f-tainted-wylieb-dot-findit-for-me-staging.appspot.com/waterfall/flake?key=ahdzfmZpbmRpdC1mb3ItbWUtc3RhZ2luZ3KZAQsSF01hc3RlckZsYWtlQW5hbHlzaXNSb290ImNjaHJvbWl1bS5tYWMvTWFjMTAuOSBUZXN0cyAoZGJnKS8xMDAvYnJvd3Nlcl90ZXN0cy9VR0YwWTJoVVpYTjBMa05vWldOclEyOTFjbWRsZEhSbFQzQmxjbUYwYVc5dUlBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Bug:  782415 
Change-Id: Ia4ba00e7514d19310e04c0ae0fba4974b330c32d
Reviewed-on: https://chromium-review.googlesource.com/767595
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-test-info-demo.html
[modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/app-messages.html
[add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/components/expandable-card-demo.html
[add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/components/expandable-card.html
[add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-analysis-info-demo.html
[modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/handlers/flake/check_flake.py
[add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-analysis-info.html
[add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-test-info.html
[modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/third_party/bower.json
[modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/templates/flake/result.html

Comment 9 by wylieb@chromium.org, Nov 29 2017

Status: Fixed (was: Assigned)

Sign in to add a comment