[Findit] Flake Analyzer - Clean up layout of UI in result page |
||||
Issue descriptionOrganization of analysis result page: 1. Regression range 2. Heuristic result 3. Culprit 4. Graph 5. Metadata
,
Nov 8 2017
Graph should expand to fix the client width with a height to match.
,
Nov 8 2017
We should also avoid stacking everything vertically. Instead we should use the horizontal space we have to introduce some whitespace that will make our app easier to read.
,
Nov 8 2017
+--+--------------+----------------------+--+----------------------------+-----------+--+ | | Test | Test.TestSomething | | Analysis Result | Completed | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | Env | cpu:x64, os:Linux | | Regression Range | 1234:1235 | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | Bug | examplebug | | Flakiness Started at build | 100 | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | | | | | | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | | +-----graph--------- | | ----------graph--------+ | | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | | | | | | | | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | | +-----graph--------- | | ------------graph------+ | | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | | | | | | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | Running time | 2 hours | | Correct culprit? | y/n | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | Request time | 2017-11-1 1:00PM | | Tell us how we can improve | foobar | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | Pending time | 25 minutes | | | | | +--+--------------+----------------------+--+----------------------------+-----------+--+ | | | | | | | | +--+--------------+----------------------+--+----------------------------+-----------+--+
,
Nov 14 2017
Over to Brandon who is taking care of this
,
Nov 17 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/19029c011eb135eb068fb7ed269d504f7c3db03a commit 19029c011eb135eb068fb7ed269d504f7c3db03a Author: Brandon Wylie <wylieb@chromium.org> Date: Tue Nov 21 17:50:13 2017 [Findit] Flake Analyzer - Encapsulate analysis entities and improve ui Encapsulate fields in flake analysis screen, and organize them. - flaky test info element - flake analysis element - clean up jinja templates End result of this cl should be to surface less information overall when a user first loads the page. The intention is to surface critical information to users first, and allot them to drill for other info as needed. ui demo: https://12767-abd258f-tainted-wylieb-dot-findit-for-me-staging.appspot.com/waterfall/flake?key=ahdzfmZpbmRpdC1mb3ItbWUtc3RhZ2luZ3KZAQsSF01hc3RlckZsYWtlQW5hbHlzaXNSb290ImNjaHJvbWl1bS5tYWMvTWFjMTAuOSBUZXN0cyAoZGJnKS8xMDAvYnJvd3Nlcl90ZXN0cy9VR0YwWTJoVVpYTjBMa05vWldOclEyOTFjbWRsZEhSbFQzQmxjbUYwYVc5dUlBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Bug: 782415 Change-Id: Ia4ba00e7514d19310e04c0ae0fba4974b330c32d Reviewed-on: https://chromium-review.googlesource.com/767595 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-test-info-demo.html [modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/app-messages.html [add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/components/expandable-card-demo.html [add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/components/expandable-card.html [add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-analysis-info-demo.html [modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/handlers/flake/check_flake.py [add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-analysis-info.html [add] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/ui/elements/analysis/flake/flake-test-info.html [modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/handlers/flake/test/check_flake_test.py [modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/third_party/bower.json [modify] https://crrev.com/19029c011eb135eb068fb7ed269d504f7c3db03a/appengine/findit/templates/flake/result.html
,
Nov 29 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wylieb@chromium.org
, Nov 8 2017