New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782414 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 780141
issue 783946



Sign in to add a comment

[Findit] Flake Analyzer - Expose heuristic analysis results to normal view

Project Member Reported by lijeffrey@chromium.org, Nov 7 2017

Issue description

Heuristic analysis is available only in debug view. Move to normal view
 
Work estimate: tiny, should be only a couple lines change
Blocking: 780141
Blocking: 783946

Comment 4 by wylieb@chromium.org, Nov 29 2017

Cc: wylieb@chromium.org
 Issue 786630  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/25ec7fd1b04128ce8185e1079106b9b387d8493f

commit 25ec7fd1b04128ce8185e1079106b9b387d8493f
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Nov 30 18:36:37 2017

[Findit] Flake Analyzer - Always show heuristic results if available

Previously heuristic results are available only to admins in debug view.
This change exposes results regardless of who is viewing, as long as they
are available.

Bug:  782414 
Change-Id: I7ad87dc87fc7ab41f18e28e5a2edc9b4a9c11985
Reviewed-on: https://chromium-review.googlesource.com/775035
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/25ec7fd1b04128ce8185e1079106b9b387d8493f/appengine/findit/ui/elements/analysis/flake/flake-analysis-info.html
[modify] https://crrev.com/25ec7fd1b04128ce8185e1079106b9b387d8493f/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/25ec7fd1b04128ce8185e1079106b9b387d8493f/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/25ec7fd1b04128ce8185e1079106b9b387d8493f/appengine/findit/templates/flake/result.html

Status: Fixed (was: Assigned)

Sign in to add a comment