Switch fetch_benchmark_deps.py to use CIPD |
||
Issue descriptionhttps://cs.chromium.org/chromium/src/tools/perf/fetch_benchmark_deps.py?q=fetch_benchmark&sq=package:chromium&l=1 currently just does google storage fetches right now. When this gets enabled for compile builders in https://chromium-review.googlesource.com/c/chromium/src/+/756353, it will add several minutes to most cycle times. CIPD is a package manager that would add caching to the mix, so that this wouldn't be that expensive to run on our builders. I'm not sure how much work it would be to use cipd here, but I think it'd be worthwhile. Filing more for tracking; I'm not planning on working on this now.
,
Nov 7 2017
The conceptual model for cipd: 1) Each cipd package is essentially a zip archive with arbitrary structure. 2) When installing packages you feed cipd a special manifest file (aka "ensure file") (documented here https://godoc.org/go.chromium.org/luci/cipd/client/cipd/ensure), it specifies where to unpack each individual package, like so: @Subdir stuff package/name1 pkg-version package/name2 pkg-version @Subdir stuff/deeper package/name2 pkg-version (and so on) So it will unpack each zip archive in corresponding folder. It is fine to construct this manifest on the fly, if necessary, from a wrapping script that calls cipd. Some more info about what packages exactly are: https://chromium.googlesource.com/infra/luci/luci-go/+/master/cipd/README.md https://chromium.googlesource.com/infra/infra/+/master/appengine/chrome_infra_packages/cipd/impl.py#5
,
Nov 8
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||
►
Sign in to add a comment |
||
Comment 1 by nedngu...@google.com
, Nov 7 2017