Issue 782384 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ yoshiki@chromium.org Last visit > 30 days ago
Closed:	Nov 2017
Cc:	peter@chromium.org
Components:	UI>Shell>Notifications
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug

Blocked on:
issue 784494

DCHECK when clicking last notification in message center

Project Member Reported by est...@chromium.org, Nov 7 2017

Issue description

after crrev.com/c13b16f94e70c76f6dd2fcdade2ab858a65dd8e9 clicking the last notification in the mc (which should dismiss the notification and then the MC) DCHECKs with this stack:

[8710:8710:1107/135625.864724:FATAL:message_center_impl.cc(158)] Check failed: !iterating_. 
#0 0x7f4062282d7c base::debug::StackTrace::StackTrace()
#1 0x7f40622a975c logging::LogMessage::~LogMessage()
#2 0x7f405ce29b83 message_center::MessageCenterImpl::SetVisibility()
#3 0x7f405ce2e786 message_center::MessageCenterTray::HideMessageCenterBubble()
#4 0x7f405ce2eae7 message_center::MessageCenterTray::OnMessageCenterChanged()
#5 0x7f405ce2b317 message_center::MessageCenterImpl::RemoveNotificationImmediately()
#6 0x7f405ce2b065 message_center::MessageCenterImpl::RemoveNotification()
#7 0x55d64cca2de3 MessageCenterNotificationManager::CancelById()

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3c9d6e3baf1d0f6c29575c0f76fa02dc0ca984b

commit e3c9d6e3baf1d0f6c29575c0f76fa02dc0ca984b
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Mon Nov 13 09:42:31 2017

Hide MessageCenter asynchronously after the last notification is gone

We should not change the visibility of the message center during the notifications are being iterated. This patch makes the code of changing visibility executed asynchronously.

Bug:  782384 
Change-Id: I36233312fdd5b3690b9c2e40597e51d8f16128e7
Reviewed-on: https://chromium-review.googlesource.com/762910
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515906}
[modify] https://crrev.com/e3c9d6e3baf1d0f6c29575c0f76fa02dc0ca984b/ui/message_center/message_center_tray.cc
[modify] https://crrev.com/e3c9d6e3baf1d0f6c29575c0f76fa02dc0ca984b/ui/message_center/message_center_tray.h