Currently we only test with 2 byte blobs. We need to test with: 1 KB blobs 1 MB blobs 200 MB blobs and somehow test with file blobs - might require a change to explicitly set the file size threshold.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1131391c410a6d01c584c4449accc7e1b1258b06 commit 1131391c410a6d01c584c4449accc7e1b1258b06 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Feb 06 03:16:52 2018 [BlobStorage] Adding size configurations to perftests Bug: 782356 Change-Id: I571b3780b314517097585af1dd488f360511ef80 Reviewed-on: https://chromium-review.googlesource.com/757168 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#534608} [modify] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/storage/browser/blob/blob_memory_controller.cc [modify] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/README.md [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-files.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-ipc.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-shm.html [modify] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-files.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-ipc.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-shm.html [modify] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-files.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-ipc.html [add] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-shm.html [modify] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately.html [modify] https://crrev.com/1131391c410a6d01c584c4449accc7e1b1258b06/tools/perf/benchmarks/blink_perf.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd9b5527f101d1bc312ac29677f38b20dfe35473 commit fd9b5527f101d1bc312ac29677f38b20dfe35473 Author: Ned Nguyen <nednguyen@google.com> Date: Wed Feb 14 03:09:31 2018 Revert "[BlobStorage] Adding size configurations to perftests" This reverts commit 1131391c410a6d01c584c4449accc7e1b1258b06. Reason for revert: Causes lot of failures on perf waterfall Bug: 811519 Original change's description: > [BlobStorage] Adding size configurations to perftests > > Bug: 782356 > Change-Id: I571b3780b314517097585af1dd488f360511ef80 > Reviewed-on: https://chromium-review.googlesource.com/757168 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#534608} TBR=dmurph@chromium.org,nednguyen@google.com,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782356 Change-Id: I75ec6a28c55ac99dba7357c3b8771f8429ca1978 Reviewed-on: https://chromium-review.googlesource.com/917801 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#536631} [modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/storage/browser/blob/blob_memory_controller.cc [modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/README.md [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-files.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-ipc.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-shm.html [modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-files.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-ipc.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-shm.html [modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-files.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-ipc.html [delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-shm.html [modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately.html [modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/tools/perf/benchmarks/blink_perf.py
📍 Pinpoint job started. https://chromeperf.appspot.com/job/15ba575f840000
📍 Pinpoint job started. https://chromeperf.appspot.com/job/12c17b2f840000
📍 Couldn't reproduce a difference. https://chromeperf.appspot.com/job/15ba575f840000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15f03aff840000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16af426f840000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/119943ff840000
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12c17b2f840000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/15f03aff840000 [BlobStorage] Making perf tests smaller & broader by dmurph@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/930241/3 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/16af426f840000
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/119943ff840000
How do I tell the different in time? These are the results from the Nexus5X in Raw CSV:
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16e47e32440000
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/16e47e32440000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ddc172440000
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14ddc172440000
Old tests: 9 seconds, 11.5 seconds, 12 seconds (3 tests): 32.5 seconds new tests: 4 seconds, 8 seconds, 3.5 seconds, 8 seconds (4 tests): 23.5 seconds So the new tests actually run faster!
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1104bf7c440000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14cfe9ea440000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12cfe9ea440000
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/12cfe9ea440000
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14cfe9ea440000
The bots seems to be failing for unrelated reasons, will wait until it's green again.
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/1104bf7c440000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ae6e06440000
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14ae6e06440000
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12b291ea440000
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12b291ea440000
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0713ac05357ca30530e663dd3f74a87bc37f22c1 commit 0713ac05357ca30530e663dd3f74a87bc37f22c1 Author: Daniel Murphy <dmurph@chromium.org> Date: Mon Mar 12 21:25:26 2018 [BlobStorage] Making perf tests smaller & broader Bug: 782356 Change-Id: I426c455e028fb70fa86eb39ba0d651bddf3cad2f Reviewed-on: https://chromium-review.googlesource.com/930241 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#542602} [modify] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/storage/browser/blob/blob_memory_controller.cc [modify] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/storage/common/blob_storage/blob_storage_constants.cc [modify] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/storage/common/blob_storage/blob_storage_constants.h [modify] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/README.md [delete] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel.html [delete] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially.html [delete] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately.html [add] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/blob-perf-files.html [add] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/blob-perf-ipc.html [add] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/blob-perf-shm.html [add] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/blob-perf-tiny.html [delete] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-build-all-then-read-serially-runner.html [delete] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-build-and-read-immediately-runner.html [rename] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-perf-runner.html [modify] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-shared.js [modify] https://crrev.com/0713ac05357ca30530e663dd3f74a87bc37f22c1/tools/perf/benchmarks/blink_perf.py
Comment 1 by dmu...@chromium.org
, Nov 7 2017