[MD extensions] Error list expand/collapse is a little complex |
||
Issue descriptionin the errors page for MD chrome://extensions we have a clickable row as well as a cr-expand-button. This makes it a little unclear what click will select the error vs. expand the error information. Consider one of: - add a separator line between the click areas or - treat the whole row as a single control.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6cd85f0905468642d3b0d311ef68940f107a7d4 commit c6cd85f0905468642d3b0d311ef68940f107a7d4 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Nov 09 22:16:43 2017 [MD extensions] remove cr-expand-button in errors page This CL changes the behavior of the expandable error rows in the errors page. The expand button part of the row is now part of the row and no longer behaves differently (i.e. the expand label and icon now behave the same way). Bug: 782340 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1ba269848aa5073526ab78bcedf5a62cdc2cc4b5 Reviewed-on: https://chromium-review.googlesource.com/756957 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#515316} [modify] https://crrev.com/c6cd85f0905468642d3b0d311ef68940f107a7d4/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/c6cd85f0905468642d3b0d311ef68940f107a7d4/chrome/browser/resources/md_extensions/error_page.js [modify] https://crrev.com/c6cd85f0905468642d3b0d311ef68940f107a7d4/chrome/test/data/webui/extensions/extension_error_page_test.js
,
Nov 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dschuyler@chromium.org
, Nov 9 2017Going with - treat the whole row as a single control. The behavior will be: - clicking on the error label or icon will: - expand the error if it's collapsed - if another error is expanded it is collapsed - collapse the error if it's expended Another way of saying the above: - no more than one error is expanded at a time - all the errors may be collapsed Further: - if an error is selected, the line of code is shown at the top of the page - if no errors are selected, the code display is hidden (there's some text saying, nothing to see here, or something similar to that).