Fix code that calls -[BVC dismissViewControllerAnimated:completion:] multiple times |
|
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/757189 adds an early return when we detect that dismissViewController is called multiple times in a row. This is a temporary measure until we find and fix all callers.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a668c02effc76b2dd141a79dd2487a19477396b3 commit a668c02effc76b2dd141a79dd2487a19477396b3 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Nov 08 00:04:44 2017 [ios] Do nothing if BVC dismissViewController is called more than once. When the BVC is presented, multiple calls to |dismissViewControllerAnimated:completion:| end up dismissing the BVC itself. This is never what we want, so check for this case and return early. BUG=768563,782338 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7a02c9f10fd1c083903beb3b858727276e1d5205 Reviewed-on: https://chromium-review.googlesource.com/757189 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#514664} [modify] https://crrev.com/a668c02effc76b2dd141a79dd2487a19477396b3/ios/chrome/browser/ui/browser_view_controller.mm |
|
►
Sign in to add a comment |
|
Comment 1 by rohitrao@chromium.org
, Nov 7 2017