New issue
Advanced search Search tips

Issue 782331 link

Starred by 1 user
Status: Fixed
Owner:
parastoog@chromium.org
Closed: Dec 2017
Cc:
se...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

For autofill profile validation, Latin version of regional data should be considered valid.

Project Member Reported by parastoog@chromium.org, Nov 7 2017 
Right now, they are considered as invalid. 

Example:

The lname for the city "毕节地区" in chromium-i18n is "Bijie Diqu", but the Autofill Profile Validation API, would consider Bijie Diqu as an invalid entry for city.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b749d67025943232cd2b92e84cab69e5ce46b85d

commit b749d67025943232cd2b92e84cab69e5ce46b85d
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Wed Nov 15 21:22:35 2017

[Autofill] Validate across languages

The Autofill Validation API should validate fields
across all available languages, and also the Latin
version of the names if available.


Bug:  754727 ,  782331 
Change-Id: Ia0f17441df1a1924dada1408a1bd972b538e7a0e
Reviewed-on: https://chromium-review.googlesource.com/763709
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516834}
[modify] https://crrev.com/b749d67025943232cd2b92e84cab69e5ce46b85d/components/autofill/core/browser/autofill_profile_validation_util_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aea954cbf796593228d62e92ff8b33783d491398

commit aea954cbf796593228d62e92ff8b33783d491398
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Nov 15 23:51:04 2017

Revert "[Autofill] Validate across languages"

This reverts commit b749d67025943232cd2b92e84cab69e5ce46b85d.

Reason for revert: tests failing on Win7 (dbg): https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64656

Original change's description:
> [Autofill] Validate across languages
> 
> The Autofill Validation API should validate fields
> across all available languages, and also the Latin
> version of the names if available.
> 
> 
> Bug:  754727 ,  782331 
> Change-Id: Ia0f17441df1a1924dada1408a1bd972b538e7a0e
> Reviewed-on: https://chromium-review.googlesource.com/763709
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516834}

TBR=mathp@chromium.org,sebsg@chromium.org,parastoog@google.com

Change-Id: I0b2f145a4c7e1a657a81f71526da66ef999a5dc6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  754727 ,  782331 
Reviewed-on: https://chromium-review.googlesource.com/772883
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516899}
[modify] https://crrev.com/aea954cbf796593228d62e92ff8b33783d491398/components/autofill/core/browser/autofill_profile_validation_util_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d6366a0f523c76b843df7bef43ed2cf22db597a

commit 6d6366a0f523c76b843df7bef43ed2cf22db597a
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Sat Nov 25 01:10:30 2017

Reland "[Autofill] Validate across languages"

This is a reland of b749d67025943232cd2b92e84cab69e5ce46b85d
Original change's description:
> [Autofill] Validate across languages
> 
> The Autofill Validation API should validate fields
> across all available languages, and also the Latin
> version of the names if available.
> 
> 
> Bug:  754727 ,  782331 
> Change-Id: Ia0f17441df1a1924dada1408a1bd972b538e7a0e
> Reviewed-on: https://chromium-review.googlesource.com/763709
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516834}

Bug:  754727 ,  782331 
Change-Id: I184f420a788491d2a9dfa35d9091a407c42bb1ce
Reviewed-on: https://chromium-review.googlesource.com/789551
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519173}
[modify] https://crrev.com/6d6366a0f523c76b843df7bef43ed2cf22db597a/components/autofill/core/browser/autofill_profile_validation_util_unittest.cc

Comment 4 by parastoog@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment