New issue
Advanced search Search tips

Issue 782326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: 2017-11-09
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter/1 failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by sky@chromium.org, Nov 7 2017

Issue description

browser_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

The flakiness dashboard shows this test has been flaky for a while https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter%2F1 . When it passes it's very close to the time limit, so it may be the test is fine, it just takes too long. If this is in fact the problem perhaps the test can be split in two (this is based on my cursory understanding of the test where it looks like it has a bunch of datasets inside it).

I'm going to disable for win dbg bots.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b69448da3fe6052b630a5b9d8548afdb95138e7

commit 2b69448da3fe6052b630a5b9d8548afdb95138e7
Author: Scott Violet <sky@chromium.org>
Date: Tue Nov 07 20:07:27 2017

Disables DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter/1 on win7-dbg

It consistently times out there.

BUG= 782326 
TEST=test only change
TBR=karandeepb@chromium.org

Change-Id: Id80368d71be1bc86f012dcd771fa90b6d0f0f864
Reviewed-on: https://chromium-review.googlesource.com/757501
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514562}
[modify] https://crrev.com/2b69448da3fe6052b630a5b9d8548afdb95138e7/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc

Labels: -Sheriff-Chromium
Removing Sheriff-Chromium now that the bug is assigned and being investigated.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dde13d71902816a9582d57cffef8a0cde6f6382c

commit dde13d71902816a9582d57cffef8a0cde6f6382c
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Thu Nov 09 00:27:37 2017

DNR: Re-enable DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter on win-dbg.

r514562 disabled DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter on
windows debug bots since the test was flaky. It seems that the test was timing
out most of the times.

This CL splits out DeclarativeNetRequestBrowserTest.BlockRequests_Separator
from it, to decrease its running time and re-enables the test.

BUG= 782326 , 696822

Change-Id: I4932cd9be67cad267ffa085a38d0a551cc8702ab
Reviewed-on: https://chromium-review.googlesource.com/757830
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515031}
[modify] https://crrev.com/dde13d71902816a9582d57cffef8a0cde6f6382c/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc

NextAction: 2017-11-09
The NextAction date has arrived: 2017-11-09
Status: Fixed (was: Assigned)
This does not appear to be flaking anymore. Marking as fixed. 

Status: Fixed (was: Assigned)
This is a different test, filed  crbug.com/787957 .

Sign in to add a comment