Significantly elevated chrome_public_test_apk failure rate since 2017-11-06 |
|||||||
Issue descriptionUnclear why yet, but the suite has gone from a typical swarming task failure rate of ~2% to >10%. (This appears to match an apparent increase in failure rate on the matching waterfall bots.)
,
Nov 7 2017
I think a lot of these tends to be crashes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk
,
Nov 7 2017
as +jbudorick suggested offline, the real failure which causes the native crash is: 11-07 04:52:56.329 30393 30393 W System.err: java.lang.AssertionError 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper.isContextualSearchActive(ContextualSearchTabHelper.java:241) 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper.updateContextualSearchHooks(ContextualSearchTabHelper.java:197) 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper.access$100(ContextualSearchTabHelper.java:26) 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper$1.onTemplateURLServiceChanged(ContextualSearchTabHelper.java:98) 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.chrome.browser.search_engines.TemplateUrlService.onTemplateURLServiceChanged(TemplateUrlService.java:254) 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) 11-07 04:52:56.329 30393 30393 W System.err: at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:52) 11-07 04:52:56.329 30393 30393 W System.err: at android.os.Handler.dispatchMessage(Handler.java:102) 11-07 04:52:56.329 30393 30393 W System.err: at android.os.Looper.loop(Looper.java:136) 11-07 04:52:56.329 30393 30393 W System.err: at android.app.ActivityThread.main(ActivityThread.java:5001) 11-07 04:52:56.329 30393 30393 W System.err: at java.lang.reflect.Method.invokeNative(Native Method) 11-07 04:52:56.329 30393 30393 W System.err: at java.lang.reflect.Method.invoke(Method.java:515) 11-07 04:52:56.329 30393 30393 W System.err: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785) 11-07 04:52:56.329 30393 30393 W System.err: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601) 11-07 04:52:56.329 30393 30393 W System.err: at dalvik.system.NativeStart.main(Native Method) +donnd who added the assertion in https://chromium-review.googlesource.com/c/chromium/src/+/738923
,
Nov 7 2017
,
Nov 7 2017
,
Nov 7 2017
Looks like one of my asserts is overly aggressive, I'll try to fix that now.
,
Nov 7 2017
Issue 782398 has been merged into this issue.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a508168ca0eff4981ef1b9ca29ca528395c2e449 commit a508168ca0eff4981ef1b9ca29ca528395c2e449 Author: Donn Denman <donnd@google.com> Date: Tue Nov 07 23:44:18 2017 [TTS] Update an assert in CSearchTabHelper Update an overly aggressive assert recently landed in ContextualSearchTabHelper when reparenting. This is causing an existing test to be very flaky (NewTabPageTest#testRender). BUG=775813, 778540, 782324 Change-Id: I041742701820dc3899378515fe37a6be44a66d7a Reviewed-on: https://chromium-review.googlesource.com/757661 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#514651} [modify] https://crrev.com/a508168ca0eff4981ef1b9ca29ca528395c2e449/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Nov 7 2017
Should be fixed now.
,
Nov 8 2017
Thanks for the quick turnaround on this. Note that NewTabPageTest.testRender appears to be flaky for other reasons (too?). Filed https://bugs.chromium.org/p/chromium/issues/detail?id=782311 for that.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b96ffcedaa9339381fe8189b92baf257970ee39 commit 7b96ffcedaa9339381fe8189b92baf257970ee39 Author: Donn Denman <donnd@google.com> Date: Tue Nov 14 19:15:04 2017 [TTS] Update an assert in CSearchTabHelper Update an overly aggressive assert recently landed in ContextualSearchTabHelper when reparenting. This is causing an existing test to be very flaky (NewTabPageTest#testRender). BUG=775813, 778540, 782324 TBR=donnd@google.com (cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449) Change-Id: I041742701820dc3899378515fe37a6be44a66d7a Reviewed-on: https://chromium-review.googlesource.com/757661 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#514651} Reviewed-on: https://chromium-review.googlesource.com/769297 Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#487} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/7b96ffcedaa9339381fe8189b92baf257970ee39/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da78e5c6938c0b3b40e89e0aa385c2254c0d7ea8 commit da78e5c6938c0b3b40e89e0aa385c2254c0d7ea8 Author: Claude Masso <cmasso@chromium.org> Date: Tue Nov 14 23:33:41 2017 Revert "[TTS] Update an assert in CSearchTabHelper" This reverts commit 7b96ffcedaa9339381fe8189b92baf257970ee39. Reason for revert: <INSERT REASONING HERE> Original change's description: > [TTS] Update an assert in CSearchTabHelper > > Update an overly aggressive assert recently landed in > ContextualSearchTabHelper when reparenting. This is causing an > existing test to be very flaky (NewTabPageTest#testRender). > > BUG=775813, 778540, 782324 > TBR=donnd@google.com > > (cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449) > > Change-Id: I041742701820dc3899378515fe37a6be44a66d7a > Reviewed-on: https://chromium-review.googlesource.com/757661 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#514651} > Reviewed-on: https://chromium-review.googlesource.com/769297 > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/branch-heads/3239@{#487} > Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: I1cff30dc13f2eb8182e698f249078583dbe513b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775813, 778540, 782324 Reviewed-on: https://chromium-review.googlesource.com/770070 Reviewed-by: Claude Masso <cmasso@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#497} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/da78e5c6938c0b3b40e89e0aa385c2254c0d7ea8/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19bc0ac039a6ad3dd396b3a4b2ea264fdeaa6649 commit 19bc0ac039a6ad3dd396b3a4b2ea264fdeaa6649 Author: Donn Denman <donnd@google.com> Date: Thu Nov 16 00:51:02 2017 Reland "[TTS] Update an assert in CSearchTabHelper" This is a reland of 7b96ffcedaa9339381fe8189b92baf257970ee39 Original change's description: > [TTS] Update an assert in CSearchTabHelper > > Update an overly aggressive assert recently landed in > ContextualSearchTabHelper when reparenting. This is causing an > existing test to be very flaky (NewTabPageTest#testRender). > > BUG=775813, 778540, 782324 > TBR=donnd@google.com > > (cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449) > > Change-Id: I041742701820dc3899378515fe37a6be44a66d7a > Reviewed-on: https://chromium-review.googlesource.com/757661 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#514651} > Reviewed-on: https://chromium-review.googlesource.com/769297 > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/branch-heads/3239@{#487} > Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} Bug: 775813, 778540, 782324 Change-Id: I29a275528f74d83395d5103a8d4fb1346010cf70 Reviewed-on: https://chromium-review.googlesource.com/773638 Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#512} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/19bc0ac039a6ad3dd396b3a4b2ea264fdeaa6649/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jbudorick@chromium.org
, Nov 7 2017