New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782311 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

NewTabPageTest.testRender flaky because of the cursor

Project Member Reported by jbudorick@chromium.org, Nov 7 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5bd3ec4e75a45b667f3d4176cce3357ea8ef833

commit e5bd3ec4e75a45b667f3d4176cce3357ea8ef833
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Nov 10 11:46:40 2017

📷 Sanitize the New Tab Page Views before rendering.

The blinking cursor in EditTexts should never be enabled for render
tests. It doesn't add anything to the appearance and makes the tests
flaky (as the appearance changes over time). This CL creates a sanitize
method on RenderTestRule that can be used to strip such features from
a View before it is rendered.

Bug:  782311 
Change-Id: I9d862c99814b30e78ce00f0ba254fefa0f586030
Reviewed-on: https://chromium-review.googlesource.com/758780
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515528}
[modify] https://crrev.com/e5bd3ec4e75a45b667f3d4176cce3357ea8ef833/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/e5bd3ec4e75a45b667f3d4176cce3357ea8ef833/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java

Comment 2 by peconn@chromium.org, Nov 10 2017

Status: Fixed (was: Untriaged)
The cursor shouldn't really be visible in the omnibox/fakebox, and especially not when the keyboard isn't visible on screen. However, it seems that disabling blinking cursors for Views we are able to render is a decent precaution against flakiness, so adding a sanitize method it a good idea.

Sign in to add a comment