As part of the effort of removing UtilityprocessHost, WiFiCredentialsGetter should be servicified and UtilityProcessMojoClient should be removed from networking_private_credentials_getter.cc.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70d43224ecc21afd5b24f57a44f67155e9c14da commit d70d43224ecc21afd5b24f57a44f67155e9c14da Author: Jay Civelli <jcivelli@chromium.org> Date: Tue Nov 14 19:38:06 2017 Servicifying WinWifiCredentialsGetter As part of the effort to deprecate UtilityProcessMojoClient, convert WinWifiCredentialsGetter to a mojo service. To access WinWifiCredentialsGetter clients now have to pass a connector to the service manager. WinWifiCredentialsGetter is OS_WIN only, requires UAC elevation, and is used by the chrome extensions private networking API. Bug: 782300 Change-Id: I6b536b3359509ebc46b194f1336964b711e39e21 Reviewed-on: https://chromium-review.googlesource.com/756355 Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#516390} [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/app/BUILD.gn [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/DEPS [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/chrome_content_utility_manifest_overlay.json [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/common/extensions/BUILD.gn [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/BUILD.gn [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/DEPS [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/OWNERS [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/manifest.json [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/public/interfaces/BUILD.gn [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/public/interfaces/OWNERS [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/public/interfaces/constants.mojom [rename] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/public/interfaces/wifi_credentials_getter.mojom [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/wifi_credentials_getter.cc [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/wifi_credentials_getter.h [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/wifi_util_win_service.cc [add] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/services/wifi_util_win/wifi_util_win_service.h [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/utility/BUILD.gn [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/utility/DEPS [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/d70d43224ecc21afd5b24f57a44f67155e9c14da/chrome/utility/extensions/extensions_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/315aef596e9bf75d9af55a4a190dcbc85b38d1bc commit 315aef596e9bf75d9af55a4a190dcbc85b38d1bc Author: Luna Lu <loonybear@chromium.org> Date: Tue Nov 14 20:17:38 2017 Revert "Servicifying WinWifiCredentialsGetter" This reverts commit d70d43224ecc21afd5b24f57a44f67155e9c14da. Reason for revert: Revert cause it broke the built https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/23851 Original change's description: > Servicifying WinWifiCredentialsGetter > > As part of the effort to deprecate UtilityProcessMojoClient, convert > WinWifiCredentialsGetter to a mojo service. > > To access WinWifiCredentialsGetter clients now have to pass a connector > to the service manager. > > WinWifiCredentialsGetter is OS_WIN only, requires UAC elevation, and > is used by the chrome extensions private networking API. > > Bug: 782300 > Change-Id: I6b536b3359509ebc46b194f1336964b711e39e21 > Reviewed-on: https://chromium-review.googlesource.com/756355 > Reviewed-by: Misha Efimov <mef@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516390} TBR=stevenjb@chromium.org,thestig@chromium.org,jcivelli@chromium.org,mef@chromium.org,noel@chromium.org,tsepez@chromium.org Change-Id: Ic696dee9f75c3de3b731cbfbc253e70ff10abc5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782300 Reviewed-on: https://chromium-review.googlesource.com/769547 Reviewed-by: Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#516403} [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/app/BUILD.gn [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/DEPS [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/chrome_content_utility_manifest_overlay.json [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/common/extensions/BUILD.gn [rename] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/common/extensions/wifi_credentials_getter.mojom [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/BUILD.gn [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/DEPS [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/OWNERS [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/manifest.json [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/public/interfaces/BUILD.gn [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/public/interfaces/OWNERS [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/public/interfaces/constants.mojom [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/wifi_credentials_getter.cc [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/wifi_credentials_getter.h [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/wifi_util_win_service.cc [delete] https://crrev.com/58c4e4062423b594f9b6674455dac38d5bdd1825/chrome/services/wifi_util_win/wifi_util_win_service.h [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/utility/BUILD.gn [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/utility/DEPS [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/315aef596e9bf75d9af55a4a190dcbc85b38d1bc/chrome/utility/extensions/extensions_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/446d1db3fe59bf95b305143ba7b773f83ac6bfb5 commit 446d1db3fe59bf95b305143ba7b773f83ac6bfb5 Author: Jay Civelli <jcivelli@chromium.org> Date: Wed Nov 15 00:19:26 2017 Reland "Servicifying WinWifiCredentialsGetter" Removed a left over include to a header file the CL removes. This reverts commit 315aef596e9bf75d9af55a4a190dcbc85b38d1bc. Bug: 782300 Tbr: noel@chromium.org, mef@chromium.org, thestig@chromium.org Tbr: stevenjb@chromium.org, tsepez@chromium.org Change-Id: Ia72e9aec8b214bb0c64f316f5d20a0b30af86243 Reviewed-on: https://chromium-review.googlesource.com/769854 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#516517} [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/app/BUILD.gn [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/DEPS [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/chrome_content_utility_manifest_overlay.json [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/common/extensions/BUILD.gn [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/BUILD.gn [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/DEPS [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/OWNERS [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/manifest.json [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/public/interfaces/BUILD.gn [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/public/interfaces/OWNERS [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/public/interfaces/constants.mojom [rename] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/public/interfaces/wifi_credentials_getter.mojom [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/wifi_credentials_getter.cc [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/wifi_credentials_getter.h [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/wifi_util_win_service.cc [add] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/services/wifi_util_win/wifi_util_win_service.h [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/utility/BUILD.gn [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/utility/DEPS [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/446d1db3fe59bf95b305143ba7b773f83ac6bfb5/chrome/utility/extensions/extensions_handler.cc
Comment 1 by bugdroid1@chromium.org
, Nov 14 2017