src/net/spdy/chromium/spdy_session.cc missing xref info and links |
||
Issue descriptionOpen this link: https://cs.chromium.org/chromium/src/net/spdy/chromium/spdy_session.cc?type=cs&sq=package:chromium&l=3060 Notice that there are no links in the code. spdy_session.h seems to be able to reference definitions in spdy_session.cc. "Call Hierarchy" seems to be missing referrences from spdy_session.cc also: 1. Open https://cs.chromium.org/chromium/src/net/socket/client_socket_pool.h?type=cs&q=AddHigherLayeredPool&sq=package:chromium&l=57 2. Click AddHigherLayeredPool 3. In the "Call Hierarchy" notice how it misses this spdy_session.cc call: https://cs.chromium.org/chromium/src/net/spdy/chromium/spdy_session.cc?type=cs&q=AddHigherLayeredPool&sq=package:chromium&l=857
,
Dec 5 2017
It doesn't miss it. There are two methods named AddHigherLayeredPool. One of them (the one you click on in step 1) is a method on LowerLayeredPool. The other (the one being called by spdy_session.cc in step 3) is a method on ClientSocketHandle. Codesearch correctly determines that these are different methods on different classes, and doesn't confuse the XRefs. |
||
►
Sign in to add a comment |
||
Comment 1 by emso@chromium.org
, Nov 9 2017Owner: flyboy@chromium.org
Status: Assigned (was: Untriaged)