New issue
Advanced search Search tips

Issue 782287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Implement manual password filling on iOS

Project Member Reported by vasi...@chromium.org, Nov 7 2017

Issue description

Chrome on iOS should support a fallback for password filling. As a version 1 we should provide a link to the password list from the keyboard accessory.
 
s6EdRX1aum9.png
101 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8539ab55438704d7cfa1959574648963e20ad72

commit d8539ab55438704d7cfa1959574648963e20ad72
Author: vasilii <vasilii@chromium.org>
Date: Thu Nov 09 13:37:39 2017

Pass element type to the form suggestion providers on iOS.

The keyboard accessory needs to show "Show passwords" button for the password fields.
Therefore, it should know the type of the focused element. The CL passes this info from form.js to PasswordController.

Bug:  782287 ,547122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifbfc12ce949fba7a6861bbc5b1cda2804180937e
Reviewed-on: https://chromium-review.googlesource.com/757361
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515158}
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/components/autofill/ios/browser/form_suggestion_provider.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/autofill/form_input_accessory_view_controller.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/autofill/form_suggestion_controller.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/autofill/form_suggestion_controller.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/ssl/insecure_input_tab_helper.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/BUILD.gn
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/crw_test_web_state_observer.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/test_web_state.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/test_web_state_observer.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/test/fakes/test_web_state_observer_util.h
[add] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/web_state/form_activity_params.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/web_state/web_state_observer.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/public/web_state/web_state_observer_bridge.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/BUILD.gn
[add] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/form_activity_params.cc
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/js/resources/form.js
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/web_state_observer_bridge.mm
[modify] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/ios/web/web_state/web_state_observer_bridge_unittest.mm

Simulator Screen Shot - iPhone 8 Plus - 2018-02-16 at 13.33.51.png
289 KB View Download
Simulator Screen Shot - iPhone 8 Plus - 2018-02-16 at 13.36.08.png
305 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a546ed3dd2df63b75781c82db85d0640ec7d5c66

commit a546ed3dd2df63b75781c82db85d0640ec7d5c66
Author: vasilii <vasilii@chromium.org>
Date: Mon Feb 19 19:11:42 2018

Implement "Show all passwords" in the keyboard accessory on iOS.

The new button appears when a password field is focused or when other password suggestions are displayed. The latter may happen when a username field is focused.
Click on the button opens the list of passwords. User can find the relevant one there and copy it.

Bug:  782287 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I199851bd28c76ac4b626f8a1ff81a86e8479a51e
Reviewed-on: https://chromium-review.googlesource.com/816479
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537679}
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/a546ed3dd2df63b75781c82db85d0640ec7d5c66/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95a82a9b77511c2b9108741d8ff33721e09c5a1b

commit 95a82a9b77511c2b9108741d8ff33721e09c5a1b
Author: vasilii <vasilii@chromium.org>
Date: Mon Feb 26 10:33:13 2018

Increase test coverage of "Show All" manual fallback for passwords.

Bug:  782287 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I534f2b892efe8d2af08bbea6ee724c38509a55c9
Reviewed-on: https://chromium-review.googlesource.com/926581
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539102}
[modify] https://crrev.com/95a82a9b77511c2b9108741d8ff33721e09c5a1b/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/95a82a9b77511c2b9108741d8ff33721e09c5a1b/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/95a82a9b77511c2b9108741d8ff33721e09c5a1b/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm

Status: Fixed (was: Started)

Sign in to add a comment