[NTP] No-Google Search Engine's NTP Tiles are cut at the top/middle when the window is shrinked to a small state |
||||||||||
Issue descriptionChrome Version: Canary Version 64.0.3261.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Use a No-Google Search Engine, e.g. Yahoo (2) Open a NTP (3) Shrink the window to very small (4) Scroll up/down What is the expected result? The tiles should either disappear at all or they should not be cut at the top/middle. What happens instead? Looks strange. Please see the screencast. I see this on Mac, but it should probably be OS=All Thanks Mehmet
,
Nov 7 2017
Damn, CSS is hard... yup, this'll be on all desktop OSes.
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07b5d696bd20242484d791d0e696d96a4dbf2e86 commit 07b5d696bd20242484d791d0e696d96a4dbf2e86 Author: Marc Treib <treib@chromium.org> Date: Wed Nov 08 14:43:28 2017 Local NTP: Fix layout for non-Google pages This was broken in crrev.com/c/726079. Bug: 782285 , 755761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I725b6a405ab8bec4cb070b532f15401322a52b92 Reviewed-on: https://chromium-review.googlesource.com/758371 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#514827} [modify] https://crrev.com/07b5d696bd20242484d791d0e696d96a4dbf2e86/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/07b5d696bd20242484d791d0e696d96a4dbf2e86/chrome/browser/resources/local_ntp/most_visited_single.css
,
Nov 8 2017
,
Nov 8 2017
Thank you very much. I can verify it earliest on Saturday and will give you then a feedback.
,
Nov 8 2017
No worries, there's no particular hurry!
,
Nov 9 2017
Tested this issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest canary #64.0.3263.0 by following steps mentioned in the original comment. Behavior observed on Win & Linux: ----------------------------------- After minimizing the screen on chrome #64.0.3261.0 unable to scroll the page and not seen any cuts in the NTP tiles, on chrome #64.0.3263.0 after minimizing the screen the tiles disappears. Behavior observed on Mac: -------------------------- After minimizing the screen on chrome #64.0.3261.0 able to scroll the page and observed the cuts on top in the NTP tiles, on chrome #64.0.3263.0 after minimizing the screen the tiles disappears and no cuts are observed. Note: Unable to verify this issue on Mac Signed builds due to build failure, so verified on unsigned builds. treib@ Could you please confirm and let us know the above observations are the expected behaviors for this issue. Thanks!
,
Nov 9 2017
Thanks! Yes, that looks correct: The tiles disappear when they don't fit on the screen. Signed or unsigned build should make no difference whatsoever, so all good!
,
Nov 9 2017
Adding TE-Verified label for M64 as per comment #10.
,
Nov 11 2017
Thanks, looks good to me in Chrome Canary 64.0.3265.0 on macOS 10.12.6. Non-Google NTP tiles are no longer clipped at the top. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by meh...@chromium.org
, Nov 7 2017