New issue
Advanced search Search tips

Issue 782282 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

AndroidOverlay needs to dismiss the dialog during onSurfaceDestroyed

Project Member Reported by liber...@chromium.org, Nov 7 2017

Issue description

cast has issues if we don't.  leaves surfaces around.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3451ba871c58199f1fbd5e1e9562cb61f71e259c

commit 3451ba871c58199f1fbd5e1e9562cb61f71e259c
Author: liberato@chromium.org <liberato@chromium.org>
Date: Thu Nov 09 19:15:32 2017

Call dismiss() on overlay Dialog for onSurfaceDestroyed.

Previously, DialogOverlayCore didn't receive a release() call from
DSImpl, since DSImpl drops the reference to DSCore immediately
after notifying the client of surface destruction.  This caused
problems on some cast devices, where the overlay wasn't being
deleted properly.

Now, DSCore calls release() synchronously after waiting for
DSImpl to close the overlay.  This keeps the dismiss() call sync
with respect to onSurfaceDestroyed.  Even if DSImpl did call
DSCore.release(), it would be after onSurfaceDestroyed completed.

Bug:  782282 
Change-Id: I25f98643063545e0a44ccb7ab04145e7c6728d3a
Reviewed-on: https://chromium-review.googlesource.com/756932
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515234}
[modify] https://crrev.com/3451ba871c58199f1fbd5e1e9562cb61f71e259c/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayCore.java
[modify] https://crrev.com/3451ba871c58199f1fbd5e1e9562cb61f71e259c/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayImpl.java
[modify] https://crrev.com/3451ba871c58199f1fbd5e1e9562cb61f71e259c/content/public/android/java/src/org/chromium/content/browser/androidoverlay/ThreadHoppingHost.java
[modify] https://crrev.com/3451ba871c58199f1fbd5e1e9562cb61f71e259c/content/public/android/junit/src/org/chromium/content/browser/androidoverlay/DialogOverlayCoreTest.java

Status: Fixed (was: Started)

Sign in to add a comment