New issue
Advanced search Search tips

Issue 782281 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 782751
issue 785073
issue 785081
issue 785472
issue 786449

Blocking:
issue 716235
issue 780311
issue 781873
issue 784609
issue 785002



Sign in to add a comment

Roll Clang again

Project Member Reported by h...@chromium.org, Nov 7 2017

Issue description

This is a tracking bug for the next Clang roll.

Need r317517 for  Issue 781873 .
 

Comment 1 by h...@chromium.org, Nov 8 2017

rnk, the ToT bots look mostly green with a few spots of red. Can you file blockers for anything you think we need to fix before rolling?

Comment 2 by r...@chromium.org, Nov 8 2017

An ios bot looks red with some kind of compiler bug:
https://build.chromium.org/p/chromium.clang/builders/ToTiOS/builds/250

Other than that, I think everything is pre-existing and non-blocking:
- ASan tester bots red, on it
- 32-bit LLD bots red but much improved after Bob's safeseh fix
- ThinLTO bots red with disk space issues

Comment 3 by r...@chromium.org, Nov 8 2017

I suspect r317579 for the iOS failure, as it is call-frame-info related.

Comment 4 by r...@chromium.org, Nov 8 2017

Blockedon: 782751

Comment 5 by r...@chromium.org, Nov 8 2017

We also have to look out for https://reviews.llvm.org/D39490, which broke the build on Android and I reverted it, but we haven't figured out why it broke and it may reland soon.

Comment 6 by r...@chromium.org, Nov 9 2017

We determined that the breakage from https://reviews.llvm.org/D39490 was caused by Chrome's use of the R12B version of the NDK, which is from June 2016. The author reverted their patch and will re-land with an autoconf-style test for sched_getaffinity to work around the problem.
r318078 contains TSAN signal handlers for issue 716235
r318078 will enable signal handlers in both MSan and TSan. Uptil now signal handlers like sigill, sigabrt, sigfpe only worked in ASan, UBsan, see crbug.com/716235
Cc: och...@chromium.org infe...@chromium.org

Comment 10 by r...@chromium.org, Nov 14 2017

Blocking: 784609

Comment 11 by h...@chromium.org, Nov 14 2017

Owner: h...@chromium.org
The plan is to get the roll in this week.

r318199 for -finstrument-functions-after-inlining

Comment 12 by h...@chromium.org, Nov 14 2017

Status: Assigned (was: Available)

Comment 13 by r...@chromium.org, Nov 14 2017

Let's try to pick up r318203 if we can for issue 784609, which is about gfx::Size optimized debug info.

Comment 14 by h...@chromium.org, Nov 15 2017

Blockedon: 785073

Comment 15 by h...@chromium.org, Nov 15 2017

Blockedon: 785081

Comment 16 by h...@chromium.org, Nov 15 2017

Blocking: 780311

Comment 17 by h...@chromium.org, Nov 15 2017

Status: Started (was: Assigned)
Roll attempt: https://chromium-review.googlesource.com/c/chromium/src/+/772842

Comment 18 by h...@chromium.org, Nov 16 2017

Blockedon: 785472

Comment 19 by h...@chromium.org, Nov 16 2017

Need r318369 for Android ASan.
Packaging that here: https://chromium-review.googlesource.com/#/c/chromium/src/+/774119
Blocking: 716235
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbc676c19bdb73cc9720bf3d51ca6932577d6517

commit dbc676c19bdb73cc9720bf3d51ca6932577d6517
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Nov 17 03:11:26 2017

Roll clang 317263:318369.

Bug:  782281 

Change-Id: Ia7f42af4cc63771dcb6d83f6a0fa0f98e2602c13
Reviewed-on: https://chromium-review.googlesource.com/774119
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517269}
[modify] https://crrev.com/dbc676c19bdb73cc9720bf3d51ca6932577d6517/tools/clang/scripts/update.py

Comment 22 by h...@chromium.org, Nov 17 2017

The roll landed last night. We're currently investigating whether it broke ASan on Android: Issue 786449
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f810ef4a0a7693fa3c22b5f1b4e5e4c0b95ffce1

commit f810ef4a0a7693fa3c22b5f1b4e5e4c0b95ffce1
Author: Hans Wennborg <hans@chromium.org>
Date: Sat Nov 18 00:34:16 2017

Revert "Roll clang 317263:318369."

This reverts commit dbc676c19bdb73cc9720bf3d51ca6932577d6517.

Reason for revert: This broke Android ASan.

Original change's description:
> Roll clang 317263:318369.
> 
> Bug:  782281 
> 
> Change-Id: Ia7f42af4cc63771dcb6d83f6a0fa0f98e2602c13
> Reviewed-on: https://chromium-review.googlesource.com/774119
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517269}

TBR=eugenis@chromium.org,hans@chromium.org,rnk@chromium.org

Change-Id: Ib4ff2dd46d05a386e286713f49722cd826b26ca4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  782281 ,786449
Reviewed-on: https://chromium-review.googlesource.com/777483
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517632}
[modify] https://crrev.com/f810ef4a0a7693fa3c22b5f1b4e5e4c0b95ffce1/tools/clang/scripts/update.py

Comment 24 by h...@chromium.org, Nov 18 2017

Blockedon: 786449
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2b13fb6670ed08c846bc90f0cbe894af344250

commit cb2b13fb6670ed08c846bc90f0cbe894af344250
Author: Hans Wennborg <hans@chromium.org>
Date: Sat Nov 18 19:07:39 2017

Roll clang 317263:318575.

Bug:  782281 

Change-Id: Ifad82da68a7356bd6463fd9b944f796a5a3f798c
Reviewed-on: https://chromium-review.googlesource.com/777640
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517719}
[modify] https://crrev.com/cb2b13fb6670ed08c846bc90f0cbe894af344250/tools/clang/scripts/update.py

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2637a04e9f9c8f01b3898db9984e4ee54a5c3956

commit 2637a04e9f9c8f01b3898db9984e4ee54a5c3956
Author: Hans Wennborg <hans@chromium.org>
Date: Sat Nov 18 19:25:14 2017

Revert "Roll clang 317263:318575."

This reverts commit cb2b13fb6670ed08c846bc90f0cbe894af344250.

Reason for revert: It broke the build due to an enhanced warning, e.g.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/24153

../../third_party/ffmpeg/libavcodec/bitstream.c:169:5: error: if statement has empty body [-Werror,-Wempty-body]
    ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size);
    ^
../../third_party/ffmpeg/libavutil/internal.h:276:80: note: expanded from macro 'ff_dlog'
#   define ff_dlog(ctx, ...) do { if (0) av_log(ctx, AV_LOG_DEBUG, __VA_ARGS__); } while (0)

I believe this is fixed in a later revision of Clang that our ToT bots had already picked up, which is why I didn't see it.

Original change's description:
> Roll clang 317263:318575.
> 
> Bug:  782281 
> 
> Change-Id: Ifad82da68a7356bd6463fd9b944f796a5a3f798c
> Reviewed-on: https://chromium-review.googlesource.com/777640
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517719}

TBR=eugenis@chromium.org,hans@chromium.org,rnk@chromium.org,pcc@chromium.org

Change-Id: I922f3b1f30b7119fa17d257a1ab29339ac8576ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  782281 
Reviewed-on: https://chromium-review.googlesource.com/778281
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517720}
[modify] https://crrev.com/2637a04e9f9c8f01b3898db9984e4ee54a5c3956/tools/clang/scripts/update.py

Comment 28 by h...@chromium.org, Nov 18 2017

I thought the -Wempty-body should be fixed with r318556 :-/
Project Member

Comment 30 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85023f0253e73844e0bdf00f134ddbeeae057aed

commit 85023f0253e73844e0bdf00f134ddbeeae057aed
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Nov 21 15:27:34 2017

Roll clang 317263:318667.

Bug:  782281 
Change-Id: I50b16ab96bf34f5dc4d6ed4cfbebe6fe9df84a37
Reviewed-on: https://chromium-review.googlesource.com/779703
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518258}
[modify] https://crrev.com/85023f0253e73844e0bdf00f134ddbeeae057aed/tools/clang/scripts/update.py

Comment 31 by r...@chromium.org, Nov 21 2017

Blocking: 785002

Comment 32 by h...@chromium.org, Nov 22 2017

Status: Fixed (was: Started)
This appears to be sticking.

(Next roll will be tracked by  Issue 787920 )

Sign in to add a comment