HTMLCanvasElement::ToImageData() is not color managed |
||
Issue descriptionHTMLCanvasElement::ToImageData() is not color manged. It should be. Proper layout tests should be added too. We also need to check if any other member of HTMLCanvasElement has the same problem.
,
Dec 7 2017
After https://chromium-review.googlesource.com/c/chromium/src/+/809097 is landed, there is no HTMLCanvasElement::ToImageData() API any more.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84 commit e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Wed Feb 07 18:56:39 2018 HTMLCanvasElement: Add color management to toDataURL() and toBlob() This change adds color management support to HTMLCanvasElement::toDataURL() and HTMLCanvasElement::toBlob(). This is a retry after chromium-review.googlesource.com/c/chromium/src/+/771541 got abandoned because ImageData was removed from toBlob/toDataURL code path. Bug: 782278 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4018aa4ca9ffc53d5c5671c804964dd0ce58ee68 Reviewed-on: https://chromium-review.googlesource.com/824462 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#535081} [modify] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/audits/get-encoded-response-expected.txt [add] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorManaged-toBlob-toDataURL.html [modify] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextHost.cpp [modify] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp [modify] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/Source/platform/graphics/ImageDataBuffer.cpp [modify] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/Source/platform/graphics/ImageDataBuffer.h [modify] https://crrev.com/e8f1dd346a7c94d5d1bed16a3dd1b0570de73f84/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by zakerinasab@chromium.org
, Nov 27 2017