New issue
Advanced search Search tips

Issue 782269 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 783776
issue 763285



Sign in to add a comment

Remove GlobalWebStateEventTracker

Project Member Reported by sdefresne@chromium.org, Nov 7 2017

Issue description

My plan would be to:
1. change GlobalWebStateObserver to be informed of WebState creation
2. change all observers to directly observe the WebStates
3. remove all other method from GlobalWebStateObserver
4. convert observers to tab helpers
 
Blocking: 783776
Cc: mahmadi@chromium.org

Comment 3 by pkl@chromium.org, Nov 20 2017

Components: Internals
Labels: -Type-Bug Type-Task
This looks like a tasking tracking bug as well.
Blocking: 763285
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c82006414aa7d03f2b8034b4e0de2db3094a7233

commit c82006414aa7d03f2b8034b4e0de2db3094a7233
Author: Eugene But <eugenebut@google.com>
Date: Fri Dec 07 19:25:53 2018

IOSChromeLocalSessionEventRouter does not subclass from GlobalWebStateObserver.

IOSChromeLocalSessionEventRouter will observe multiple WebState objects
without using deprecated GlobalWebStateObserver.

Also removed browser state check in OnWebStateChange. This check was needed
because each WSO callback was called for both BrowserState objects. So the
router had to check if the call belongs to correct browser state. After this
CL there are no extra calls, hence no need for check.

Bug: 910894, 782269,  720786 
Change-Id: Ie25ae62efea9edd4a981800d1a43b6ef28b35b14
Reviewed-on: https://chromium-review.googlesource.com/c/1359863
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614779}
[modify] https://crrev.com/c82006414aa7d03f2b8034b4e0de2db3094a7233/ios/chrome/browser/sync/BUILD.gn
[rename] https://crrev.com/c82006414aa7d03f2b8034b4e0de2db3094a7233/ios/chrome/browser/sync/session_sync_service_factory.mm
[modify] https://crrev.com/c82006414aa7d03f2b8034b4e0de2db3094a7233/ios/chrome/browser/sync/sessions/BUILD.gn
[modify] https://crrev.com/c82006414aa7d03f2b8034b4e0de2db3094a7233/ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.h
[modify] https://crrev.com/c82006414aa7d03f2b8034b4e0de2db3094a7233/ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm

Sign in to add a comment