New issue
Advanced search Search tips

Issue 782240 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Skip non-focusable fields in phone number rationalization.

Project Member Reported by wuandy@chromium.org, Nov 7 2017

Issue description

Current phone number rationalization does not distinguish between
focusable and non-focusable fields. If a form has a hidden number field
then a visible number field, the first one will be considered as the 
first complete number field, and the second field is not filled 
automatically as a result.

We should skip the non-focusable fields in the rationalization process.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4896c0daaf2b848fc829868a679fe17530f82de1

commit 4896c0daaf2b848fc829868a679fe17530f82de1
Author: Hui(Andy) Wu <wuandy@chromium.org>
Date: Mon Nov 13 17:48:10 2017

[Autofill] Skip non-focusable fields in phone number rationalization.

Current phone number rationalization does not distinguish between
focusable and non-focusable fields. If a form has a hidden number field
then a visible number field, the first one will be considered as the
first complete number field, and the second field is not filled
automatically as a result.

We should skip the non-focusable fields in the rationalization process.

Bug:  782240 
Change-Id: I71eeb613d3127770b2bf0a0bb120c7cca3282728
Reviewed-on: https://chromium-review.googlesource.com/757217
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515977}
[modify] https://crrev.com/4896c0daaf2b848fc829868a679fe17530f82de1/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/4896c0daaf2b848fc829868a679fe17530f82de1/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/4896c0daaf2b848fc829868a679fe17530f82de1/components/autofill/core/common/form_field_data.cc

Comment 2 by wuandy@chromium.org, Nov 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment