DataUse.PageTransition.UserTraffic is Overflowing |
|||||
Issue descriptionThe DataUse.PageTransition.UserTraffic sparse histogram is being incremented so frequently that it sometimes overflows the 31-bit sample count and rolls negative. This happens because it's incremented by the received_byte count. https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=7&histograms=DataUse.PageTransition.UserTraffic%2CUMA.NegativeSamples.Histogram%2CUMA.NegativeSamples.Reason&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Here's how I fixed a similar problem by counting KiB: https://chromium-review.googlesource.com/c/chromium/src/+/729143
,
Feb 7 2018
I've just landed https://chromium-review.googlesource.com/c/chromium/src/+/905148 Which adds AddScaled(), AddKilo(), and AddKiB() methods in the base histogram class to increment the count by a scaled amount. Precision is lost but accuracy is maintained. You can't just change the Add* method used, though; the name of the histogram needs to be changed (add a "K" suffix?) to avoid confusion.
,
Mar 26 2018
,
May 18 2018
,
May 18 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1055623 may be of use to you as an alternative to AddScaled() et al, especially if this is called frequently. Once it's submitted, anyway.
,
May 23 2018
Following fix converts these metrics to its KB version using AddKiB https://bugs.chromium.org/p/chromium/issues/detail?id=782231 Thanks bcwhite@ SG. That will be extremely useful. I will wait until your CL lands. https://chromium-review.googlesource.com/c/chromium/src/+/1066406
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/451909dfcc9414fb868867f83831940994606a4e commit 451909dfcc9414fb868867f83831940994606a4e Author: rajendrant <rajendrant@chromium.org> Date: Fri Jun 22 18:19:55 2018 Convert contenttype data use metrics to use ScaledLinearHistogram Bug: 782233 Change-Id: I4e0e8d06dd8d2be5613fd221a541fec67a9857c2 Reviewed-on: https://chromium-review.googlesource.com/1111471 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#569697} [modify] https://crrev.com/451909dfcc9414fb868867f83831940994606a4e/components/data_use_measurement/core/data_use_measurement.cc [modify] https://crrev.com/451909dfcc9414fb868867f83831940994606a4e/components/data_use_measurement/core/data_use_user_data.h
,
Jun 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bcwh...@chromium.org
, Nov 7 2017