DataUse.ContentType.Services is Overflowing |
||||||
Issue descriptionThe DataUse.ContentType.Services sparse histogram is being incremented so frequently that it sometimes overflows the 31-bit sample count and rolls negative. This happens because it's incremented by the byte count. https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=7&histograms=DataUse.ContentType.Services%2CUMA.NegativeSamples.Histogram%2CUMA.NegativeSamples.Reason&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Here's how I fixed a similar problem by counting KiB: https://chromium-review.googlesource.com/c/chromium/src/+/729143
,
Feb 6 2018
So is DataUse.BackgroundToDataRecievedPerByte.User
,
Feb 7 2018
rajendrant seems to have left (absent >30days)
,
Feb 7 2018
,
Feb 7 2018
I've just landed https://chromium-review.googlesource.com/c/chromium/src/+/905148 Which adds AddScaled(), AddKilo(), and AddKiB() methods in the base histogram class to increment the count by a scaled amount. Precision is lost but accuracy is maintained. You can't just change the Add* method used, though; the name of the histogram needs to be changed (add a "K" suffix?) to avoid confusion.
,
Mar 26 2018
Raj, please take a look at fixing this uma call you added.
,
May 18 2018
,
May 18 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1055623 may be of use to you as an alternative to AddScaled() et al, especially if this is called frequently. Once it's submitted, anyway.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd commit 84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd Author: rajendrant <rajendrant@chromium.org> Date: Wed May 23 20:41:16 2018 Fix overflows in contenttype and pagetransition metrics Converting the DataUse.ContentType.* and DataUse.PageTransition.* metrics to be recorded as KB instead of bytes. This will fix the overflows. Bug: 782231 Change-Id: I1144178a769b481b12d093674b3ba59fda55c3d8 Reviewed-on: https://chromium-review.googlesource.com/1066406 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#561241} [modify] https://crrev.com/84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd/components/data_use_measurement/content/content_url_request_classifier.cc [modify] https://crrev.com/84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd/components/data_use_measurement/core/data_use_measurement.cc [modify] https://crrev.com/84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd/components/data_use_measurement/core/data_use_measurement.h [modify] https://crrev.com/84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd/components/data_use_measurement/core/data_use_measurement_unittest.cc [modify] https://crrev.com/84bb8a0b6a87c2c2e64d124aafe1a0d3da2a85cd/tools/metrics/histograms/histograms.xml
,
May 23 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bcwh...@chromium.org
, Nov 7 2017