Issue 782219 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	yamaguchi@chromium.org
Closed:	Nov 2017
Components:	Platform>Apps>FileManager
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug

Blocking:
issue 690217
issue 780688

User is asked to choose Zip Archiver or Zip Unpacker after enabling Zip Archiver

Project Member Reported by yamaguchi@chromium.org, Nov 7 2017

Issue description

Chrome Version: 64.*

When we turn on the --enable-zip-archiver-unpacker flag ON, majority of users will be asked to choose Zip Unpacker or Zip Archiver when clicking the zip file for the first time.

Steps To Reproduce:
(1) Turn on enable-zip-archiver-unpacker flag.
(2) Open a zip file.

Expected Result:
The file is mounted (by Zip Archiver)

Actual Result:
User is asked to choose either Zip Archiver or Zip Unpacker.
--------------------------------------------
Open with... 
  Open with Zip Archiver (default)
  Open with ZIP unpacker
--------------------------------------------


IIUC, this happens to those users who had not installed any extension that handles zip file before.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb48af71329f7a2a46a27f933337e37ea9506da

commit 0bb48af71329f7a2a46a27f933337e37ea9506da
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Nov 08 07:15:24 2017

Hide Zip Unpacker when Zip Archiver is turned on by the flag.

The flag hides Zip Archiver when turned off, however, when it is turned
on, the both extensions appears as the candidate of file task.
If user had never executed both before, user will be asked to choose
one when opening a zip file at the first time. It typically happens
after newly setting up an account to a device.
This change prevents such issue by hiding Zip Unpacker.

Bug:  782219 
Test: browser_tests --gtest_filter=FileManagerJsTest*.FileTasks
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I27d0e4633749123b40915897f9f3487312765045
Reviewed-on: https://chromium-review.googlesource.com/757883
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514773}
[modify] https://crrev.com/0bb48af71329f7a2a46a27f933337e37ea9506da/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/0bb48af71329f7a2a46a27f933337e37ea9506da/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js