Local NTP OGB: "position: fixed" can cause overlap with logo |
||||
Issue descriptionCurrently the OGB on the local NTP is positioned as "fixed", so it stays in place even when scrolling. This means that for small window sizes, it can end up overlapping the logo (or doodle). Probably we should just position it as absolute or relative, so it'll scroll normally.
,
Nov 7 2017
Sure, I guess. P1 it is.
,
Nov 7 2017
,
Nov 13 2017
Server-side part is landed but not live yet, client-side part is implemented and reviewed (crrev.com/c/757438), waiting for server to go live before landing.
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d430286f038a0e4d273c0c1340a10865c62e481 commit 8d430286f038a0e4d273c0c1340a10865c62e481 Author: Marc Treib <treib@chromium.org> Date: Wed Nov 15 22:25:43 2017 Local NTP OneGoogleBar: Use position: absolute instead of fixed This makes the OGB scroll normally, instead of sticking to the top. Bug: 782218 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5948bba3a6c618ef48df9e22dd0ba1cd2ab025ed Reviewed-on: https://chromium-review.googlesource.com/757438 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#516861} [modify] https://crrev.com/8d430286f038a0e4d273c0c1340a10865c62e481/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/8d430286f038a0e4d273c0c1340a10865c62e481/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc [modify] https://crrev.com/8d430286f038a0e4d273c0c1340a10865c62e481/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl_unittest.cc
,
Nov 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mastiz@chromium.org
, Nov 7 2017